* [PATCH v4.19-v6.1] drm/amdgpu: Using uninitialized value *size when calling
@ 2024-08-28 15:15 Vamsi Krishna Brahmajosyula
2024-08-29 16:19 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Vamsi Krishna Brahmajosyula @ 2024-08-28 15:15 UTC (permalink / raw)
To: stable, gregkh
Cc: jesse.zhang, alexander.deucher, sashal, christian.koenig,
Xinhui.Pan, airlied, daniel, amd-gfx, dri-devel, linux-kernel,
ajay.kaher, alexey.makhalov, vasavi.sirnapalli,
Vamsi Krishna Brahmajosyula
From: Jesse Zhang <jesse.zhang@amd.com>
[ Upstream commit 88a9a467c548d0b3c7761b4fd54a68e70f9c0944 ]
Initialize the size before calling amdgpu_vce_cs_reloc, such as case 0x03000001.
V2: To really improve the handling we would actually
need to have a separate value of 0xffffffff.(Christian)
Signed-off-by: Jesse Zhang <jesse.zhang@amd.com>
Suggested-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Vamsi Krishna Brahmajosyula <vamsi-krishna.brahmajosyula@broadcom.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
index ecaa2d748..0a28daa14 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
@@ -725,7 +725,8 @@ int amdgpu_vce_ring_parse_cs(struct amdgpu_cs_parser *p, uint32_t ib_idx)
uint32_t created = 0;
uint32_t allocated = 0;
uint32_t tmp, handle = 0;
- uint32_t *size = &tmp;
+ uint32_t dummy = 0xffffffff;
+ uint32_t *size = &dummy;
unsigned idx;
int i, r = 0;
--
2.39.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v4.19-v6.1] drm/amdgpu: Using uninitialized value *size when calling
2024-08-28 15:15 [PATCH v4.19-v6.1] drm/amdgpu: Using uninitialized value *size when calling Vamsi Krishna Brahmajosyula
@ 2024-08-29 16:19 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2024-08-29 16:19 UTC (permalink / raw)
To: Vamsi Krishna Brahmajosyula
Cc: stable, jesse.zhang, alexander.deucher, sashal, christian.koenig,
Xinhui.Pan, airlied, daniel, amd-gfx, dri-devel, linux-kernel,
ajay.kaher, alexey.makhalov, vasavi.sirnapalli
On Wed, Aug 28, 2024 at 10:15:56AM -0500, Vamsi Krishna Brahmajosyula wrote:
> From: Jesse Zhang <jesse.zhang@amd.com>
>
> [ Upstream commit 88a9a467c548d0b3c7761b4fd54a68e70f9c0944 ]
>
> Initialize the size before calling amdgpu_vce_cs_reloc, such as case 0x03000001.
> V2: To really improve the handling we would actually
> need to have a separate value of 0xffffffff.(Christian)
>
> Signed-off-by: Jesse Zhang <jesse.zhang@amd.com>
> Suggested-by: Christian König <christian.koenig@amd.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> Signed-off-by: Vamsi Krishna Brahmajosyula <vamsi-krishna.brahmajosyula@broadcom.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-29 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-28 15:15 [PATCH v4.19-v6.1] drm/amdgpu: Using uninitialized value *size when calling Vamsi Krishna Brahmajosyula
2024-08-29 16:19 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®