* [PATCH] sched: remove unused __HAVE_THREAD_FUNCTIONS hook support
@ 2024-08-22 4:33 David Disseldorp
2024-08-30 1:25 ` David Disseldorp
0 siblings, 1 reply; 3+ messages in thread
From: David Disseldorp @ 2024-08-22 4:33 UTC (permalink / raw)
To: linux-kernel
Cc: linux-kernel-library, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Mel Gorman, Hajime Tazaki, David Disseldorp
__HAVE_THREAD_FUNCTIONS could be defined by architectures wishing to
provide their own task_thread_info(), task_stack_page(),
setup_thread_stack() and end_of_stack() hooks.
Commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture")
removed the last upstream consumer of __HAVE_THREAD_FUNCTIONS, so change
the remaining !CONFIG_THREAD_INFO_IN_TASK && !__HAVE_THREAD_FUNCTIONS
conditionals to only check for the former case.
Signed-off-by: David Disseldorp <ddiss@suse.de>
---
include/linux/sched.h | 2 +-
include/linux/sched/task_stack.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index f8d150343d42..9dbcdfe173cf 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1874,7 +1874,7 @@ extern unsigned long init_stack[THREAD_SIZE / sizeof(unsigned long)];
#ifdef CONFIG_THREAD_INFO_IN_TASK
# define task_thread_info(task) (&(task)->thread_info)
-#elif !defined(__HAVE_THREAD_FUNCTIONS)
+#else
# define task_thread_info(task) ((struct thread_info *)(task)->stack)
#endif
diff --git a/include/linux/sched/task_stack.h b/include/linux/sched/task_stack.h
index ccd72b978e1f..55042ff01a6d 100644
--- a/include/linux/sched/task_stack.h
+++ b/include/linux/sched/task_stack.h
@@ -33,7 +33,7 @@ static __always_inline unsigned long *end_of_stack(const struct task_struct *tas
#endif
}
-#elif !defined(__HAVE_THREAD_FUNCTIONS)
+#else
#define task_stack_page(task) ((void *)(task)->stack)
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sched: remove unused __HAVE_THREAD_FUNCTIONS hook support
2024-08-22 4:33 [PATCH] sched: remove unused __HAVE_THREAD_FUNCTIONS hook support David Disseldorp
@ 2024-08-30 1:25 ` David Disseldorp
2024-08-30 9:07 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: David Disseldorp @ 2024-08-30 1:25 UTC (permalink / raw)
To: linux-kernel
Cc: linux-kernel-library, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Mel Gorman, Hajime Tazaki, Ard Biesheuvel
[cc'ing Ard as ia64 remover]
Ping - any thoughts on this patch?
On Thu, 22 Aug 2024 04:33:28 +0000, David Disseldorp wrote:
> __HAVE_THREAD_FUNCTIONS could be defined by architectures wishing to
> provide their own task_thread_info(), task_stack_page(),
> setup_thread_stack() and end_of_stack() hooks.
>
> Commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture")
> removed the last upstream consumer of __HAVE_THREAD_FUNCTIONS, so change
> the remaining !CONFIG_THREAD_INFO_IN_TASK && !__HAVE_THREAD_FUNCTIONS
> conditionals to only check for the former case.
>
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> ---
> include/linux/sched.h | 2 +-
> include/linux/sched/task_stack.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index f8d150343d42..9dbcdfe173cf 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1874,7 +1874,7 @@ extern unsigned long init_stack[THREAD_SIZE / sizeof(unsigned long)];
>
> #ifdef CONFIG_THREAD_INFO_IN_TASK
> # define task_thread_info(task) (&(task)->thread_info)
> -#elif !defined(__HAVE_THREAD_FUNCTIONS)
> +#else
> # define task_thread_info(task) ((struct thread_info *)(task)->stack)
> #endif
>
> diff --git a/include/linux/sched/task_stack.h b/include/linux/sched/task_stack.h
> index ccd72b978e1f..55042ff01a6d 100644
> --- a/include/linux/sched/task_stack.h
> +++ b/include/linux/sched/task_stack.h
> @@ -33,7 +33,7 @@ static __always_inline unsigned long *end_of_stack(const struct task_struct *tas
> #endif
> }
>
> -#elif !defined(__HAVE_THREAD_FUNCTIONS)
> +#else
>
> #define task_stack_page(task) ((void *)(task)->stack)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sched: remove unused __HAVE_THREAD_FUNCTIONS hook support
2024-08-30 1:25 ` David Disseldorp
@ 2024-08-30 9:07 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2024-08-30 9:07 UTC (permalink / raw)
To: David Disseldorp
Cc: linux-kernel, linux-kernel-library, Ingo Molnar, Peter Zijlstra,
Juri Lelli, Vincent Guittot, Mel Gorman, Hajime Tazaki
On Fri, 30 Aug 2024 at 03:26, David Disseldorp <ddiss@suse.de> wrote:
>
> [cc'ing Ard as ia64 remover]
>
> Ping - any thoughts on this patch?
>
> On Thu, 22 Aug 2024 04:33:28 +0000, David Disseldorp wrote:
>
> > __HAVE_THREAD_FUNCTIONS could be defined by architectures wishing to
> > provide their own task_thread_info(), task_stack_page(),
> > setup_thread_stack() and end_of_stack() hooks.
> >
> > Commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture")
> > removed the last upstream consumer of __HAVE_THREAD_FUNCTIONS, so change
> > the remaining !CONFIG_THREAD_INFO_IN_TASK && !__HAVE_THREAD_FUNCTIONS
> > conditionals to only check for the former case.
> >
> > Signed-off-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> > include/linux/sched.h | 2 +-
> > include/linux/sched/task_stack.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/sched.h b/include/linux/sched.h
> > index f8d150343d42..9dbcdfe173cf 100644
> > --- a/include/linux/sched.h
> > +++ b/include/linux/sched.h
> > @@ -1874,7 +1874,7 @@ extern unsigned long init_stack[THREAD_SIZE / sizeof(unsigned long)];
> >
> > #ifdef CONFIG_THREAD_INFO_IN_TASK
> > # define task_thread_info(task) (&(task)->thread_info)
> > -#elif !defined(__HAVE_THREAD_FUNCTIONS)
> > +#else
> > # define task_thread_info(task) ((struct thread_info *)(task)->stack)
> > #endif
> >
> > diff --git a/include/linux/sched/task_stack.h b/include/linux/sched/task_stack.h
> > index ccd72b978e1f..55042ff01a6d 100644
> > --- a/include/linux/sched/task_stack.h
> > +++ b/include/linux/sched/task_stack.h
> > @@ -33,7 +33,7 @@ static __always_inline unsigned long *end_of_stack(const struct task_struct *tas
> > #endif
> > }
> >
> > -#elif !defined(__HAVE_THREAD_FUNCTIONS)
> > +#else
> >
> > #define task_stack_page(task) ((void *)(task)->stack)
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-30 9:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-22 4:33 [PATCH] sched: remove unused __HAVE_THREAD_FUNCTIONS hook support David Disseldorp
2024-08-30 1:25 ` David Disseldorp
2024-08-30 9:07 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®