mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Menglong Dong <menglong8.dong@gmail.com>
To: idosch@nvidia.com, kuba@kernel.org
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	dsahern@kernel.org, dongml2@chinatelecom.cn, amcohen@nvidia.com,
	gnault@redhat.com, bpoirier@nvidia.com, b.galvani@gmail.com,
	razor@blackwall.org, petrm@nvidia.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH net-next v2 05/12] net: vxlan: make vxlan_remcsum() return drop reasons
Date: Fri, 30 Aug 2024 09:59:54 +0800	[thread overview]
Message-ID: <20240830020001.79377-6-dongml2@chinatelecom.cn> (raw)
In-Reply-To: <20240830020001.79377-1-dongml2@chinatelecom.cn>

Make vxlan_remcsum() support skb drop reasons by changing the return
value type of it from bool to enum skb_drop_reason.

The only drop reason in vxlan_remcsum() comes from pskb_may_pull_reason(),
so we just return it.

Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
---
 drivers/net/vxlan/vxlan_core.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index fcd224a1d0c0..76b217d166ef 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -1551,9 +1551,11 @@ static void vxlan_sock_release(struct vxlan_dev *vxlan)
 #endif
 }
 
-static bool vxlan_remcsum(struct vxlanhdr *unparsed,
-			  struct sk_buff *skb, u32 vxflags)
+static enum skb_drop_reason vxlan_remcsum(struct vxlanhdr *unparsed,
+					  struct sk_buff *skb,
+					  u32 vxflags)
 {
+	enum skb_drop_reason reason;
 	size_t start, offset;
 
 	if (!(unparsed->vx_flags & VXLAN_HF_RCO) || skb->remcsum_offload)
@@ -1562,15 +1564,16 @@ static bool vxlan_remcsum(struct vxlanhdr *unparsed,
 	start = vxlan_rco_start(unparsed->vx_vni);
 	offset = start + vxlan_rco_offset(unparsed->vx_vni);
 
-	if (!pskb_may_pull(skb, offset + sizeof(u16)))
-		return false;
+	reason = pskb_may_pull_reason(skb, offset + sizeof(u16));
+	if (reason)
+		return reason;
 
 	skb_remcsum_process(skb, (void *)(vxlan_hdr(skb) + 1), start, offset,
 			    !!(vxflags & VXLAN_F_REMCSUM_NOPARTIAL));
 out:
 	unparsed->vx_flags &= ~VXLAN_HF_RCO;
 	unparsed->vx_vni &= VXLAN_VNI_MASK;
-	return true;
+	return SKB_NOT_DROPPED_YET;
 }
 
 static void vxlan_parse_gbp_hdr(struct vxlanhdr *unparsed,
-- 
2.39.2


  parent reply	other threads:[~2024-08-30  2:02 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  1:59 [PATCH net-next v2 00/12] net: vxlan: add skb drop reasons support Menglong Dong
2024-08-30  1:59 ` [PATCH net-next v2 01/12] net: vxlan: add vxlan to the drop reason subsystem Menglong Dong
2024-08-30 14:42   ` Alexander Lobakin
2024-09-01  3:30     ` Menglong Dong
2024-08-30  1:59 ` [PATCH net-next v2 02/12] net: skb: add pskb_network_may_pull_reason() helper Menglong Dong
2024-08-30 14:45   ` Alexander Lobakin
2024-09-01 12:34     ` Menglong Dong
2024-08-30  1:59 ` [PATCH net-next v2 03/12] net: tunnel: add pskb_inet_may_pull_reason() helper Menglong Dong
2024-08-30  1:59 ` [PATCH net-next v2 04/12] net: tunnel: add skb_vlan_inet_prepare_reason() helper Menglong Dong
2024-08-30 14:47   ` Alexander Lobakin
2024-09-01 12:36     ` Menglong Dong
2024-08-30  1:59 ` Menglong Dong [this message]
2024-08-30 14:49   ` [PATCH net-next v2 05/12] net: vxlan: make vxlan_remcsum() return drop reasons Alexander Lobakin
2024-08-30  1:59 ` [PATCH net-next v2 06/12] net: vxlan: make vxlan_set_mac() " Menglong Dong
2024-08-30 14:57   ` Alexander Lobakin
2024-09-01 12:56     ` Menglong Dong
2024-08-30 15:31   ` Simon Horman
2024-09-01 12:37     ` Menglong Dong
2024-08-30 23:26   ` Jakub Kicinski
2024-09-01 12:47     ` Menglong Dong
2024-09-03  1:12       ` Jakub Kicinski
2024-09-04  1:59         ` Menglong Dong
2024-08-30  1:59 ` [PATCH net-next v2 07/12] net: vxlan: add skb drop reasons to vxlan_rcv() Menglong Dong
2024-08-30 15:04   ` Alexander Lobakin
2024-09-01 13:02     ` Menglong Dong
2024-09-03 12:32       ` Alexander Lobakin
2024-08-30 15:36   ` Simon Horman
2024-09-01 12:48     ` Menglong Dong
2024-08-30  1:59 ` [PATCH net-next v2 08/12] net: vxlan: use vxlan_kfree_skb() in vxlan_xmit() Menglong Dong
2024-08-30 15:34   ` Simon Horman
2024-09-01 13:02     ` Menglong Dong
2024-08-30  1:59 ` [PATCH net-next v2 09/12] net: vxlan: add drop reasons support to vxlan_xmit_one() Menglong Dong
2024-08-30  1:59 ` [PATCH net-next v2 10/12] net: vxlan: use kfree_skb_reason in vxlan_mdb_xmit Menglong Dong
2024-08-30  2:00 ` [PATCH net-next v2 11/12] net: vxlan: use kfree_skb_reason in vxlan_encap_bypass Menglong Dong
2024-08-30  2:00 ` [PATCH net-next v2 12/12] net: vxlan: use vxlan_kfree_skb in encap_bypass_if_local Menglong Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240830020001.79377-6-dongml2@chinatelecom.cn \
    --to=menglong8.dong@gmail.com \
    --cc=amcohen@nvidia.com \
    --cc=b.galvani@gmail.com \
    --cc=bpoirier@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dongml2@chinatelecom.cn \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=gnault@redhat.com \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=razor@blackwall.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®