From: Menglong Dong <menglong8.dong@gmail.com>
To: idosch@nvidia.com, kuba@kernel.org
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
dsahern@kernel.org, dongml2@chinatelecom.cn, amcohen@nvidia.com,
gnault@redhat.com, bpoirier@nvidia.com, b.galvani@gmail.com,
razor@blackwall.org, petrm@nvidia.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH net-next v2 08/12] net: vxlan: use vxlan_kfree_skb() in vxlan_xmit()
Date: Fri, 30 Aug 2024 09:59:57 +0800 [thread overview]
Message-ID: <20240830020001.79377-9-dongml2@chinatelecom.cn> (raw)
In-Reply-To: <20240830020001.79377-1-dongml2@chinatelecom.cn>
Replace kfree_skb() with vxlan_kfree_skb() in vxlan_xmit(). Following
new skb drop reasons are introduced for vxlan:
/* no remote found */
VXLAN_DROP_NO_REMOTE
And following drop reason is introduced to dropreason-core:
/* txinfo is missed in "external" mode */
SKB_DROP_REASON_TUNNEL_TXINFO
Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
---
v2:
- move the drop reason "TXINFO" from vxlan to core
- rename VXLAN_DROP_REMOTE to VXLAN_DROP_NO_REMOTE
---
drivers/net/vxlan/drop.h | 3 +++
drivers/net/vxlan/vxlan_core.c | 6 +++---
include/net/dropreason-core.h | 3 +++
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vxlan/drop.h b/drivers/net/vxlan/drop.h
index 416532633881..a8ad96e0a502 100644
--- a/drivers/net/vxlan/drop.h
+++ b/drivers/net/vxlan/drop.h
@@ -13,6 +13,7 @@
R(VXLAN_DROP_ENTRY_EXISTS) \
R(VXLAN_DROP_INVALID_HDR) \
R(VXLAN_DROP_VNI_NOT_FOUND) \
+ R(VXLAN_DROP_NO_REMOTE) \
/* deliberate comment for trailing \ */
enum vxlan_drop_reason {
@@ -33,6 +34,8 @@ enum vxlan_drop_reason {
VXLAN_DROP_INVALID_HDR,
/** @VXLAN_DROP_VNI_NOT_FOUND: no vxlan device found for the vni */
VXLAN_DROP_VNI_NOT_FOUND,
+ /** @VXLAN_DROP_NO_REMOTE: no remote found to transmit the packet */
+ VXLAN_DROP_NO_REMOTE,
};
static inline void
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index ab1c14a807f2..c3bdac6834d4 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -2728,7 +2728,7 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev)
if (info && info->mode & IP_TUNNEL_INFO_TX)
vxlan_xmit_one(skb, dev, vni, NULL, false);
else
- kfree_skb(skb);
+ kfree_skb_reason(skb, SKB_DROP_REASON_TUNNEL_TXINFO);
return NETDEV_TX_OK;
}
}
@@ -2791,7 +2791,7 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev)
dev_core_stats_tx_dropped_inc(dev);
vxlan_vnifilter_count(vxlan, vni, NULL,
VXLAN_VNI_STATS_TX_DROPS, 0);
- kfree_skb(skb);
+ vxlan_kfree_skb(skb, VXLAN_DROP_NO_REMOTE);
return NETDEV_TX_OK;
}
}
@@ -2814,7 +2814,7 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev)
if (fdst)
vxlan_xmit_one(skb, dev, vni, fdst, did_rsc);
else
- kfree_skb(skb);
+ vxlan_kfree_skb(skb, VXLAN_DROP_NO_REMOTE);
}
return NETDEV_TX_OK;
diff --git a/include/net/dropreason-core.h b/include/net/dropreason-core.h
index d38371f33e2b..77bd92f507d8 100644
--- a/include/net/dropreason-core.h
+++ b/include/net/dropreason-core.h
@@ -93,6 +93,7 @@
FN(TC_CHAIN_NOTFOUND) \
FN(TC_RECLASSIFY_LOOP) \
FN(IP_TUNNEL_ECN) \
+ FN(TUNNEL_TXINFO) \
FNe(MAX)
/**
@@ -424,6 +425,8 @@ enum skb_drop_reason {
* RFC 6040 4.2, see __INET_ECN_decapsulate() for detail.
*/
SKB_DROP_REASON_IP_TUNNEL_ECN,
+ /** @SKB_DROP_REASON_TUNNEL_TXINFO: tx info for tunnel is missed */
+ SKB_DROP_REASON_TUNNEL_TXINFO,
/**
* @SKB_DROP_REASON_MAX: the maximum of core drop reasons, which
* shouldn't be used as a real 'reason' - only for tracing code gen
--
2.39.2
next prev parent reply other threads:[~2024-08-30 2:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 1:59 [PATCH net-next v2 00/12] net: vxlan: add skb drop reasons support Menglong Dong
2024-08-30 1:59 ` [PATCH net-next v2 01/12] net: vxlan: add vxlan to the drop reason subsystem Menglong Dong
2024-08-30 14:42 ` Alexander Lobakin
2024-09-01 3:30 ` Menglong Dong
2024-08-30 1:59 ` [PATCH net-next v2 02/12] net: skb: add pskb_network_may_pull_reason() helper Menglong Dong
2024-08-30 14:45 ` Alexander Lobakin
2024-09-01 12:34 ` Menglong Dong
2024-08-30 1:59 ` [PATCH net-next v2 03/12] net: tunnel: add pskb_inet_may_pull_reason() helper Menglong Dong
2024-08-30 1:59 ` [PATCH net-next v2 04/12] net: tunnel: add skb_vlan_inet_prepare_reason() helper Menglong Dong
2024-08-30 14:47 ` Alexander Lobakin
2024-09-01 12:36 ` Menglong Dong
2024-08-30 1:59 ` [PATCH net-next v2 05/12] net: vxlan: make vxlan_remcsum() return drop reasons Menglong Dong
2024-08-30 14:49 ` Alexander Lobakin
2024-08-30 1:59 ` [PATCH net-next v2 06/12] net: vxlan: make vxlan_set_mac() " Menglong Dong
2024-08-30 14:57 ` Alexander Lobakin
2024-09-01 12:56 ` Menglong Dong
2024-08-30 15:31 ` Simon Horman
2024-09-01 12:37 ` Menglong Dong
2024-08-30 23:26 ` Jakub Kicinski
2024-09-01 12:47 ` Menglong Dong
2024-09-03 1:12 ` Jakub Kicinski
2024-09-04 1:59 ` Menglong Dong
2024-08-30 1:59 ` [PATCH net-next v2 07/12] net: vxlan: add skb drop reasons to vxlan_rcv() Menglong Dong
2024-08-30 15:04 ` Alexander Lobakin
2024-09-01 13:02 ` Menglong Dong
2024-09-03 12:32 ` Alexander Lobakin
2024-08-30 15:36 ` Simon Horman
2024-09-01 12:48 ` Menglong Dong
2024-08-30 1:59 ` Menglong Dong [this message]
2024-08-30 15:34 ` [PATCH net-next v2 08/12] net: vxlan: use vxlan_kfree_skb() in vxlan_xmit() Simon Horman
2024-09-01 13:02 ` Menglong Dong
2024-08-30 1:59 ` [PATCH net-next v2 09/12] net: vxlan: add drop reasons support to vxlan_xmit_one() Menglong Dong
2024-08-30 1:59 ` [PATCH net-next v2 10/12] net: vxlan: use kfree_skb_reason in vxlan_mdb_xmit Menglong Dong
2024-08-30 2:00 ` [PATCH net-next v2 11/12] net: vxlan: use kfree_skb_reason in vxlan_encap_bypass Menglong Dong
2024-08-30 2:00 ` [PATCH net-next v2 12/12] net: vxlan: use vxlan_kfree_skb in encap_bypass_if_local Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830020001.79377-9-dongml2@chinatelecom.cn \
--to=menglong8.dong@gmail.com \
--cc=amcohen@nvidia.com \
--cc=b.galvani@gmail.com \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=dongml2@chinatelecom.cn \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®