mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: linux-erofs@lists.ozlabs.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Gao Xiang <hsiangkao@linux.alibaba.com>
Subject: [PATCH v2 4/4] erofs: mark experimental fscache backend deprecated
Date: Fri, 30 Aug 2024 11:28:40 +0800	[thread overview]
Message-ID: <20240830032840.3783206-4-hsiangkao@linux.alibaba.com> (raw)
In-Reply-To: <20240830032840.3783206-1-hsiangkao@linux.alibaba.com>

Although fscache is still described as "General Filesystem Caching" for
network filesystems and other things such as ISO9660 filesystems, it has
actually become a part of netfslib recently, which was unexpected at the
time when "EROFS over fscache" proposed (2021) since EROFS is entirely a
disk filesystem and the dependency is redundant.

Mark it deprecated and it will be removed after "fanotify pre-content
hooks" lands, which will provide the same functionality for EROFS.

Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
 fs/erofs/Kconfig | 5 ++++-
 fs/erofs/super.c | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
index 1428d0530e1c..6ea60661fa55 100644
--- a/fs/erofs/Kconfig
+++ b/fs/erofs/Kconfig
@@ -145,7 +145,7 @@ config EROFS_FS_ZIP_ZSTD
 	  If unsure, say N.
 
 config EROFS_FS_ONDEMAND
-	bool "EROFS fscache-based on-demand read support"
+	bool "EROFS fscache-based on-demand read support (deprecated)"
 	depends on EROFS_FS
 	select NETFS_SUPPORT
 	select FSCACHE
@@ -155,6 +155,9 @@ config EROFS_FS_ONDEMAND
 	  This permits EROFS to use fscache-backed data blobs with on-demand
 	  read support.
 
+	  It is now deprecated and scheduled to be removed from the kernel
+	  after fanotify pre-content hooks are landed.
+
 	  If unsure, say N.
 
 config EROFS_FS_PCPU_KTHREAD
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 9a7e67eceed4..666873f745da 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -353,7 +353,7 @@ static int erofs_read_superblock(struct super_block *sb)
 	ret = erofs_scan_devices(sb, dsb);
 
 	if (erofs_is_fscache_mode(sb))
-		erofs_info(sb, "EXPERIMENTAL fscache-based on-demand read feature in use. Use at your own risk!");
+		erofs_info(sb, "[deprecated] fscache-based on-demand read feature in use. Use at your own risk!");
 out:
 	erofs_put_metabuf(&buf);
 	return ret;
-- 
2.43.5


  parent reply	other threads:[~2024-08-30  3:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  3:28 [PATCH v2 1/4] erofs: add file-backed mount support Gao Xiang
2024-08-30  3:28 ` [PATCH v2 2/4] erofs: support unencoded inodes for fileio Gao Xiang
2024-08-31  0:19   ` Sandeep Dhavale
2024-08-31  2:54     ` Gao Xiang
2024-08-31  4:25   ` Sandeep Dhavale
2024-08-31  7:54     ` Gao Xiang
2024-09-01 20:47       ` Sandeep Dhavale
2024-09-04  6:56   ` Gao Xiang
2024-09-05  9:01   ` Chao Yu
2024-09-05  9:13     ` Gao Xiang
2024-08-30  3:28 ` [PATCH v2 3/4] erofs: support compressed " Gao Xiang
2024-09-01 20:47   ` Sandeep Dhavale
2024-09-05  9:01   ` Chao Yu
2024-09-05  9:14     ` Gao Xiang
2024-09-05  9:46   ` Chao Yu
2024-08-30  3:28 ` Gao Xiang [this message]
2024-09-01 20:48   ` [PATCH v2 4/4] erofs: mark experimental fscache backend deprecated Sandeep Dhavale
2024-09-05  9:03   ` Chao Yu
2024-08-31  0:30 ` [PATCH v2 1/4] erofs: add file-backed mount support Sandeep Dhavale
2024-08-31  3:00   ` Gao Xiang
2024-09-01 20:46 ` Sandeep Dhavale
2024-09-05  8:22 ` Chao Yu
2024-09-05  9:30 ` [PATCH v3 2/4] erofs: support unencoded inodes for fileio Gao Xiang
2024-09-05  9:44   ` Chao Yu
2024-09-24  9:21 ` [PATCH v2 1/4] erofs: add file-backed mount support Geert Uytterhoeven
2024-09-24  9:29   ` Gao Xiang
2024-09-30 14:18   ` Jan Kara
2024-09-30 14:22     ` Geert Uytterhoeven
2024-10-02  6:12     ` Christian Brauner
2024-10-02 11:25       ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240830032840.3783206-4-hsiangkao@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®