From: Dragos Tatulea <dtatulea@nvidia.com>
To: "Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Eugenio Perez Martin <eperezma@redhat.com>,
Si-Wei Liu <si-wei.liu@oracle.com>,
<virtualization@lists.linux.dev>, Gal Pressman <gal@nvidia.com>
Cc: Dragos Tatulea <dtatulea@nvidia.com>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Parav Pandit <parav@nvidia.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [PATCH vhost v2 0/7] vdpa/mlx5: Optimze MKEY operations
Date: Fri, 30 Aug 2024 13:58:31 +0300 [thread overview]
Message-ID: <20240830105838.2666587-2-dtatulea@nvidia.com> (raw)
This series improves the time of .set_map() operations by parallelizing
the MKEY creation and deletion for direct MKEYs. Looking at the top
level MKEY creation/deletion functions, the following improvement can be
seen:
|-------------------+-------------|
| operation | improvement |
|-------------------+-------------|
| create_user_mr() | 3-5x |
| destroy_user_mr() | 8x |
|-------------------+-------------|
The last part of the series introduces lazy MKEY deletion which
postpones the MKEY deletion to a later point in a workqueue.
As this series and the previous ones were targeting live migration,
we can also observe improvements on this front:
|-------------------+------------------+------------------|
| Stage | Downtime #1 (ms) | Downtime #2 (ms) |
|-------------------+------------------+------------------|
| Baseline | 3140 | 3630 |
| Parallel MKEY ops | 1200 | 2000 |
| Deferred deletion | 1014 | 1253 |
|-------------------+------------------+------------------|
Test configuration: 256 GB VM, 32 CPUs x 2 threads per core, 4 x mlx5
vDPA devices x 32 VQs (16 VQPs)
This series must be applied on top of the parallel VQ suspend/resume
series [0].
[0] https://lore.kernel.org/all/20240816090159.1967650-1-dtatulea@nvidia.com/
---
v2:
- Swapped flex array usage for plain zero length array in first patch.
- Updated code to use Scope-Based Cleanup Helpers where appropriate
(only second patch).
- Added macro define for MTT alignment in first patch.
- Improved commit messages/comments based on review comments.
- Removed extra newlines.
---
Dragos Tatulea (7):
vdpa/mlx5: Create direct MKEYs in parallel
vdpa/mlx5: Delete direct MKEYs in parallel
vdpa/mlx5: Rename function
vdpa/mlx5: Extract mr members in own resource struct
vdpa/mlx5: Rename mr_mtx -> lock
vdpa/mlx5: Introduce init/destroy for MR resources
vdpa/mlx5: Postpone MR deletion
drivers/vdpa/mlx5/core/mlx5_vdpa.h | 25 ++-
drivers/vdpa/mlx5/core/mr.c | 288 +++++++++++++++++++++++++----
drivers/vdpa/mlx5/core/resources.c | 3 -
drivers/vdpa/mlx5/net/mlx5_vnet.c | 53 +++---
4 files changed, 296 insertions(+), 73 deletions(-)
--
2.45.1
next reply other threads:[~2024-08-30 10:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 10:58 Dragos Tatulea [this message]
2024-08-30 10:58 ` [PATCH vhost v2 1/7] vdpa/mlx5: Create direct MKEYs in parallel Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 2/7] vdpa/mlx5: Delete " Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 3/7] vdpa/mlx5: Rename function Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 4/7] vdpa/mlx5: Extract mr members in own resource struct Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 5/7] vdpa/mlx5: Rename mr_mtx -> lock Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 6/7] vdpa/mlx5: Introduce init/destroy for MR resources Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 7/7] vdpa/mlx5: Postpone MR deletion Dragos Tatulea
2024-09-09 9:30 ` [PATCH vhost v2 0/7] vdpa/mlx5: Optimze MKEY operations Dragos Tatulea
2024-09-11 8:02 ` Eugenio Perez Martin
2024-09-11 17:05 ` Dragos Tatulea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830105838.2666587-2-dtatulea@nvidia.com \
--to=dtatulea@nvidia.com \
--cc=eperezma@redhat.com \
--cc=gal@nvidia.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®