mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dragos Tatulea <dtatulea@nvidia.com>
To: "Michael S . Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Eugenio Perez Martin <eperezma@redhat.com>,
	Si-Wei Liu <si-wei.liu@oracle.com>,
	virtualization@lists.linux.dev, Gal Pressman <gal@nvidia.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Parav Pandit <parav@nvidia.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH vhost v2 0/7] vdpa/mlx5: Optimze MKEY operations
Date: Mon, 9 Sep 2024 11:30:22 +0200	[thread overview]
Message-ID: <fb6b1d3d-c200-479a-941e-1b994757b049@nvidia.com> (raw)
In-Reply-To: <20240830105838.2666587-2-dtatulea@nvidia.com>



On 30.08.24 12:58, Dragos Tatulea wrote:
> This series improves the time of .set_map() operations by parallelizing
> the MKEY creation and deletion for direct MKEYs. Looking at the top
> level MKEY creation/deletion functions, the following improvement can be
> seen:
> 
> |-------------------+-------------|
> | operation         | improvement |
> |-------------------+-------------|
> | create_user_mr()  | 3-5x        |
> | destroy_user_mr() | 8x          |
> |-------------------+-------------|
> 
> The last part of the series introduces lazy MKEY deletion which
> postpones the MKEY deletion to a later point in a workqueue.
> 
> As this series and the previous ones were targeting live migration,
> we can also observe improvements on this front:
> 
> |-------------------+------------------+------------------|
> | Stage             | Downtime #1 (ms) | Downtime #2 (ms) |
> |-------------------+------------------+------------------|
> | Baseline          | 3140             | 3630             |
> | Parallel MKEY ops | 1200             | 2000             |
> | Deferred deletion | 1014             | 1253             |
> |-------------------+------------------+------------------|
> 
> Test configuration: 256 GB VM, 32 CPUs x 2 threads per core, 4 x mlx5
> vDPA devices x 32 VQs (16 VQPs)
> 
> This series must be applied on top of the parallel VQ suspend/resume
> series [0].
> 
> [0] https://lore.kernel.org/all/20240816090159.1967650-1-dtatulea@nvidia.com/
> 
> ---
> v2:
> - Swapped flex array usage for plain zero length array in first patch.
> - Updated code to use Scope-Based Cleanup Helpers where appropriate
>   (only second patch).
> - Added macro define for MTT alignment in first patch.
> - Improved commit messages/comments based on review comments.
> - Removed extra newlines.
Gentle ping for the remaining patches in v2.

Thanks,
Dragos

  parent reply	other threads:[~2024-09-09  9:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30 10:58 Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 1/7] vdpa/mlx5: Create direct MKEYs in parallel Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 2/7] vdpa/mlx5: Delete " Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 3/7] vdpa/mlx5: Rename function Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 4/7] vdpa/mlx5: Extract mr members in own resource struct Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 5/7] vdpa/mlx5: Rename mr_mtx -> lock Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 6/7] vdpa/mlx5: Introduce init/destroy for MR resources Dragos Tatulea
2024-08-30 10:58 ` [PATCH vhost v2 7/7] vdpa/mlx5: Postpone MR deletion Dragos Tatulea
2024-09-09  9:30 ` Dragos Tatulea [this message]
2024-09-11  8:02   ` [PATCH vhost v2 0/7] vdpa/mlx5: Optimze MKEY operations Eugenio Perez Martin
2024-09-11 17:05     ` Dragos Tatulea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb6b1d3d-c200-479a-941e-1b994757b049@nvidia.com \
    --to=dtatulea@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=gal@nvidia.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=si-wei.liu@oracle.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®