mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH V5] scsi: ufs: qcom: update MODE_MAX cfg_bw value
@ 2024-09-02 11:47 Manish Pandey
  2024-09-02 12:47 ` Manivannan Sadhasivam
  0 siblings, 1 reply; 2+ messages in thread
From: Manish Pandey @ 2024-09-02 11:47 UTC (permalink / raw)
  To: Manivannan Sadhasivam, James E.J. Bottomley, Martin K. Petersen
  Cc: linux-arm-msm, linux-scsi, linux-kernel, quic_nitirawa,
	quic_bhaskarv, quic_narepall, quic_rampraka, quic_mapa,
	quic_cang, quic_nguyenb, stable

Commit 8db8f6ce556a ("scsi: ufs: qcom: Add missing interconnect
bandwidth values for Gear 5") updates the ufs_qcom_bw_table for
Gear 5. However, it misses updating the cfg_bw value for the max
mode.

Hence update the cfg_bw value for the max mode for UFS 4.x devices.

Fixes: 8db8f6ce556a ("scsi: ufs: qcom: Add missing interconnect
bandwidth values for Gear 5")
Cc: stable@vger.kernel.org
Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>
---
Changes from v4:
- Updated commit message.

Changes from v3:
- Cced stable@vger.kernel.org.

Changes from v2:
- Addressed Mani comment, added fixes tag.

Changes from v1:
- Updated commit message.
---
 drivers/ufs/host/ufs-qcom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index c87fdc849c62..ecdfff2456e3 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -93,7 +93,7 @@ static const struct __ufs_qcom_bw_table {
 	[MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582,	204800 },
 	[MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200,	409600 },
 	[MODE_HS_RB][UFS_HS_G5][UFS_LANE_2] = { 5836800,	819200 },
-	[MODE_MAX][0][0]		    = { 7643136,	307200 },
+	[MODE_MAX][0][0]		    = { 7643136,	819200 },
 };
 
 static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH V5] scsi: ufs: qcom: update MODE_MAX cfg_bw value
  2024-09-02 11:47 [PATCH V5] scsi: ufs: qcom: update MODE_MAX cfg_bw value Manish Pandey
@ 2024-09-02 12:47 ` Manivannan Sadhasivam
  0 siblings, 0 replies; 2+ messages in thread
From: Manivannan Sadhasivam @ 2024-09-02 12:47 UTC (permalink / raw)
  To: Manish Pandey
  Cc: James E.J. Bottomley, Martin K. Petersen, linux-arm-msm,
	linux-scsi, linux-kernel, quic_nitirawa, quic_bhaskarv,
	quic_narepall, quic_rampraka, quic_cang, quic_nguyenb, stable

On Mon, Sep 02, 2024 at 05:17:37PM +0530, Manish Pandey wrote:
> Commit 8db8f6ce556a ("scsi: ufs: qcom: Add missing interconnect
> bandwidth values for Gear 5") updates the ufs_qcom_bw_table for

s/updates/updated

> Gear 5. However, it misses updating the cfg_bw value for the max

s/misses/missed

> mode.
> 
> Hence update the cfg_bw value for the max mode for UFS 4.x devices.
> 
> Fixes: 8db8f6ce556a ("scsi: ufs: qcom: Add missing interconnect
> bandwidth values for Gear 5")
> Cc: stable@vger.kernel.org
> Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
> Changes from v4:
> - Updated commit message.
> 
> Changes from v3:
> - Cced stable@vger.kernel.org.
> 
> Changes from v2:
> - Addressed Mani comment, added fixes tag.
> 
> Changes from v1:
> - Updated commit message.
> ---
>  drivers/ufs/host/ufs-qcom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index c87fdc849c62..ecdfff2456e3 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -93,7 +93,7 @@ static const struct __ufs_qcom_bw_table {
>  	[MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582,	204800 },
>  	[MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200,	409600 },
>  	[MODE_HS_RB][UFS_HS_G5][UFS_LANE_2] = { 5836800,	819200 },
> -	[MODE_MAX][0][0]		    = { 7643136,	307200 },
> +	[MODE_MAX][0][0]		    = { 7643136,	819200 },
>  };
>  
>  static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host);
> -- 
> 2.17.1
> 

-- 
மணிவண்ணன் சதாசிவம்

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-02 12:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-02 11:47 [PATCH V5] scsi: ufs: qcom: update MODE_MAX cfg_bw value Manish Pandey
2024-09-02 12:47 ` Manivannan Sadhasivam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®