mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	<linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH 1/5] debugobjects: Fix the misuse of global variables in fill_pool()
Date: Mon, 2 Sep 2024 22:05:28 +0800	[thread overview]
Message-ID: <20240902140532.2028-2-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20240902140532.2028-1-thunder.leizhen@huawei.com>

The global variable 'obj_pool_min_free' records the lowest historical
value of the number of nodes in the global list 'obj_pool', instead of
being used as the lowest threshold value. This may be a mistake and
should be replaced with variable 'debug_objects_pool_min_level'.

Fixes: d26bf5056fc0 ("debugobjects: Reduce number of pool_lock acquisitions in fill_pool()")
Fixes: 36c4ead6f6df ("debugobjects: Add global free list and the counter")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 lib/debugobjects.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 7cea91e193a8f04..1ea8af72849cdb1 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -142,13 +142,14 @@ static void fill_pool(void)
 	 * READ_ONCE()s pair with the WRITE_ONCE()s in pool_lock critical
 	 * sections.
 	 */
-	while (READ_ONCE(obj_nr_tofree) && (READ_ONCE(obj_pool_free) < obj_pool_min_free)) {
+	while (READ_ONCE(obj_nr_tofree) &&
+	       READ_ONCE(obj_pool_free) < debug_objects_pool_min_level) {
 		raw_spin_lock_irqsave(&pool_lock, flags);
 		/*
 		 * Recheck with the lock held as the worker thread might have
 		 * won the race and freed the global free list already.
 		 */
-		while (obj_nr_tofree && (obj_pool_free < obj_pool_min_free)) {
+		while (obj_nr_tofree && (obj_pool_free < debug_objects_pool_min_level)) {
 			obj = hlist_entry(obj_to_free.first, typeof(*obj), node);
 			hlist_del(&obj->node);
 			WRITE_ONCE(obj_nr_tofree, obj_nr_tofree - 1);
-- 
2.34.1


  reply	other threads:[~2024-09-02 14:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02 14:05 [PATCH 0/5] debugobjects: Do some minor optimizations, fixes and cleaups Zhen Lei
2024-09-02 14:05 ` Zhen Lei [this message]
2024-09-02 16:22   ` [PATCH 1/5] debugobjects: Fix the misuse of global variables in fill_pool() Thomas Gleixner
2024-09-03  2:16     ` Leizhen (ThunderTown)
2024-09-03  3:22       ` Leizhen (ThunderTown)
2024-09-03  7:00         ` Leizhen (ThunderTown)
2024-09-03  9:37           ` Thomas Gleixner
2024-09-03 11:14             ` Leizhen (ThunderTown)
2024-09-03 11:43               ` Thomas Gleixner
2024-09-03 12:22                 ` Leizhen (ThunderTown)
2024-09-02 14:05 ` [PATCH 2/5] debugobjects: Remove redundant checks " Zhen Lei
2024-09-03  9:44   ` Thomas Gleixner
2024-09-03 11:23     ` Leizhen (ThunderTown)
2024-09-02 14:05 ` [PATCH 3/5] debugobjects: Don't start fill if there are remaining nodes locally Zhen Lei
2024-09-03  9:52   ` Thomas Gleixner
2024-09-03 12:06     ` Leizhen (ThunderTown)
2024-09-02 14:05 ` [PATCH 4/5] debugobjects: Use hlist_splice_init() to reduce lock conflicts Zhen Lei
2024-09-03 10:09   ` Thomas Gleixner
2024-09-03 12:14     ` Leizhen (ThunderTown)
2024-09-02 14:05 ` [PATCH 5/5] debugobjects: Delete a piece of redundant code Zhen Lei
2024-09-03 10:14   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240902140532.2028-2-thunder.leizhen@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®