From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] debugobjects: Use hlist_splice_init() to reduce lock conflicts
Date: Tue, 3 Sep 2024 20:14:35 +0800 [thread overview]
Message-ID: <ca59d908-7779-8f84-57df-0298888a7340@huawei.com> (raw)
In-Reply-To: <87le0982vo.ffs@tglx>
On 2024/9/3 18:09, Thomas Gleixner wrote:
> On Mon, Sep 02 2024 at 22:05, Zhen Lei wrote:
>
>> The sub list can be prepared in advance outside the lock, so that the
>> operation time inside the lock can be reduced and the possibility of
>> lock conflict can be reduced.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> lib/debugobjects.c | 18 ++++++++++--------
>> 1 file changed, 10 insertions(+), 8 deletions(-)
>>
>> diff --git a/lib/debugobjects.c b/lib/debugobjects.c
>> index fc8224f9f0eda8f..998724e9dee526b 100644
>> --- a/lib/debugobjects.c
>> +++ b/lib/debugobjects.c
>> @@ -167,23 +167,25 @@ static void fill_pool(void)
>> return;
>>
>> while (READ_ONCE(obj_pool_free) < debug_objects_pool_min_level) {
>> - struct debug_obj *new[ODEBUG_BATCH_SIZE];
>> + HLIST_HEAD(batch_list);
>> + struct debug_obj *new, *last;
>
> Variable ordering please.
OK
>
>> int cnt;
>>
>> for (cnt = 0; cnt < ODEBUG_BATCH_SIZE; cnt++) {
>> - new[cnt] = kmem_cache_zalloc(obj_cache, gfp);
>> - if (!new[cnt])
>> + new = kmem_cache_zalloc(obj_cache, gfp);
>> + if (!new)
>> break;
>> + hlist_add_head(&new->node, &batch_list);
>> + if (cnt == 0)
>
> if (!cnt)
>
> but it would be more self explaining if you have:
>
> struct debug_obj *new, *last = NULL;
>
> and then
> if (!last)
OK, I will change it. I thought so, but I changed it to reduce
the null initialization. Ha ha, wrong choice.
>
>> + last = new;
>> }
>
> Thanks,
>
> tglx
> .
>
--
Regards,
Zhen Lei
next prev parent reply other threads:[~2024-09-03 12:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 14:05 [PATCH 0/5] debugobjects: Do some minor optimizations, fixes and cleaups Zhen Lei
2024-09-02 14:05 ` [PATCH 1/5] debugobjects: Fix the misuse of global variables in fill_pool() Zhen Lei
2024-09-02 16:22 ` Thomas Gleixner
2024-09-03 2:16 ` Leizhen (ThunderTown)
2024-09-03 3:22 ` Leizhen (ThunderTown)
2024-09-03 7:00 ` Leizhen (ThunderTown)
2024-09-03 9:37 ` Thomas Gleixner
2024-09-03 11:14 ` Leizhen (ThunderTown)
2024-09-03 11:43 ` Thomas Gleixner
2024-09-03 12:22 ` Leizhen (ThunderTown)
2024-09-02 14:05 ` [PATCH 2/5] debugobjects: Remove redundant checks " Zhen Lei
2024-09-03 9:44 ` Thomas Gleixner
2024-09-03 11:23 ` Leizhen (ThunderTown)
2024-09-02 14:05 ` [PATCH 3/5] debugobjects: Don't start fill if there are remaining nodes locally Zhen Lei
2024-09-03 9:52 ` Thomas Gleixner
2024-09-03 12:06 ` Leizhen (ThunderTown)
2024-09-02 14:05 ` [PATCH 4/5] debugobjects: Use hlist_splice_init() to reduce lock conflicts Zhen Lei
2024-09-03 10:09 ` Thomas Gleixner
2024-09-03 12:14 ` Leizhen (ThunderTown) [this message]
2024-09-02 14:05 ` [PATCH 5/5] debugobjects: Delete a piece of redundant code Zhen Lei
2024-09-03 10:14 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca59d908-7779-8f84-57df-0298888a7340@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®