mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Carlos Llamas <cmllamas@google.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Martijn Coenen" <maco@android.com>,
	"Joel Fernandes" <joel@joelfernandes.org>,
	"Christian Brauner" <brauner@kernel.org>,
	"Carlos Llamas" <cmllamas@google.com>,
	"Suren Baghdasaryan" <surenb@google.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
	 bajing <bajing@cmss.chinamobile.com>
Subject: [PATCH v3] binder: modify the comment for binder_proc_unlock
Date: Mon,  2 Sep 2024 17:58:09 +0000	[thread overview]
Message-ID: <20240902175810.3758196-1-cmllamas@google.com> (raw)
In-Reply-To: <20240902175446.3757185-1-cmllamas@google.com>

From: bajing <bajing@cmss.chinamobile.com>

Modify the comment for binder_proc_unlock() to clearly indicate which
spinlock it releases and to better match the acquire comment block in
binder_proc_lock().

Signed-off-by: bajing <bajing@cmss.chinamobile.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---

Notes:
    v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@cmss.chinamobile.com/
    
    v2: Reword commit log per suggestions from cmllamas@
    https://lore.kernel.org/all/20240902013636.1739-1-bajing@cmss.chinamobile.com/
    
    v3: Wrap commit message. Add version history.

 drivers/android/binder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 905290c98c3c..089bf2b45f0d 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
 }
 
 /**
- * binder_proc_unlock() - Release spinlock for given binder_proc
+ * binder_proc_unlock() - Release outer lock for given binder_proc
  * @proc:                struct binder_proc to acquire
  *
  * Release lock acquired via binder_proc_lock()
-- 
2.46.0.469.g59c65b2a67-goog


  reply	other threads:[~2024-09-02 17:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02 17:54 [PATCH] " Carlos Llamas
2024-09-02 17:58 ` Carlos Llamas [this message]
2024-09-03  8:52   ` [PATCH v3] " Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2024-09-02  2:57 bajing
2024-09-03  8:52 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240902175810.3758196-1-cmllamas@google.com \
    --to=cmllamas@google.com \
    --cc=arve@android.com \
    --cc=bajing@cmss.chinamobile.com \
    --cc=brauner@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel@joelfernandes.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=surenb@google.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®