[PATCH] binder: modify the comment for binder_proc_unlock

[PATCH] binder: modify the comment for binder_proc_unlock

[Carlos Llamas]

From: bajing <bajing@cmss.chinamobile.com>

Modify the comment for binder_proc_unlock() to clearly indicate which
spinlock it releases and to better match the acquire comment block in
binder_proc_lock().

Signed-off-by: bajing <bajing@cmss.chinamobile.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
 drivers/android/binder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 905290c98c3c..089bf2b45f0d 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
 }
 
 /**
- * binder_proc_unlock() - Release spinlock for given binder_proc
+ * binder_proc_unlock() - Release outer lock for given binder_proc
  * @proc:                struct binder_proc to acquire
  *
  * Release lock acquired via binder_proc_lock()
-- 
2.46.0.469.g59c65b2a67-goog

[PATCH v3] binder: modify the comment for binder_proc_unlock

[Carlos Llamas]

From: bajing <bajing@cmss.chinamobile.com>

Modify the comment for binder_proc_unlock() to clearly indicate which
spinlock it releases and to better match the acquire comment block in
binder_proc_lock().

Signed-off-by: bajing <bajing@cmss.chinamobile.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---

Notes:
    v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@cmss.chinamobile.com/
    
    v2: Reword commit log per suggestions from cmllamas@
    https://lore.kernel.org/all/20240902013636.1739-1-bajing@cmss.chinamobile.com/
    
    v3: Wrap commit message. Add version history.

 drivers/android/binder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 905290c98c3c..089bf2b45f0d 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
 }
 
 /**
- * binder_proc_unlock() - Release spinlock for given binder_proc
+ * binder_proc_unlock() - Release outer lock for given binder_proc
  * @proc:                struct binder_proc to acquire
  *
  * Release lock acquired via binder_proc_lock()
-- 
2.46.0.469.g59c65b2a67-goog

Re: [PATCH v3] binder: modify the comment for binder_proc_unlock

[Greg Kroah-Hartman]

On Mon, Sep 02, 2024 at 05:58:09PM +0000, Carlos Llamas wrote:
> From: bajing <bajing@cmss.chinamobile.com>
> 
> Modify the comment for binder_proc_unlock() to clearly indicate which
> spinlock it releases and to better match the acquire comment block in
> binder_proc_lock().
> 
> Signed-off-by: bajing <bajing@cmss.chinamobile.com>

Sorry, but this needs to be a full name, not just an email alias.

thanks,

greg k-h

[PATCH v3] binder: modify the comment for binder_proc_unlock

[bajing]

Modify the comment for binder_proc_unlock() to clearly indicate which spinlock it releases and to better match the acquire comment block in binder_proc_lock().

Notes:
v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@cmss.chinamobile.com/

v2: Reword commit log per suggestions from cmllamas@
https://lore.kernel.org/all/20240902013636.1739-1-bajing@cmss.chinamobile.com/

v3: Wrap commit message. Add version history.

Signed-off-by: bajing <bajing@cmss.chinamobile.com>
---
 drivers/android/binder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index fc55b5d0e4f3..578861d57045 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
 }
 
 /**
- * binder_proc_unlock() - Release spinlock for given binder_proc
+ * binder_proc_unlock() - Release outer lock for given binder_proc
  * @proc:                struct binder_proc to acquire
  *
  * Release lock acquired via binder_proc_lock()
-- 
2.33.0

Re: [PATCH v3] binder: modify the comment for binder_proc_unlock

[Greg KH]

On Mon, Sep 02, 2024 at 10:57:20AM +0800, bajing wrote:
> Modify the comment for binder_proc_unlock() to clearly indicate which spinlock it releases and to better match the acquire comment block in binder_proc_lock().
> 
> Notes:
> v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@cmss.chinamobile.com/
> 
> v2: Reword commit log per suggestions from cmllamas@
> https://lore.kernel.org/all/20240902013636.1739-1-bajing@cmss.chinamobile.com/
> 
> v3: Wrap commit message. Add version history.

All of the "Notes:" need to go below the --- line, as the documentation
says.

> Signed-off-by: bajing <bajing@cmss.chinamobile.com>

Please use your full name here, not your email alias.

thanks,

greg k-h