* [PATCH] fs/pipe: Correct imprecise wording in comment
@ 2024-09-04 14:13 Kienan Stewart
2024-09-04 14:54 ` Christian Brauner
0 siblings, 1 reply; 2+ messages in thread
From: Kienan Stewart @ 2024-09-04 14:13 UTC (permalink / raw)
To: Alexander Viro, Christian Brauner, Jan Kara
Cc: linux-fsdevel, linux-kernel, linux-janitors, Kienan Stewart
The comment inaccurately describes what pipefs is - that is, a file
system.
Signed-off-by: Kienan Stewart <kstewart@efficios.com>
---
Hi,
while reading through `pipe.c`, I noticed that the comment explaining
why pipefs should not be mounted in user space inaccurately describes
what pipefs is - that is, a file system.
While I understand the original language used in context, I believe
this change increases the legibility of the comment.
thanks,
kienan
---
fs/pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pipe.c b/fs/pipe.c
index 7dff2aa50a6d..9a6dfe39f012 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -1427,7 +1427,7 @@ static const struct super_operations pipefs_ops = {
/*
* pipefs should _never_ be mounted by userland - too much of security hassle,
- * no real gain from having the whole whorehouse mounted. So we don't need
+ * no real gain from having the whole file system mounted. So we don't need
* any operations on the root directory. However, we need a non-trivial
* d_name - pipe: will go nicely and kill the special-casing in procfs.
*/
---
base-commit: d5d547aa7b51467b15d9caa86b116f8c2507c72a
change-id: 20240829-pipe-correct_imprecise_wording-d20e370edbc0
Best regards,
--
Kienan Stewart <kstewart@efficios.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/pipe: Correct imprecise wording in comment
2024-09-04 14:13 [PATCH] fs/pipe: Correct imprecise wording in comment Kienan Stewart
@ 2024-09-04 14:54 ` Christian Brauner
0 siblings, 0 replies; 2+ messages in thread
From: Christian Brauner @ 2024-09-04 14:54 UTC (permalink / raw)
To: Kienan Stewart
Cc: Christian Brauner, linux-fsdevel, linux-kernel, linux-janitors,
Alexander Viro, Jan Kara
On Wed, 04 Sep 2024 10:13:29 -0400, Kienan Stewart wrote:
> The comment inaccurately describes what pipefs is - that is, a file
> system.
>
>
Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc
[1/1] fs/pipe: Correct imprecise wording in comment
https://git.kernel.org/vfs/vfs/c/a5796d69bf18
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-04 14:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-04 14:13 [PATCH] fs/pipe: Correct imprecise wording in comment Kienan Stewart
2024-09-04 14:54 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®