mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH iwl-net] idpf: deinit virtchnl transaction manager after vport and vectors
@ 2024-09-04  9:54 Larysa Zaremba
  2024-09-24 23:12 ` [Intel-wired-lan] " Singh, Krishneil K
  0 siblings, 1 reply; 2+ messages in thread
From: Larysa Zaremba @ 2024-09-04  9:54 UTC (permalink / raw)
  To: intel-wired-lan, Tony Nguyen
  Cc: Larysa Zaremba, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Przemek Kitszel, Joshua Hay, Igor Bagnucki,
	Alan Brady, Michal Kubiak, Alexander Lobakin, Tantilov, Emil S,
	netdev, linux-kernel

When the device is removed, idpf is supposed to make certain virtchnl
requests e.g. VIRTCHNL2_OP_DEALLOC_VECTORS and VIRTCHNL2_OP_DESTROY_VPORT.

However, this does not happen due to the referenced commit introducing
virtchnl transaction manager and placing its deinitialization before those
messages are sent. Then the sending is impossible due to no transactions
being available.

Lack of cleanup can lead to the FW becoming unresponsive from e.g.
unloading-loading the driver and creating-destroying VFs afterwards.

Move transaction manager deinitialization to after other virtchnl-related
cleanup is done.

Fixes: 34c21fa894a1 ("idpf: implement virtchnl transaction manager")
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
---
 drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
index a5f9b7a5effe..f18f490dafd8 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
@@ -3040,9 +3040,9 @@ void idpf_vc_core_deinit(struct idpf_adapter *adapter)
 	if (!test_bit(IDPF_VC_CORE_INIT, adapter->flags))
 		return;
 
-	idpf_vc_xn_shutdown(adapter->vcxn_mngr);
 	idpf_deinit_task(adapter);
 	idpf_intr_rel(adapter);
+	idpf_vc_xn_shutdown(adapter->vcxn_mngr);
 
 	cancel_delayed_work_sync(&adapter->serv_task);
 	cancel_delayed_work_sync(&adapter->mbx_task);
-- 
2.45.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [Intel-wired-lan] [PATCH iwl-net] idpf: deinit virtchnl transaction manager after vport and vectors
  2024-09-04  9:54 [PATCH iwl-net] idpf: deinit virtchnl transaction manager after vport and vectors Larysa Zaremba
@ 2024-09-24 23:12 ` Singh, Krishneil K
  0 siblings, 0 replies; 2+ messages in thread
From: Singh, Krishneil K @ 2024-09-24 23:12 UTC (permalink / raw)
  To: Zaremba, Larysa, intel-wired-lan, Nguyen, Anthony L
  Cc: Tantilov, Emil S, Zaremba, Larysa, Kitszel, Przemyslaw, Hay,
	Joshua A, linux-kernel, Bagnucki, Igor, Lobakin, Aleksander,
	Eric Dumazet, Kubiak, Michal, Alan Brady, netdev, Jakub Kicinski,
	Paolo Abeni, David S. Miller

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Larysa Zaremba
> Sent: Wednesday, September 4, 2024 2:54 AM
> To: intel-wired-lan@lists.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>
> Cc: Tantilov, Emil S <emil.s.tantilov@intel.com>; Zaremba, Larysa
> <larysa.zaremba@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@intel.com>; Hay, Joshua A <joshua.a.hay@intel.com>;
> linux-kernel@vger.kernel.org; Bagnucki, Igor <igor.bagnucki@intel.com>;
> Lobakin, Aleksander <aleksander.lobakin@intel.com>; Eric Dumazet
> <edumazet@google.com>; Kubiak, Michal <michal.kubiak@intel.com>; Alan
> Brady <alan.brady@intel.com>; netdev@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller
> <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-net] idpf: deinit virtchnl transaction
> manager after vport and vectors
> 
> When the device is removed, idpf is supposed to make certain virtchnl
> requests e.g. VIRTCHNL2_OP_DEALLOC_VECTORS and
> VIRTCHNL2_OP_DESTROY_VPORT.
> 
> However, this does not happen due to the referenced commit introducing
> virtchnl transaction manager and placing its deinitialization before those
> messages are sent. Then the sending is impossible due to no transactions
> being available.
> 
> Lack of cleanup can lead to the FW becoming unresponsive from e.g.
> unloading-loading the driver and creating-destroying VFs afterwards.
> 
> Move transaction manager deinitialization to after other virtchnl-related
> cleanup is done.
> 
> Fixes: 34c21fa894a1 ("idpf: implement virtchnl transaction manager")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
> ---
>  drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> index a5f9b7a5effe..f18f490dafd8 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c

Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-24 23:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-04  9:54 [PATCH iwl-net] idpf: deinit virtchnl transaction manager after vport and vectors Larysa Zaremba
2024-09-24 23:12 ` [Intel-wired-lan] " Singh, Krishneil K

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®