From: Carlos Bilbao <carlos.bilbao.osdev@gmail.com>
To: dtatulea@nvidia.com, mst@redhat.com, jasowang@redhat.com,
shannon.nelson@amd.com, sashal@kernel.org,
alvaro.karsz@solid-run.com, christophe.jaillet@wanadoo.fr,
steven.sistare@oracle.com
Cc: bilbao@vt.edu, xuanzhuo@linux.alibaba.com,
johnah.palmer@oracle.com, eperezma@redhat.com, cratiu@nvidia.com,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org,
Carlos Bilbao <cbilbao@digitalocean.com>
Subject: [PATCH v3 0/2] Properly initialize speed/duplex and remove vDPA config updates
Date: Wed, 4 Sep 2024 10:11:13 -0500 [thread overview]
Message-ID: <20240904151115.205622-1-carlos.bilbao.osdev@gmail.com> (raw)
From: Carlos Bilbao <cbilbao@digitalocean.com>
Initialize speed and duplex for virtio_net_config to UNKNOWN (mlx5_vdpa
vDPA devices currently do not support VIRTIO_NET_F_SPEED_DUPLEX). Remove
ioctl VHOST_VDPA_SET_CONFIG and its related logic as it is not supported;
see: https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html
Carlos:
vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN
vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance
---
Changes since v1:
Link: https://lkml.org/lkml/2024/8/29/1368
- Fix prefix of the first commit and add Reviewed-By tag.
- Redo second commit completely: instead of attempting to add support to
set configuration fields, remove ioctl and support entirely from vDPA
implementations -- because it's not allowed by spec.
Changes since v2:
Link: https://lkml.org/lkml/2024/9/3/1407
- Fix first commit by changing 4 spaces for a tab.
- In second commit, ENI is legacy and should keep set_config(). Change it
to set_config_legacy() to avoid future confusion and erroneous
implementations.
---
drivers/vdpa/alibaba/eni_vdpa.c | 2 +-
drivers/vdpa/ifcvf/ifcvf_main.c | 10 ----------
drivers/vdpa/mlx5/net/mlx5_vnet.c | 19 ++++++++++++-------
drivers/vdpa/pds/vdpa_dev.c | 16 ----------------
drivers/vdpa/solidrun/snet_main.c | 18 ------------------
drivers/vdpa/vdpa.c | 16 ----------------
drivers/vdpa/vdpa_sim/vdpa_sim.c | 16 ----------------
drivers/vdpa/vdpa_sim/vdpa_sim.h | 1 -
drivers/vdpa/vdpa_user/vduse_dev.c | 7 -------
drivers/vdpa/virtio_pci/vp_vdpa.c | 14 --------------
drivers/vhost/vdpa.c | 26 --------------------------
drivers/virtio/virtio_vdpa.c | 9 ---------
include/linux/vdpa.h | 7 ++++---
include/uapi/linux/vhost.h | 8 ++++----
14 files changed, 21 insertions(+), 148 deletions(-)
next reply other threads:[~2024-09-04 15:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 15:11 Carlos Bilbao [this message]
2024-09-04 15:11 ` [PATCH v3 1/2] vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN Carlos Bilbao
2024-09-05 2:26 ` Jason Wang
2024-11-07 21:50 ` Michael S. Tsirkin
2024-11-08 9:31 ` Dragos Tatulea
2024-11-08 11:51 ` Michael S. Tsirkin
2024-11-08 23:44 ` Carlos Bilbao
2024-09-04 15:11 ` [PATCH v3 2/2] vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance Carlos Bilbao
2024-09-05 2:25 ` Jason Wang
2024-09-10 6:29 ` [PATCH v3 0/2] Properly initialize speed/duplex and remove vDPA config updates Michael S. Tsirkin
2024-09-11 3:42 ` Jason Wang
2024-09-11 16:55 ` Carlos Bilbao
2024-09-30 20:37 ` Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904151115.205622-1-carlos.bilbao.osdev@gmail.com \
--to=carlos.bilbao.osdev@gmail.com \
--cc=alvaro.karsz@solid-run.com \
--cc=bilbao@vt.edu \
--cc=cbilbao@digitalocean.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cratiu@nvidia.com \
--cc=dtatulea@nvidia.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=johnah.palmer@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sashal@kernel.org \
--cc=shannon.nelson@amd.com \
--cc=steven.sistare@oracle.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®