From: Carlos Bilbao <cbilbao@digitalocean.com>
To: Jason Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Carlos Bilbao <carlos.bilbao.osdev@gmail.com>,
dtatulea@nvidia.com, shannon.nelson@amd.com, sashal@kernel.org,
alvaro.karsz@solid-run.com, christophe.jaillet@wanadoo.fr,
steven.sistare@oracle.com, bilbao@vt.edu,
xuanzhuo@linux.alibaba.com, johnah.palmer@oracle.com,
eperezma@redhat.com, cratiu@nvidia.com,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Properly initialize speed/duplex and remove vDPA config updates
Date: Wed, 11 Sep 2024 11:55:44 -0500 [thread overview]
Message-ID: <4f6db868-d1e8-42b5-92ad-ae22331f5bd1@digitalocean.com> (raw)
In-Reply-To: <CACGkMEscQWywn67yN7fAaRdWkOZV80RryCvyf_02RDWjrKZMwA@mail.gmail.com>
Hello,
On 9/10/24 10:42 PM, Jason Wang wrote:
> On Tue, Sep 10, 2024 at 2:29 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>> On Wed, Sep 04, 2024 at 10:11:13AM -0500, Carlos Bilbao wrote:
>>> From: Carlos Bilbao <cbilbao@digitalocean.com>
>>>
>>> Initialize speed and duplex for virtio_net_config to UNKNOWN (mlx5_vdpa
>>> vDPA devices currently do not support VIRTIO_NET_F_SPEED_DUPLEX). Remove
>>> ioctl VHOST_VDPA_SET_CONFIG and its related logic as it is not supported;
>>> see: https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html
>>>
>>> Carlos:
>>> vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN
>>> vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance
>> This will need a rebase. Will apply once you post one.
>> Thanks!
> Note that I think patch 2 is probably not right as we indeed allow
> config write for some device.
I'll rebase patch 1 and drop patch 2.
>
> Thanks
>
Thanks, Carlos
next prev parent reply other threads:[~2024-09-11 16:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 15:11 Carlos Bilbao
2024-09-04 15:11 ` [PATCH v3 1/2] vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN Carlos Bilbao
2024-09-05 2:26 ` Jason Wang
2024-11-07 21:50 ` Michael S. Tsirkin
2024-11-08 9:31 ` Dragos Tatulea
2024-11-08 11:51 ` Michael S. Tsirkin
2024-11-08 23:44 ` Carlos Bilbao
2024-09-04 15:11 ` [PATCH v3 2/2] vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance Carlos Bilbao
2024-09-05 2:25 ` Jason Wang
2024-09-10 6:29 ` [PATCH v3 0/2] Properly initialize speed/duplex and remove vDPA config updates Michael S. Tsirkin
2024-09-11 3:42 ` Jason Wang
2024-09-11 16:55 ` Carlos Bilbao [this message]
2024-09-30 20:37 ` Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f6db868-d1e8-42b5-92ad-ae22331f5bd1@digitalocean.com \
--to=cbilbao@digitalocean.com \
--cc=alvaro.karsz@solid-run.com \
--cc=bilbao@vt.edu \
--cc=carlos.bilbao.osdev@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cratiu@nvidia.com \
--cc=dtatulea@nvidia.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=johnah.palmer@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sashal@kernel.org \
--cc=shannon.nelson@amd.com \
--cc=steven.sistare@oracle.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®