* [PATCH] drm/panel: khadas-ts050: make ts050[v2]_panel_data static
@ 2024-09-08 13:35 Min-Hua Chen
2024-09-09 13:09 ` Neil Armstrong
2024-09-13 9:18 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Min-Hua Chen @ 2024-09-08 13:35 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Min-Hua Chen, dri-devel, linux-kernel
make ts050_panel_data and ts050v2_panel_data static because they
are only used in drivers/gpu/drm/panel/panel-khadas-ts050.c,
and fix the following sparse warnings:
drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32:
sparse: warning: symbol 'ts050_panel_data' was not declared. Should it be static?
drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32:
sparse: warning: symbol 'ts050v2_panel_data' was not declared. Should it be static?
No functional changes intended.
Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
---
drivers/gpu/drm/panel/panel-khadas-ts050.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/panel/panel-khadas-ts050.c
index 14932cb3defc..0e5e8e57bd1e 100644
--- a/drivers/gpu/drm/panel/panel-khadas-ts050.c
+++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c
@@ -617,12 +617,12 @@ static const struct khadas_ts050_panel_cmd ts050_init_code[] = {
{0xd4, {0x04}, 0x01}, /* RGBMIPICTRL: VSYNC front porch = 4 */
};
-struct khadas_ts050_panel_data ts050_panel_data = {
+static struct khadas_ts050_panel_data ts050_panel_data = {
.init_code = (struct khadas_ts050_panel_cmd *)ts050_init_code,
.len = ARRAY_SIZE(ts050_init_code)
};
-struct khadas_ts050_panel_data ts050v2_panel_data = {
+static struct khadas_ts050_panel_data ts050v2_panel_data = {
.init_code = (struct khadas_ts050_panel_cmd *)ts050v2_init_code,
.len = ARRAY_SIZE(ts050v2_init_code)
};
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panel: khadas-ts050: make ts050[v2]_panel_data static
2024-09-08 13:35 [PATCH] drm/panel: khadas-ts050: make ts050[v2]_panel_data static Min-Hua Chen
@ 2024-09-09 13:09 ` Neil Armstrong
2024-09-13 9:18 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2024-09-09 13:09 UTC (permalink / raw)
To: Min-Hua Chen, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, linux-kernel
On 08/09/2024 15:35, Min-Hua Chen wrote:
> make ts050_panel_data and ts050v2_panel_data static because they
> are only used in drivers/gpu/drm/panel/panel-khadas-ts050.c,
> and fix the following sparse warnings:
>
> drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32:
> sparse: warning: symbol 'ts050_panel_data' was not declared. Should it be static?
> drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32:
> sparse: warning: symbol 'ts050v2_panel_data' was not declared. Should it be static?
>
> No functional changes intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> ---
> drivers/gpu/drm/panel/panel-khadas-ts050.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/panel/panel-khadas-ts050.c
> index 14932cb3defc..0e5e8e57bd1e 100644
> --- a/drivers/gpu/drm/panel/panel-khadas-ts050.c
> +++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c
> @@ -617,12 +617,12 @@ static const struct khadas_ts050_panel_cmd ts050_init_code[] = {
> {0xd4, {0x04}, 0x01}, /* RGBMIPICTRL: VSYNC front porch = 4 */
> };
>
> -struct khadas_ts050_panel_data ts050_panel_data = {
> +static struct khadas_ts050_panel_data ts050_panel_data = {
> .init_code = (struct khadas_ts050_panel_cmd *)ts050_init_code,
> .len = ARRAY_SIZE(ts050_init_code)
> };
>
> -struct khadas_ts050_panel_data ts050v2_panel_data = {
> +static struct khadas_ts050_panel_data ts050v2_panel_data = {
> .init_code = (struct khadas_ts050_panel_cmd *)ts050v2_init_code,
> .len = ARRAY_SIZE(ts050v2_init_code)
> };
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panel: khadas-ts050: make ts050[v2]_panel_data static
2024-09-08 13:35 [PATCH] drm/panel: khadas-ts050: make ts050[v2]_panel_data static Min-Hua Chen
2024-09-09 13:09 ` Neil Armstrong
@ 2024-09-13 9:18 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2024-09-13 9:18 UTC (permalink / raw)
To: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Min-Hua Chen
Cc: dri-devel, linux-kernel
Hi,
On Sun, 08 Sep 2024 21:35:30 +0800, Min-Hua Chen wrote:
> make ts050_panel_data and ts050v2_panel_data static because they
> are only used in drivers/gpu/drm/panel/panel-khadas-ts050.c,
> and fix the following sparse warnings:
>
> drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32:
> sparse: warning: symbol 'ts050_panel_data' was not declared. Should it be static?
> drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32:
> sparse: warning: symbol 'ts050v2_panel_data' was not declared. Should it be static?
>
> [...]
Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)
[1/1] drm/panel: khadas-ts050: make ts050[v2]_panel_data static
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/d5acba46ebf5a4fd9ea9ae5121dd381ce85e94ff
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-13 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-08 13:35 [PATCH] drm/panel: khadas-ts050: make ts050[v2]_panel_data static Min-Hua Chen
2024-09-09 13:09 ` Neil Armstrong
2024-09-13 9:18 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®