* [tip:sched/core 69/70] drivers/cpufreq/cppc_cpufreq.c:227:20: error: use of undeclared identifier 'NSER_PER_MSEC'
@ 2024-09-10 22:20 kernel test robot
2024-09-11 8:15 ` Christian Loehle
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2024-09-10 22:20 UTC (permalink / raw)
To: Christian Loehle; +Cc: oe-kbuild-all, linux-kernel, x86, Peter Zijlstra
Hi Christian,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
head: 6cbbb91711c6b17da3802a3cf072d3311828ca33
commit: b3a47ff095544af206b8885391a7bad662d06a57 [69/70] cpufreq/cppc: Use NSEC_PER_MSEC for deadline task
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20240911/202409110611.dmyDCkoe-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project bf684034844c660b778f0eba103582f582b710c9)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240911/202409110611.dmyDCkoe-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409110611.dmyDCkoe-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/cpufreq/cppc_cpufreq.c:227:20: error: use of undeclared identifier 'NSER_PER_MSEC'
227 | .sched_runtime = NSER_PER_MSEC,
| ^
>> drivers/cpufreq/cppc_cpufreq.c:229:3: error: member reference base type 'long' is not a structure or union
228 | .sched_deadline = 10 * NSEC_PER_MSEC
| ~~~~~~~~~~~~~
229 | .sched_period = 10 * NSEC_PER_MSEC,
| ^~~~~~~~~~~~~
2 errors generated.
vim +/NSER_PER_MSEC +227 drivers/cpufreq/cppc_cpufreq.c
215
216 static void __init cppc_freq_invariance_init(void)
217 {
218 struct sched_attr attr = {
219 .size = sizeof(struct sched_attr),
220 .sched_policy = SCHED_DEADLINE,
221 .sched_nice = 0,
222 .sched_priority = 0,
223 /*
224 * Fake (unused) bandwidth; workaround to "fix"
225 * priority inheritance.
226 */
> 227 .sched_runtime = NSER_PER_MSEC,
228 .sched_deadline = 10 * NSEC_PER_MSEC
> 229 .sched_period = 10 * NSEC_PER_MSEC,
230 };
231 int ret;
232
233 if (fie_disabled != FIE_ENABLED && fie_disabled != FIE_DISABLED) {
234 fie_disabled = FIE_ENABLED;
235 if (cppc_perf_ctrs_in_pcc()) {
236 pr_info("FIE not enabled on systems with registers in PCC\n");
237 fie_disabled = FIE_DISABLED;
238 }
239 }
240
241 if (fie_disabled)
242 return;
243
244 kworker_fie = kthread_create_worker(0, "cppc_fie");
245 if (IS_ERR(kworker_fie)) {
246 pr_warn("%s: failed to create kworker_fie: %ld\n", __func__,
247 PTR_ERR(kworker_fie));
248 fie_disabled = FIE_DISABLED;
249 return;
250 }
251
252 ret = sched_setattr_nocheck(kworker_fie->task, &attr);
253 if (ret) {
254 pr_warn("%s: failed to set SCHED_DEADLINE: %d\n", __func__,
255 ret);
256 kthread_destroy_worker(kworker_fie);
257 fie_disabled = FIE_DISABLED;
258 }
259 }
260
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [tip:sched/core 69/70] drivers/cpufreq/cppc_cpufreq.c:227:20: error: use of undeclared identifier 'NSER_PER_MSEC'
2024-09-10 22:20 [tip:sched/core 69/70] drivers/cpufreq/cppc_cpufreq.c:227:20: error: use of undeclared identifier 'NSER_PER_MSEC' kernel test robot
@ 2024-09-11 8:15 ` Christian Loehle
2024-09-11 9:14 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Christian Loehle @ 2024-09-11 8:15 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, linux-kernel, x86, Peter Zijlstra
On 9/10/24 23:20, kernel test robot wrote:
> Hi Christian,
>
> FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
> head: 6cbbb91711c6b17da3802a3cf072d3311828ca33
> commit: b3a47ff095544af206b8885391a7bad662d06a57 [69/70] cpufreq/cppc: Use NSEC_PER_MSEC for deadline task
> config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20240911/202409110611.dmyDCkoe-lkp@intel.com/config)
> compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project bf684034844c660b778f0eba103582f582b710c9)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240911/202409110611.dmyDCkoe-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202409110611.dmyDCkoe-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>>> drivers/cpufreq/cppc_cpufreq.c:227:20: error: use of undeclared identifier 'NSER_PER_MSEC'
> 227 | .sched_runtime = NSER_PER_MSEC,
> | ^
>>> drivers/cpufreq/cppc_cpufreq.c:229:3: error: member reference base type 'long' is not a structure or union
> 228 | .sched_deadline = 10 * NSEC_PER_MSEC
> | ~~~~~~~~~~~~~
> 229 | .sched_period = 10 * NSEC_PER_MSEC,
> | ^~~~~~~~~~~~~
> 2 errors generated.
>
>
> vim +/NSER_PER_MSEC +227 drivers/cpufreq/cppc_cpufreq.c
>
> 215
> 216 static void __init cppc_freq_invariance_init(void)
> 217 {
> 218 struct sched_attr attr = {
> 219 .size = sizeof(struct sched_attr),
> 220 .sched_policy = SCHED_DEADLINE,
> 221 .sched_nice = 0,
> 222 .sched_priority = 0,
> 223 /*
> 224 * Fake (unused) bandwidth; workaround to "fix"
> 225 * priority inheritance.
> 226 */
> > 227 .sched_runtime = NSER_PER_MSEC,
Sorry, seems I enabled the module, but didn't actually build modules
before sending it out, anyway this should be s/NSER/NSEC
> 228 .sched_deadline = 10 * NSEC_PER_MSEC
and this is missing a comma.
Peter do you mind fixing that up for me?
-->8--
diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
index aff25b598ec4..1a5ad184d28f 100644
--- a/drivers/cpufreq/cppc_cpufreq.c
+++ b/drivers/cpufreq/cppc_cpufreq.c
@@ -224,8 +224,8 @@ static void __init cppc_freq_invariance_init(void)
* Fake (unused) bandwidth; workaround to "fix"
* priority inheritance.
*/
- .sched_runtime = NSER_PER_MSEC,
- .sched_deadline = 10 * NSEC_PER_MSEC
+ .sched_runtime = NSEC_PER_MSEC,
+ .sched_deadline = 10 * NSEC_PER_MSEC,
.sched_period = 10 * NSEC_PER_MSEC,
};
int ret;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [tip:sched/core 69/70] drivers/cpufreq/cppc_cpufreq.c:227:20: error: use of undeclared identifier 'NSER_PER_MSEC'
2024-09-11 8:15 ` Christian Loehle
@ 2024-09-11 9:14 ` Peter Zijlstra
0 siblings, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2024-09-11 9:14 UTC (permalink / raw)
To: Christian Loehle; +Cc: kernel test robot, oe-kbuild-all, linux-kernel, x86
On Wed, Sep 11, 2024 at 09:15:24AM +0100, Christian Loehle wrote:
> On 9/10/24 23:20, kernel test robot wrote:
> > Hi Christian,
> >
> > FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
> > head: 6cbbb91711c6b17da3802a3cf072d3311828ca33
> > commit: b3a47ff095544af206b8885391a7bad662d06a57 [69/70] cpufreq/cppc: Use NSEC_PER_MSEC for deadline task
> > config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20240911/202409110611.dmyDCkoe-lkp@intel.com/config)
> > compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project bf684034844c660b778f0eba103582f582b710c9)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240911/202409110611.dmyDCkoe-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202409110611.dmyDCkoe-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> >>> drivers/cpufreq/cppc_cpufreq.c:227:20: error: use of undeclared identifier 'NSER_PER_MSEC'
> > 227 | .sched_runtime = NSER_PER_MSEC,
> > | ^
> >>> drivers/cpufreq/cppc_cpufreq.c:229:3: error: member reference base type 'long' is not a structure or union
> > 228 | .sched_deadline = 10 * NSEC_PER_MSEC
> > | ~~~~~~~~~~~~~
> > 229 | .sched_period = 10 * NSEC_PER_MSEC,
> > | ^~~~~~~~~~~~~
> > 2 errors generated.
> >
> >
> > vim +/NSER_PER_MSEC +227 drivers/cpufreq/cppc_cpufreq.c
> >
> > 215
> > 216 static void __init cppc_freq_invariance_init(void)
> > 217 {
> > 218 struct sched_attr attr = {
> > 219 .size = sizeof(struct sched_attr),
> > 220 .sched_policy = SCHED_DEADLINE,
> > 221 .sched_nice = 0,
> > 222 .sched_priority = 0,
> > 223 /*
> > 224 * Fake (unused) bandwidth; workaround to "fix"
> > 225 * priority inheritance.
> > 226 */
> > > 227 .sched_runtime = NSER_PER_MSEC,
>
> Sorry, seems I enabled the module, but didn't actually build modules
> before sending it out, anyway this should be s/NSER/NSEC
>
> > 228 .sched_deadline = 10 * NSEC_PER_MSEC
> and this is missing a comma.
> Peter do you mind fixing that up for me?
I'll fix it up. I need to rebase sched/core anyway.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-11 9:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-10 22:20 [tip:sched/core 69/70] drivers/cpufreq/cppc_cpufreq.c:227:20: error: use of undeclared identifier 'NSER_PER_MSEC' kernel test robot
2024-09-11 8:15 ` Christian Loehle
2024-09-11 9:14 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®