* [PATCH][next] accel/habanalabs/gaudi2: Make read-only array edma_queues_id static const
@ 2024-09-12 13:30 Colin Ian King
0 siblings, 0 replies; only message in thread
From: Colin Ian King @ 2024-09-12 13:30 UTC (permalink / raw)
To: Ofir Bitton, Oded Gabbay, dri-devel; +Cc: kernel-janitors, linux-kernel
Don't populate the read-only array edma_queues_id on the stack at
run time, instead make it static const.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/accel/habanalabs/gaudi2/gaudi2.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/accel/habanalabs/gaudi2/gaudi2.c b/drivers/accel/habanalabs/gaudi2/gaudi2.c
index a38b88baadf2..1e401f42eef7 100644
--- a/drivers/accel/habanalabs/gaudi2/gaudi2.c
+++ b/drivers/accel/habanalabs/gaudi2/gaudi2.c
@@ -10304,10 +10304,12 @@ static int gaudi2_memset_memory_chunk_using_edma_qm(struct hl_device *hdev,
static int gaudi2_memset_device_memory(struct hl_device *hdev, u64 addr, u64 size, u64 val)
{
- u32 edma_queues_id[] = {GAUDI2_QUEUE_ID_DCORE0_EDMA_0_0,
- GAUDI2_QUEUE_ID_DCORE1_EDMA_0_0,
- GAUDI2_QUEUE_ID_DCORE2_EDMA_0_0,
- GAUDI2_QUEUE_ID_DCORE3_EDMA_0_0};
+ static const u32 edma_queues_id[] = {
+ GAUDI2_QUEUE_ID_DCORE0_EDMA_0_0,
+ GAUDI2_QUEUE_ID_DCORE1_EDMA_0_0,
+ GAUDI2_QUEUE_ID_DCORE2_EDMA_0_0,
+ GAUDI2_QUEUE_ID_DCORE3_EDMA_0_0
+ };
u32 chunk_size, dcore, edma_idx, sob_offset, sob_addr, comp_val,
old_mmubp, mmubp, num_of_pkts, busy, pkt_size, cb_len;
u64 comp_addr, cur_addr = addr, end_addr = addr + size;
--
2.39.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-09-12 13:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-12 13:30 [PATCH][next] accel/habanalabs/gaudi2: Make read-only array edma_queues_id static const Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®