From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: x86@kernel.org, Andreas Herrmann <aherrmann@suse.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Chen Yu <yu.c.chen@intel.com>, Len Brown <len.brown@intel.com>,
Radu Rendec <rrendec@redhat.com>,
Pierre Gondois <Pierre.Gondois@arm.com>, Pu Wen <puwen@hygon.cn>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Will Deacon <will@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Nikolay Borisov <nik.borisov@suse.com>,
Huang Ying <ying.huang@intel.com>,
Ricardo Neri <ricardo.neri@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/4] cacheinfo: Allocate memory during CPU hotplug if not done from the primary CPU
Date: Thu, 12 Sep 2024 21:06:35 -0700 [thread overview]
Message-ID: <20240913040635.GA9167@ranerica-svr.sc.intel.com> (raw)
In-Reply-To: <20240912105918.GBZuLJhtVBHKK54KFD@fat_crate.local>
On Thu, Sep 12, 2024 at 12:59:18PM +0200, Borislav Petkov wrote:
> On Wed, Sep 11, 2024 at 04:34:10PM -0700, Ricardo Neri wrote:
> > Yes, both patches address issues during CPU hotplug (both NULL-pointer
> > dereference). However, IHMO, they are separate issues. Patch 1/4 fixes
> > a missing allocation check. Patch 2/4 causes the allocation to happen in
> > case early allocation is not used.
> >
> > If I did not convince you, I am happy to merge together patches 1 and 2.
>
> Well, what is easier to handle by stable and/or backporters: one patch or two
> patches fixing two very similar CPU hotplug isuses in cacheinfo?
Indeed, one patch would be easier to handle.
>
> IOW, what is the benefit in having two patches instead of one?
Marginal I guess. I can put all the background and rationale in the commit
message.
I will post a new version merging patches 1 and 2... and fixing the
formatting of allocate_cache_info().
next prev parent reply other threads:[~2024-09-13 4:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 6:00 [PATCH v6 0/4] x86/cacheinfo: Set the number of leaves per CPU Ricardo Neri
2024-09-05 6:00 ` [PATCH v6 1/4] cacheinfo: Check for null last-level cache info Ricardo Neri
2024-09-11 14:05 ` Borislav Petkov
2024-09-11 23:37 ` Ricardo Neri
2024-09-12 10:56 ` Borislav Petkov
2024-09-05 6:00 ` [PATCH v6 2/4] cacheinfo: Allocate memory during CPU hotplug if not done from the primary CPU Ricardo Neri
2024-09-11 14:08 ` Borislav Petkov
2024-09-11 23:34 ` Ricardo Neri
2024-09-12 10:59 ` Borislav Petkov
2024-09-13 4:06 ` Ricardo Neri [this message]
2024-09-05 6:00 ` [PATCH v6 3/4] x86/cacheinfo: Delete global num_cache_leaves Ricardo Neri
2024-09-05 6:00 ` [PATCH v6 4/4] x86/cacheinfo: Clean out init_cache_level() Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913040635.GA9167@ranerica-svr.sc.intel.com \
--to=ricardo.neri-calderon@linux.intel.com \
--cc=Pierre.Gondois@arm.com \
--cc=aherrmann@suse.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=puwen@hygon.cn \
--cc=rafael.j.wysocki@intel.com \
--cc=ricardo.neri@intel.com \
--cc=rrendec@redhat.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®