From: Abdul Rahim <abdul.rahim@myyahoo.com>
To: rafael@kernel.org, christophe.jaillet@wanadoo.fr,
rui.zhang@intel.com, lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Abdul Rahim <abdul.rahim@myyahoo.com>
Subject: [PATCH] ACPI: thermal: Use strscpy() instead of strcpy()
Date: Sat, 14 Sep 2024 00:42:49 +0530 [thread overview]
Message-ID: <20240913191249.51822-1-abdul.rahim@myyahoo.com> (raw)
In-Reply-To: <20240913191249.51822-1-abdul.rahim.ref@myyahoo.com>
strcpy() is generally considered unsafe and use of strscpy() is
recommended [1]
this fixes checkpatch warning:
WARNING: Prefer strscpy over strcpy
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com>
---
drivers/acpi/thermal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index 78db38c7076e..6671537cb4b7 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -796,9 +796,9 @@ static int acpi_thermal_add(struct acpi_device *device)
return -ENOMEM;
tz->device = device;
- strcpy(tz->name, device->pnp.bus_id);
- strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
- strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
+ strscpy(tz->name, device->pnp.bus_id);
+ strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
+ strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
device->driver_data = tz;
acpi_thermal_aml_dependency_fix(tz);
--
2.46.0
next parent reply other threads:[~2024-09-13 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240913191249.51822-1-abdul.rahim.ref@myyahoo.com>
2024-09-13 19:12 ` Abdul Rahim [this message]
2024-09-13 19:31 ` Christophe JAILLET
2024-09-13 21:23 ` Abdul Rahim
[not found] <20240912205922.302036-1-abdul.rahim.ref@myyahoo.com>
2024-09-12 20:59 ` Abdul Rahim
2024-09-13 15:17 ` Christophe JAILLET
2024-09-13 18:13 ` Abdul Rahim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913191249.51822-1-abdul.rahim@myyahoo.com \
--to=abdul.rahim@myyahoo.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®