* [PATCH] ACPI: thermal: Use strscpy() instead of strcpy() [not found] <20240913191249.51822-1-abdul.rahim.ref@myyahoo.com> @ 2024-09-13 19:12 ` Abdul Rahim 2024-09-13 19:31 ` Christophe JAILLET 0 siblings, 1 reply; 6+ messages in thread From: Abdul Rahim @ 2024-09-13 19:12 UTC (permalink / raw) To: rafael, christophe.jaillet, rui.zhang, lenb Cc: linux-acpi, linux-kernel, Abdul Rahim strcpy() is generally considered unsafe and use of strscpy() is recommended [1] this fixes checkpatch warning: WARNING: Prefer strscpy over strcpy Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> --- drivers/acpi/thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c index 78db38c7076e..6671537cb4b7 100644 --- a/drivers/acpi/thermal.c +++ b/drivers/acpi/thermal.c @@ -796,9 +796,9 @@ static int acpi_thermal_add(struct acpi_device *device) return -ENOMEM; tz->device = device; - strcpy(tz->name, device->pnp.bus_id); - strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME); - strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS); + strscpy(tz->name, device->pnp.bus_id); + strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME); + strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS); device->driver_data = tz; acpi_thermal_aml_dependency_fix(tz); -- 2.46.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: thermal: Use strscpy() instead of strcpy() 2024-09-13 19:12 ` [PATCH] ACPI: thermal: Use strscpy() instead of strcpy() Abdul Rahim @ 2024-09-13 19:31 ` Christophe JAILLET 2024-09-13 21:23 ` Abdul Rahim 0 siblings, 1 reply; 6+ messages in thread From: Christophe JAILLET @ 2024-09-13 19:31 UTC (permalink / raw) To: Abdul Rahim, rafael, rui.zhang, lenb; +Cc: linux-acpi, linux-kernel Le 13/09/2024 à 21:12, Abdul Rahim a écrit : > strcpy() is generally considered unsafe and use of strscpy() is > recommended [1] > > this fixes checkpatch warning: > WARNING: Prefer strscpy over strcpy > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] > Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> Hi, in order to ease the review process, when you send a new version of a patch, the subject line should state the version: (i.e.: [PATCH v2] ...) It is also a good practice to explain what has changed with the previous version. Finally, it is nice to provide the link on lore to the previous version. All this should added below the first ---. Here it could look like: > --- Changes in v2: - Remove an unneeded extra parameter (MAX_ACPI_DEVICE_NAME_LEN) in the 2nd strscpy() call v1: https://lore.kernel.org/all/20240912205922.302036-1-abdul.rahim@myyahoo.com/ CJ > drivers/acpi/thermal.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c > index 78db38c7076e..6671537cb4b7 100644 > --- a/drivers/acpi/thermal.c > +++ b/drivers/acpi/thermal.c > @@ -796,9 +796,9 @@ static int acpi_thermal_add(struct acpi_device *device) > return -ENOMEM; > > tz->device = device; > - strcpy(tz->name, device->pnp.bus_id); > - strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME); > - strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS); > + strscpy(tz->name, device->pnp.bus_id); > + strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME); > + strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS); > device->driver_data = tz; > > acpi_thermal_aml_dependency_fix(tz); ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: thermal: Use strscpy() instead of strcpy() 2024-09-13 19:31 ` Christophe JAILLET @ 2024-09-13 21:23 ` Abdul Rahim 0 siblings, 0 replies; 6+ messages in thread From: Abdul Rahim @ 2024-09-13 21:23 UTC (permalink / raw) To: Christophe JAILLET; +Cc: rafael, rui.zhang, lenb, linux-acpi, linux-kernel On Fri, Sep 13, 2024 at 09:31:57PM GMT, Christophe JAILLET wrote: > Le 13/09/2024 � 21:12, Abdul Rahim a �crit�: > > strcpy() is generally considered unsafe and use of strscpy() is > > recommended [1] > > > > this fixes checkpatch warning: > > WARNING: Prefer strscpy over strcpy > > > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] > > Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> > > Hi, > > in order to ease the review process, when you send a new version of a patch, > the subject line should state the version: (i.e.: [PATCH v2] ...) > > > It is also a good practice to explain what has changed with the previous > version. > Finally, it is nice to provide the link on lore to the previous version. > All this should added below the first ---. > Here it could look like: > > > --- > > Changes in v2: > - Remove an unneeded extra parameter (MAX_ACPI_DEVICE_NAME_LEN) in the 2nd > strscpy() call > > v1: > https://lore.kernel.org/all/20240912205922.302036-1-abdul.rahim@myyahoo.com/ > > CJ > > > drivers/acpi/thermal.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c > > index 78db38c7076e..6671537cb4b7 100644 > > --- a/drivers/acpi/thermal.c > > +++ b/drivers/acpi/thermal.c > > @@ -796,9 +796,9 @@ static int acpi_thermal_add(struct acpi_device *device) > > return -ENOMEM; > > tz->device = device; > > - strcpy(tz->name, device->pnp.bus_id); > > - strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME); > > - strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS); > > + strscpy(tz->name, device->pnp.bus_id); > > + strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME); > > + strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS); > > device->driver_data = tz; > > acpi_thermal_aml_dependency_fix(tz); > > Thanks CJ, https://lore.kernel.org/all/20240913211156.103864-1-abdul.rahim@myyahoo.com/ ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20240912205922.302036-1-abdul.rahim.ref@myyahoo.com>]
* [PATCH] ACPI: thermal: Use strscpy() instead of strcpy() [not found] <20240912205922.302036-1-abdul.rahim.ref@myyahoo.com> @ 2024-09-12 20:59 ` Abdul Rahim 2024-09-13 15:17 ` Christophe JAILLET 0 siblings, 1 reply; 6+ messages in thread From: Abdul Rahim @ 2024-09-12 20:59 UTC (permalink / raw) To: rafael, lenb; +Cc: linux-acpi, linux-kernel, Abdul Rahim thermal: prefer strscpy() over strcpy() strcpy() is generally considered unsafe and use of strscpy() is recommended [1] this fixes checkpatch warning: WARNING: Prefer strscpy over strcpy Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> --- drivers/acpi/thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c index 78db38c7076e..a35e40976763 100644 --- a/drivers/acpi/thermal.c +++ b/drivers/acpi/thermal.c @@ -796,9 +796,9 @@ static int acpi_thermal_add(struct acpi_device *device) return -ENOMEM; tz->device = device; - strcpy(tz->name, device->pnp.bus_id); - strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME); - strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS); + strscpy(tz->name, device->pnp.bus_id); + strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME, MAX_ACPI_DEVICE_NAME_LEN); + strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS); device->driver_data = tz; acpi_thermal_aml_dependency_fix(tz); -- 2.43.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: thermal: Use strscpy() instead of strcpy() 2024-09-12 20:59 ` Abdul Rahim @ 2024-09-13 15:17 ` Christophe JAILLET 2024-09-13 18:13 ` Abdul Rahim 0 siblings, 1 reply; 6+ messages in thread From: Christophe JAILLET @ 2024-09-13 15:17 UTC (permalink / raw) To: Abdul Rahim, rafael, lenb; +Cc: linux-acpi, linux-kernel Le 12/09/2024 à 22:59, Abdul Rahim a écrit : > thermal: prefer strscpy() over strcpy() > > strcpy() is generally considered unsafe and use of strscpy() is > recommended [1] > > this fixes checkpatch warning: > WARNING: Prefer strscpy over strcpy > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] > Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> > --- > drivers/acpi/thermal.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c > index 78db38c7076e..a35e40976763 100644 > --- a/drivers/acpi/thermal.c > +++ b/drivers/acpi/thermal.c > @@ -796,9 +796,9 @@ static int acpi_thermal_add(struct acpi_device *device) > return -ENOMEM; > > tz->device = device; > - strcpy(tz->name, device->pnp.bus_id); > - strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME); > - strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS); > + strscpy(tz->name, device->pnp.bus_id); > + strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME, MAX_ACPI_DEVICE_NAME_LEN); Why the 3 parameters version here only? Is it needed? CJ > + strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS); > device->driver_data = tz; > > acpi_thermal_aml_dependency_fix(tz); ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: thermal: Use strscpy() instead of strcpy() 2024-09-13 15:17 ` Christophe JAILLET @ 2024-09-13 18:13 ` Abdul Rahim 0 siblings, 0 replies; 6+ messages in thread From: Abdul Rahim @ 2024-09-13 18:13 UTC (permalink / raw) To: christophe.jaillet, rafael, lenb; +Cc: linux-acpi, linux-kernel On Fri, Sep 13, 2024 at 05:17:58PM GMT, Christophe JAILLET wrote: > Le 12/09/2024 � 22:59, Abdul Rahim a �crit�: > > thermal: prefer strscpy() over strcpy() > > > > strcpy() is generally considered unsafe and use of strscpy() is > > recommended [1] > > > > this fixes checkpatch warning: > > WARNING: Prefer strscpy over strcpy > > > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] > > Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com> > > --- > > drivers/acpi/thermal.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c > > index 78db38c7076e..a35e40976763 100644 > > --- a/drivers/acpi/thermal.c > > +++ b/drivers/acpi/thermal.c > > @@ -796,9 +796,9 @@ static int acpi_thermal_add(struct acpi_device *device) > > return -ENOMEM; > > tz->device = device; > > - strcpy(tz->name, device->pnp.bus_id); > > - strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME); > > - strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS); > > + strscpy(tz->name, device->pnp.bus_id); > > + strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME, MAX_ACPI_DEVICE_NAME_LEN); > > Why the 3 parameters version here only? > Is it needed? > > CJ > > > + strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS); > > device->driver_data = tz; > > acpi_thermal_aml_dependency_fix(tz); You are correct, it's actually not needed. "The size argument ... is only required when dst is not an array" [1] And destination buffers here are actually arrays from `include/acpi/acpi_bus.h` ``` typedef char acpi_bus_id[8]; ... typedef char acpi_device_name[40]; typedef char acpi_device_class[20]; ``` https://docs.kernel.org/core-api/kernel-api.html#c.strscpy [1] I will resend this patch, with the parameter removed. Thanks, Abdul Rahim ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-09-13 21:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240913191249.51822-1-abdul.rahim.ref@myyahoo.com>
2024-09-13 19:12 ` [PATCH] ACPI: thermal: Use strscpy() instead of strcpy() Abdul Rahim
2024-09-13 19:31 ` Christophe JAILLET
2024-09-13 21:23 ` Abdul Rahim
[not found] <20240912205922.302036-1-abdul.rahim.ref@myyahoo.com>
2024-09-12 20:59 ` Abdul Rahim
2024-09-13 15:17 ` Christophe JAILLET
2024-09-13 18:13 ` Abdul Rahim
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®