* [PATCH -next v2] drm/msm: Remove unneeded semicolon
@ 2024-09-18 2:33 Yang Li
2024-09-20 16:21 ` Dmitry Baryshkov
2024-10-21 12:17 ` Dmitry Baryshkov
0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2024-09-18 2:33 UTC (permalink / raw)
To: quic_abhinavk, robdclark, dmitry.baryshkov, airlied
Cc: dri-devel, freedreno, linux-kernel, Yang Li, Abaci Robot
./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon
This patch removes an unneeded semicolon after a switch statement in the
pll_get_post_div function. Adding a semicolon after a switch statement is
unnecessary and can lead to confusion in the code structure.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9852
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
index 0e3a2b16a2ce..65cf237c6b4e 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
@@ -279,7 +279,7 @@ static int pll_get_post_div(struct hdmi_8998_post_divider *pd, u64 bclk)
case 25:
found_hsclk_divsel = 14;
break;
- };
+ }
pd->vco_freq = found_vco_freq;
pd->tx_band_sel = found_tx_band_sel;
--
2.32.0.3.g01195cf9f
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next v2] drm/msm: Remove unneeded semicolon
2024-09-18 2:33 [PATCH -next v2] drm/msm: Remove unneeded semicolon Yang Li
@ 2024-09-20 16:21 ` Dmitry Baryshkov
2024-10-21 12:17 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2024-09-20 16:21 UTC (permalink / raw)
To: Yang Li
Cc: quic_abhinavk, robdclark, airlied, dri-devel, freedreno,
linux-kernel, Abaci Robot
On Wed, Sep 18, 2024 at 10:33:57AM GMT, Yang Li wrote:
> ./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon
>
> This patch removes an unneeded semicolon after a switch statement in the
> pll_get_post_div function. Adding a semicolon after a switch statement is
> unnecessary and can lead to confusion in the code structure.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9852
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next v2] drm/msm: Remove unneeded semicolon
2024-09-18 2:33 [PATCH -next v2] drm/msm: Remove unneeded semicolon Yang Li
2024-09-20 16:21 ` Dmitry Baryshkov
@ 2024-10-21 12:17 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2024-10-21 12:17 UTC (permalink / raw)
To: quic_abhinavk, robdclark, airlied, Yang Li
Cc: dri-devel, freedreno, linux-kernel, Abaci Robot
On Wed, 18 Sep 2024 10:33:57 +0800, Yang Li wrote:
> ./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon
>
> This patch removes an unneeded semicolon after a switch statement in the
> pll_get_post_div function. Adding a semicolon after a switch statement is
> unnecessary and can lead to confusion in the code structure.
>
>
> [...]
Applied, thanks!
[1/1] drm/msm: Remove unneeded semicolon
https://gitlab.freedesktop.org/lumag/msm/-/commit/00adf52efec3
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-21 12:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-18 2:33 [PATCH -next v2] drm/msm: Remove unneeded semicolon Yang Li
2024-09-20 16:21 ` Dmitry Baryshkov
2024-10-21 12:17 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®