* [PATCH] Staging: net/ethernet/broadcom: Add error pointer check in bcmsysport.c
@ 2024-09-22 18:17 Dipendra Khadka
2024-09-22 20:08 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Dipendra Khadka @ 2024-09-22 18:17 UTC (permalink / raw)
To: florian.fainelli, bcm-kernel-feedback-list, davem, edumazet,
kuba, pabeni
Cc: Dipendra Khadka, netdev, linux-kernel
Smatch reported following:
'''
drivers/net/ethernet/broadcom/bcmsysport.c:2343 bcm_sysport_map_queues() error: 'dp' dereferencing possible ERR_PTR()
drivers/net/ethernet/broadcom/bcmsysport.c:2395 bcm_sysport_unmap_queues() error: 'dp' dereferencing possible ERR_PTR()
'''
Adding error pointer check before dereferencing 'dp'.
Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
---
drivers/net/ethernet/broadcom/bcmsysport.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index c9faa8540859..b849c11e2bb6 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -2337,6 +2337,9 @@ static int bcm_sysport_map_queues(struct net_device *dev,
unsigned int num_tx_queues;
unsigned int q, qp, port;
+ if (IS_ERR(dp))
+ return PTR_ERR(dp);
+
/* We can't be setting up queue inspection for non directly attached
* switches
*/
@@ -2392,6 +2395,9 @@ static int bcm_sysport_unmap_queues(struct net_device *dev,
unsigned int num_tx_queues;
unsigned int q, qp, port;
+ if (IS_ERR(dp))
+ return PTR_ERR(dp);
+
port = dp->index;
num_tx_queues = slave_dev->real_num_tx_queues;
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: net/ethernet/broadcom: Add error pointer check in bcmsysport.c
2024-09-22 18:17 [PATCH] Staging: net/ethernet/broadcom: Add error pointer check in bcmsysport.c Dipendra Khadka
@ 2024-09-22 20:08 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2024-09-22 20:08 UTC (permalink / raw)
To: Dipendra Khadka
Cc: florian.fainelli, bcm-kernel-feedback-list, davem, edumazet,
kuba, pabeni, netdev, linux-kernel
On Sun, Sep 22, 2024 at 06:17:37PM +0000, Dipendra Khadka wrote:
> Smatch reported following:
> '''
> drivers/net/ethernet/broadcom/bcmsysport.c:2343 bcm_sysport_map_queues() error: 'dp' dereferencing possible ERR_PTR()
> drivers/net/ethernet/broadcom/bcmsysport.c:2395 bcm_sysport_unmap_queues() error: 'dp' dereferencing possible ERR_PTR()
> '''
>
> Adding error pointer check before dereferencing 'dp'.
This driver is not in staging, so your subject is wrong.
Please take a look at:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Andrew
---
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-22 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-22 18:17 [PATCH] Staging: net/ethernet/broadcom: Add error pointer check in bcmsysport.c Dipendra Khadka
2024-09-22 20:08 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®