[PATCH v1 1/1] xhci: Don't use "proxy" headers

[PATCH v1 1/1] xhci: Don't use "proxy" headers

[Andy Shevchenko]

Update header inclusions to follow IWYU (Include What You Use)
principle.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/usb/host/xhci.h       | 22 +++++++++++++++++++---
 include/linux/usb/xhci-dbgp.h |  3 +++
 2 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index 620502de971a..b617de4d4c76 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -12,15 +12,31 @@
 #ifndef __LINUX_XHCI_HCD_H
 #define __LINUX_XHCI_HCD_H
 
+#include <linux/bitops.h>
+#include <linux/completion.h>
+#include <linux/dev_printk.h>
+#include <linux/irqreturn.h>
+#include <linux/mutex.h>
+#include <linux/pm.h>
+#include <linux/spinlock.h>
+#include <linux/sprintf.h>
+#include <linux/timer_types.h>
+#include <linux/types.h>
 #include <linux/usb.h>
-#include <linux/timer.h>
-#include <linux/kernel.h>
 #include <linux/usb/hcd.h>
+#include <linux/workqueue.h>
+
 #include <linux/io-64-nonatomic-lo-hi.h>
 #include <linux/io-64-nonatomic-hi-lo.h>
 
+struct clk;
+struct dentry;
+struct dma_pool;
+struct radix_tree_root;
+struct reset_control;
+
 /* Code sharing between pci-quirks and xhci hcd */
-#include	"xhci-ext-caps.h"
+#include "xhci-ext-caps.h"
 #include "pci-quirks.h"
 
 #include "xhci-port.h"
diff --git a/include/linux/usb/xhci-dbgp.h b/include/linux/usb/xhci-dbgp.h
index 171fd74b1cfc..880d1421df4b 100644
--- a/include/linux/usb/xhci-dbgp.h
+++ b/include/linux/usb/xhci-dbgp.h
@@ -10,6 +10,9 @@
 #ifndef __LINUX_XHCI_DBGP_H
 #define __LINUX_XHCI_DBGP_H
 
+#include <linux/errno.h>
+#include <linux/init.h>
+
 #ifdef CONFIG_EARLY_PRINTK_USB_XDBC
 int __init early_xdbc_parse_parameter(char *s, int keep_early);
 int __init early_xdbc_setup_hardware(void);
-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v1 1/1] xhci: Don't use "proxy" headers

[Andy Shevchenko]

On Mon, Sep 23, 2024 at 06:31:31PM +0300, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.

Mathias, any comments on this change?

-- 
With Best Regards,
Andy Shevchenko