* [PATCH 1/4] soundwire: amd: pass acp pci revision id as resource data
2024-09-24 8:18 [PATCH 0/4] refactor amd soundwire manager driver for acp 6.3 platform Vijendar Mukunda
@ 2024-09-24 8:18 ` Vijendar Mukunda
2024-09-24 8:18 ` [PATCH 2/4] soundwire: amd: refactor existing code for acp 6.3 platform Vijendar Mukunda
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Vijendar Mukunda @ 2024-09-24 8:18 UTC (permalink / raw)
To: broonie, vkoul
Cc: alsa-devel, pierre-louis.bossart, yung-chuan.liao, lgirdwood,
perex, tiwai, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
venkataprasad.potturu, linux-sound, linux-kernel,
Vijendar Mukunda
Pass ACP pci revision id as resource data and store it in amd SoundWire
manager private data structure. This field will be used to differentiate
ACP variants.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
drivers/soundwire/amd_init.c | 1 +
drivers/soundwire/amd_manager.c | 1 +
include/linux/soundwire/sdw_amd.h | 5 +++++
3 files changed, 7 insertions(+)
diff --git a/drivers/soundwire/amd_init.c b/drivers/soundwire/amd_init.c
index db040f435059..4f6e356e6bd2 100644
--- a/drivers/soundwire/amd_init.c
+++ b/drivers/soundwire/amd_init.c
@@ -121,6 +121,7 @@ static struct sdw_amd_ctx *sdw_amd_probe_controller(struct sdw_amd_res *res)
sdw_pdata[index].instance = index;
sdw_pdata[index].acp_sdw_lock = res->acp_lock;
+ sdw_pdata[index].acp_rev = res->acp_rev;
pdevinfo[index].name = "amd_sdw_manager";
pdevinfo[index].id = index;
pdevinfo[index].parent = res->parent;
diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
index 0d01849c3586..4a1966fb01f6 100644
--- a/drivers/soundwire/amd_manager.c
+++ b/drivers/soundwire/amd_manager.c
@@ -910,6 +910,7 @@ static int amd_sdw_manager_probe(struct platform_device *pdev)
amd_manager->mmio = amd_manager->acp_mmio +
(amd_manager->instance * SDW_MANAGER_REG_OFFSET);
amd_manager->acp_sdw_lock = pdata->acp_sdw_lock;
+ amd_manager->acp_rev = pdata->acp_rev;
amd_manager->cols_index = sdw_find_col_index(AMD_SDW_DEFAULT_COLUMNS);
amd_manager->rows_index = sdw_find_row_index(AMD_SDW_DEFAULT_ROWS);
amd_manager->dev = dev;
diff --git a/include/linux/soundwire/sdw_amd.h b/include/linux/soundwire/sdw_amd.h
index 28a4eb77717f..e0abc59d4748 100644
--- a/include/linux/soundwire/sdw_amd.h
+++ b/include/linux/soundwire/sdw_amd.h
@@ -30,6 +30,7 @@
struct acp_sdw_pdata {
u16 instance;
+ u32 acp_rev;
/* mutex to protect acp common register access */
struct mutex *acp_sdw_lock;
};
@@ -66,6 +67,7 @@ struct sdw_amd_dai_runtime {
* @instance: SoundWire manager instance
* @quirks: SoundWire manager quirks
* @wake_en_mask: wake enable mask per SoundWire manager
+ * @acp_rev: acp pci device revision id
* @clk_stopped: flag set to true when clock is stopped
* @power_mode_mask: flag interprets amd SoundWire manager power mode
* @dai_runtime_array: dai runtime array
@@ -94,6 +96,7 @@ struct amd_sdw_manager {
u32 quirks;
u32 wake_en_mask;
u32 power_mode_mask;
+ u32 acp_rev;
bool clk_stopped;
struct sdw_amd_dai_runtime **dai_runtime_array;
@@ -134,6 +137,7 @@ struct sdw_amd_ctx {
* struct sdw_amd_res - Soundwire AMD global resource structure,
* typically populated by the DSP driver/Legacy driver
*
+ * @acp_rev: acp pci device revision id
* @addr: acp pci device resource start address
* @reg_range: ACP register range
* @link_mask: bit-wise mask listing links selected by the DSP driver/
@@ -146,6 +150,7 @@ struct sdw_amd_ctx {
* @acp_lock: mutex protecting acp common registers access
*/
struct sdw_amd_res {
+ u32 acp_rev;
u32 addr;
u32 reg_range;
u32 link_mask;
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 2/4] soundwire: amd: refactor existing code for acp 6.3 platform
2024-09-24 8:18 [PATCH 0/4] refactor amd soundwire manager driver for acp 6.3 platform Vijendar Mukunda
2024-09-24 8:18 ` [PATCH 1/4] soundwire: amd: pass acp pci revision id as resource data Vijendar Mukunda
@ 2024-09-24 8:18 ` Vijendar Mukunda
2024-09-24 8:18 ` [PATCH 3/4] ASoC: SOF: amd: pass acp_rev as soundwire resource data Vijendar Mukunda
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Vijendar Mukunda @ 2024-09-24 8:18 UTC (permalink / raw)
To: broonie, vkoul
Cc: alsa-devel, pierre-louis.bossart, yung-chuan.liao, lgirdwood,
perex, tiwai, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
venkataprasad.potturu, linux-sound, linux-kernel,
Vijendar Mukunda
Refactor existing code by adding acp pci revision id coditional checks
for ACP 6.3 platform. Rename the macros and structure names with ACP63
tag.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
drivers/soundwire/amd_manager.c | 98 ++++++++++++++++++++-----------
drivers/soundwire/amd_manager.h | 16 ++---
include/linux/soundwire/sdw_amd.h | 1 +
3 files changed, 72 insertions(+), 43 deletions(-)
diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
index 4a1966fb01f6..5a4bfaef65fb 100644
--- a/drivers/soundwire/amd_manager.c
+++ b/drivers/soundwire/amd_manager.c
@@ -433,12 +433,18 @@ static int amd_sdw_port_params(struct sdw_bus *bus, struct sdw_port_params *p_pa
u32 frame_fmt_reg, dpn_frame_fmt;
dev_dbg(amd_manager->dev, "p_params->num:0x%x\n", p_params->num);
- switch (amd_manager->instance) {
- case ACP_SDW0:
- frame_fmt_reg = sdw0_manager_dp_reg[p_params->num].frame_fmt_reg;
- break;
- case ACP_SDW1:
- frame_fmt_reg = sdw1_manager_dp_reg[p_params->num].frame_fmt_reg;
+ switch (amd_manager->acp_rev) {
+ case ACP63_PCI_REV_ID:
+ switch (amd_manager->instance) {
+ case ACP_SDW0:
+ frame_fmt_reg = acp63_sdw0_dp_reg[p_params->num].frame_fmt_reg;
+ break;
+ case ACP_SDW1:
+ frame_fmt_reg = acp63_sdw1_dp_reg[p_params->num].frame_fmt_reg;
+ break;
+ default:
+ return -EINVAL;
+ }
break;
default:
return -EINVAL;
@@ -465,20 +471,28 @@ static int amd_sdw_transport_params(struct sdw_bus *bus,
u32 frame_fmt_reg, sample_int_reg, hctrl_dp0_reg;
u32 offset_reg, lane_ctrl_ch_en_reg;
- switch (amd_manager->instance) {
- case ACP_SDW0:
- frame_fmt_reg = sdw0_manager_dp_reg[params->port_num].frame_fmt_reg;
- sample_int_reg = sdw0_manager_dp_reg[params->port_num].sample_int_reg;
- hctrl_dp0_reg = sdw0_manager_dp_reg[params->port_num].hctrl_dp0_reg;
- offset_reg = sdw0_manager_dp_reg[params->port_num].offset_reg;
- lane_ctrl_ch_en_reg = sdw0_manager_dp_reg[params->port_num].lane_ctrl_ch_en_reg;
- break;
- case ACP_SDW1:
- frame_fmt_reg = sdw1_manager_dp_reg[params->port_num].frame_fmt_reg;
- sample_int_reg = sdw1_manager_dp_reg[params->port_num].sample_int_reg;
- hctrl_dp0_reg = sdw1_manager_dp_reg[params->port_num].hctrl_dp0_reg;
- offset_reg = sdw1_manager_dp_reg[params->port_num].offset_reg;
- lane_ctrl_ch_en_reg = sdw1_manager_dp_reg[params->port_num].lane_ctrl_ch_en_reg;
+ switch (amd_manager->acp_rev) {
+ case ACP63_PCI_REV_ID:
+ switch (amd_manager->instance) {
+ case ACP_SDW0:
+ frame_fmt_reg = acp63_sdw0_dp_reg[params->port_num].frame_fmt_reg;
+ sample_int_reg = acp63_sdw0_dp_reg[params->port_num].sample_int_reg;
+ hctrl_dp0_reg = acp63_sdw0_dp_reg[params->port_num].hctrl_dp0_reg;
+ offset_reg = acp63_sdw0_dp_reg[params->port_num].offset_reg;
+ lane_ctrl_ch_en_reg =
+ acp63_sdw0_dp_reg[params->port_num].lane_ctrl_ch_en_reg;
+ break;
+ case ACP_SDW1:
+ frame_fmt_reg = acp63_sdw1_dp_reg[params->port_num].frame_fmt_reg;
+ sample_int_reg = acp63_sdw1_dp_reg[params->port_num].sample_int_reg;
+ hctrl_dp0_reg = acp63_sdw1_dp_reg[params->port_num].hctrl_dp0_reg;
+ offset_reg = acp63_sdw1_dp_reg[params->port_num].offset_reg;
+ lane_ctrl_ch_en_reg =
+ acp63_sdw1_dp_reg[params->port_num].lane_ctrl_ch_en_reg;
+ break;
+ default:
+ return -EINVAL;
+ }
break;
default:
return -EINVAL;
@@ -520,12 +534,20 @@ static int amd_sdw_port_enable(struct sdw_bus *bus,
u32 dpn_ch_enable;
u32 lane_ctrl_ch_en_reg;
- switch (amd_manager->instance) {
- case ACP_SDW0:
- lane_ctrl_ch_en_reg = sdw0_manager_dp_reg[enable_ch->port_num].lane_ctrl_ch_en_reg;
- break;
- case ACP_SDW1:
- lane_ctrl_ch_en_reg = sdw1_manager_dp_reg[enable_ch->port_num].lane_ctrl_ch_en_reg;
+ switch (amd_manager->acp_rev) {
+ case ACP63_PCI_REV_ID:
+ switch (amd_manager->instance) {
+ case ACP_SDW0:
+ lane_ctrl_ch_en_reg =
+ acp63_sdw0_dp_reg[enable_ch->port_num].lane_ctrl_ch_en_reg;
+ break;
+ case ACP_SDW1:
+ lane_ctrl_ch_en_reg =
+ acp63_sdw1_dp_reg[enable_ch->port_num].lane_ctrl_ch_en_reg;
+ break;
+ default:
+ return -EINVAL;
+ }
break;
default:
return -EINVAL;
@@ -927,15 +949,21 @@ static int amd_sdw_manager_probe(struct platform_device *pdev)
* information.
*/
amd_manager->bus.controller_id = 0;
-
- switch (amd_manager->instance) {
- case ACP_SDW0:
- amd_manager->num_dout_ports = AMD_SDW0_MAX_TX_PORTS;
- amd_manager->num_din_ports = AMD_SDW0_MAX_RX_PORTS;
- break;
- case ACP_SDW1:
- amd_manager->num_dout_ports = AMD_SDW1_MAX_TX_PORTS;
- amd_manager->num_din_ports = AMD_SDW1_MAX_RX_PORTS;
+ dev_dbg(dev, "acp_rev:0x%x\n", amd_manager->acp_rev);
+ switch (amd_manager->acp_rev) {
+ case ACP63_PCI_REV_ID:
+ switch (amd_manager->instance) {
+ case ACP_SDW0:
+ amd_manager->num_dout_ports = AMD_ACP63_SDW0_MAX_TX_PORTS;
+ amd_manager->num_din_ports = AMD_ACP63_SDW0_MAX_RX_PORTS;
+ break;
+ case ACP_SDW1:
+ amd_manager->num_dout_ports = AMD_ACP63_SDW1_MAX_TX_PORTS;
+ amd_manager->num_din_ports = AMD_ACP63_SDW1_MAX_RX_PORTS;
+ break;
+ default:
+ return -EINVAL;
+ }
break;
default:
return -EINVAL;
diff --git a/drivers/soundwire/amd_manager.h b/drivers/soundwire/amd_manager.h
index 707065468e05..cc2170e4521e 100644
--- a/drivers/soundwire/amd_manager.h
+++ b/drivers/soundwire/amd_manager.h
@@ -155,12 +155,12 @@
#define AMD_SDW_IRQ_MASK_8TO11 0x000c7777
#define AMD_SDW_IRQ_ERROR_MASK 0xff
#define AMD_SDW_MAX_FREQ_NUM 1
-#define AMD_SDW0_MAX_TX_PORTS 3
-#define AMD_SDW0_MAX_RX_PORTS 3
-#define AMD_SDW1_MAX_TX_PORTS 1
-#define AMD_SDW1_MAX_RX_PORTS 1
-#define AMD_SDW0_MAX_DAI 6
-#define AMD_SDW1_MAX_DAI 2
+#define AMD_ACP63_SDW0_MAX_TX_PORTS 3
+#define AMD_ACP63_SDW0_MAX_RX_PORTS 3
+#define AMD_ACP63_SDW1_MAX_TX_PORTS 1
+#define AMD_ACP63_SDW1_MAX_RX_PORTS 1
+#define AMD_ACP63_SDW0_MAX_DAI 6
+#define AMD_ACP63_SDW1_MAX_DAI 2
#define AMD_SDW_SLAVE_0_ATTACHED 5
#define AMD_SDW_SSP_COUNTER_VAL 3
@@ -222,7 +222,7 @@ struct sdw_manager_dp_reg {
* in SoundWire DMA driver.
*/
-static struct sdw_manager_dp_reg sdw0_manager_dp_reg[AMD_SDW0_MAX_DAI] = {
+static struct sdw_manager_dp_reg acp63_sdw0_dp_reg[AMD_ACP63_SDW0_MAX_DAI] = {
{ACP_SW_AUDIO0_TX_FRAME_FORMAT, ACP_SW_AUDIO0_TX_SAMPLEINTERVAL, ACP_SW_AUDIO0_TX_HCTRL_DP0,
ACP_SW_AUDIO0_TX_OFFSET_DP0, ACP_SW_AUDIO0_TX_CHANNEL_ENABLE_DP0},
{ACP_SW_AUDIO1_TX_FRAME_FORMAT, ACP_SW_AUDIO1_TX_SAMPLEINTERVAL, ACP_SW_AUDIO1_TX_HCTRL,
@@ -237,7 +237,7 @@ static struct sdw_manager_dp_reg sdw0_manager_dp_reg[AMD_SDW0_MAX_DAI] = {
ACP_SW_AUDIO2_RX_OFFSET, ACP_SW_AUDIO2_RX_CHANNEL_ENABLE_DP0},
};
-static struct sdw_manager_dp_reg sdw1_manager_dp_reg[AMD_SDW1_MAX_DAI] = {
+static struct sdw_manager_dp_reg acp63_sdw1_dp_reg[AMD_ACP63_SDW1_MAX_DAI] = {
{ACP_SW_AUDIO1_TX_FRAME_FORMAT, ACP_SW_AUDIO1_TX_SAMPLEINTERVAL, ACP_SW_AUDIO1_TX_HCTRL,
ACP_SW_AUDIO1_TX_OFFSET, ACP_SW_AUDIO1_TX_CHANNEL_ENABLE_DP0},
{ACP_SW_AUDIO1_RX_FRAME_FORMAT, ACP_SW_AUDIO1_RX_SAMPLEINTERVAL, ACP_SW_AUDIO1_RX_HCTRL,
diff --git a/include/linux/soundwire/sdw_amd.h b/include/linux/soundwire/sdw_amd.h
index e0abc59d4748..c9586f22c5a9 100644
--- a/include/linux/soundwire/sdw_amd.h
+++ b/include/linux/soundwire/sdw_amd.h
@@ -27,6 +27,7 @@
#define ACP_SDW0 0
#define ACP_SDW1 1
#define AMD_SDW_MAX_MANAGER_COUNT 2
+#define ACP63_PCI_REV_ID 0x63
struct acp_sdw_pdata {
u16 instance;
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 3/4] ASoC: SOF: amd: pass acp_rev as soundwire resource data
2024-09-24 8:18 [PATCH 0/4] refactor amd soundwire manager driver for acp 6.3 platform Vijendar Mukunda
2024-09-24 8:18 ` [PATCH 1/4] soundwire: amd: pass acp pci revision id as resource data Vijendar Mukunda
2024-09-24 8:18 ` [PATCH 2/4] soundwire: amd: refactor existing code for acp 6.3 platform Vijendar Mukunda
@ 2024-09-24 8:18 ` Vijendar Mukunda
2024-09-24 9:16 ` Mark Brown
2024-09-24 8:18 ` [PATCH 4/4] ASoC: amd: ps: pass acp pci revision id " Vijendar Mukunda
2024-10-03 8:08 ` [PATCH 0/4] refactor amd soundwire manager driver for acp 6.3 platform Vinod Koul
4 siblings, 1 reply; 8+ messages in thread
From: Vijendar Mukunda @ 2024-09-24 8:18 UTC (permalink / raw)
To: broonie, vkoul
Cc: alsa-devel, pierre-louis.bossart, yung-chuan.liao, lgirdwood,
perex, tiwai, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
venkataprasad.potturu, linux-sound, linux-kernel,
Vijendar Mukunda
Pass acp_rev(ACP pci revision id) as soundwire resource data
for SoundWire controller probe function.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
sound/soc/sof/amd/acp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
index d579c3849392..f967e8498798 100644
--- a/sound/soc/sof/amd/acp.c
+++ b/sound/soc/sof/amd/acp.c
@@ -683,6 +683,7 @@ static int amd_sof_sdw_probe(struct snd_sof_dev *sdev)
sdw_res.count = acp_data->info.count;
sdw_res.link_mask = acp_data->info.link_mask;
sdw_res.mmio_base = sdev->bar[ACP_DSP_BAR];
+ sdw_res.acp_rev = acp_data->pci_rev;
ret = sdw_amd_probe(&sdw_res, &acp_data->sdw);
if (ret)
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/4] ASoC: SOF: amd: pass acp_rev as soundwire resource data
2024-09-24 8:18 ` [PATCH 3/4] ASoC: SOF: amd: pass acp_rev as soundwire resource data Vijendar Mukunda
@ 2024-09-24 9:16 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2024-09-24 9:16 UTC (permalink / raw)
To: Vijendar Mukunda
Cc: vkoul, alsa-devel, pierre-louis.bossart, yung-chuan.liao,
lgirdwood, perex, tiwai, Basavaraj.Hiregoudar,
Sunil-kumar.Dommati, venkataprasad.potturu, linux-sound,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 215 bytes --]
On Tue, Sep 24, 2024 at 01:48:45PM +0530, Vijendar Mukunda wrote:
> Pass acp_rev(ACP pci revision id) as soundwire resource data
> for SoundWire controller probe function.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 4/4] ASoC: amd: ps: pass acp pci revision id as soundwire resource data
2024-09-24 8:18 [PATCH 0/4] refactor amd soundwire manager driver for acp 6.3 platform Vijendar Mukunda
` (2 preceding siblings ...)
2024-09-24 8:18 ` [PATCH 3/4] ASoC: SOF: amd: pass acp_rev as soundwire resource data Vijendar Mukunda
@ 2024-09-24 8:18 ` Vijendar Mukunda
2024-09-24 9:17 ` Mark Brown
2024-10-03 8:08 ` [PATCH 0/4] refactor amd soundwire manager driver for acp 6.3 platform Vinod Koul
4 siblings, 1 reply; 8+ messages in thread
From: Vijendar Mukunda @ 2024-09-24 8:18 UTC (permalink / raw)
To: broonie, vkoul
Cc: alsa-devel, pierre-louis.bossart, yung-chuan.liao, lgirdwood,
perex, tiwai, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
venkataprasad.potturu, linux-sound, linux-kernel,
Vijendar Mukunda
Add acp_rev as structure member in acp pci driver private data structure
to store acp pci revision id and assign this variable to SoundWire resource
data acp_rev variable.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
sound/soc/amd/ps/acp63.h | 2 ++
sound/soc/amd/ps/pci-ps.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/sound/soc/amd/ps/acp63.h b/sound/soc/amd/ps/acp63.h
index 39208305dd6c..e54eabaa4d3e 100644
--- a/sound/soc/amd/ps/acp63.h
+++ b/sound/soc/amd/ps/acp63.h
@@ -231,6 +231,7 @@ struct sdw_dma_ring_buf_reg {
* @sdw_en_stat: flag set to true when any one of the SoundWire manager instance is enabled
* @addr: pci ioremap address
* @reg_range: ACP reigister range
+ * @acp_rev: ACP PCI revision id
* @sdw0-dma_intr_stat: DMA interrupt status array for SoundWire manager-SW0 instance
* @sdw_dma_intr_stat: DMA interrupt status array for SoundWire manager-SW1 instance
*/
@@ -254,6 +255,7 @@ struct acp63_dev_data {
bool sdw_en_stat;
u32 addr;
u32 reg_range;
+ u32 acp_rev;
u16 sdw0_dma_intr_stat[ACP63_SDW0_DMA_MAX_STREAMS];
u16 sdw1_dma_intr_stat[ACP63_SDW1_DMA_MAX_STREAMS];
};
diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
index c72d666d51bd..0c3bb1da5097 100644
--- a/sound/soc/amd/ps/pci-ps.c
+++ b/sound/soc/amd/ps/pci-ps.c
@@ -267,6 +267,7 @@ static int amd_sdw_probe(struct device *dev)
sdw_res.acp_lock = &acp_data->acp_lock;
sdw_res.count = acp_data->info.count;
sdw_res.mmio_base = acp_data->acp63_base;
+ sdw_res.acp_rev = acp_data->acp_rev;
sdw_res.link_mask = acp_data->info.link_mask;
ret = sdw_amd_probe(&sdw_res, &acp_data->sdw);
if (ret)
@@ -576,6 +577,7 @@ static int snd_acp63_probe(struct pci_dev *pci,
}
adata->addr = addr;
adata->reg_range = ACP63_REG_END - ACP63_REG_START;
+ adata->acp_rev = pci->revision;
pci_set_master(pci);
pci_set_drvdata(pci, adata);
mutex_init(&adata->acp_lock);
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 4/4] ASoC: amd: ps: pass acp pci revision id as soundwire resource data
2024-09-24 8:18 ` [PATCH 4/4] ASoC: amd: ps: pass acp pci revision id " Vijendar Mukunda
@ 2024-09-24 9:17 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2024-09-24 9:17 UTC (permalink / raw)
To: Vijendar Mukunda
Cc: vkoul, alsa-devel, pierre-louis.bossart, yung-chuan.liao,
lgirdwood, perex, tiwai, Basavaraj.Hiregoudar,
Sunil-kumar.Dommati, venkataprasad.potturu, linux-sound,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
On Tue, Sep 24, 2024 at 01:48:46PM +0530, Vijendar Mukunda wrote:
> Add acp_rev as structure member in acp pci driver private data structure
> to store acp pci revision id and assign this variable to SoundWire resource
> data acp_rev variable.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/4] refactor amd soundwire manager driver for acp 6.3 platform
2024-09-24 8:18 [PATCH 0/4] refactor amd soundwire manager driver for acp 6.3 platform Vijendar Mukunda
` (3 preceding siblings ...)
2024-09-24 8:18 ` [PATCH 4/4] ASoC: amd: ps: pass acp pci revision id " Vijendar Mukunda
@ 2024-10-03 8:08 ` Vinod Koul
4 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2024-10-03 8:08 UTC (permalink / raw)
To: broonie, Vijendar Mukunda
Cc: alsa-devel, pierre-louis.bossart, yung-chuan.liao, lgirdwood,
perex, tiwai, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
venkataprasad.potturu, linux-sound, linux-kernel
On Tue, 24 Sep 2024 13:48:42 +0530, Vijendar Mukunda wrote:
> This patch series refactors the amd soundwire manager driver to support
> acp 6.3 platform based on acp pci revision id.
> This patch series prepared on top of asoc tree for-next branch.
> This patch series should be applied at one go.
>
> @Vinod: Please help to review soundwire patches and provide ack-by for
> this patch series.
>
> [...]
Applied, thanks!
[1/4] soundwire: amd: pass acp pci revision id as resource data
commit: ced20ea315fe8591093f19574ec32222c1ab71ba
[2/4] soundwire: amd: refactor existing code for acp 6.3 platform
commit: 7b54323dde29452dd06e6acd2701d9b489c9547d
[3/4] ASoC: SOF: amd: pass acp_rev as soundwire resource data
commit: 1bb50ead592ceaf2b1572c7d08797b8b3229432e
[4/4] ASoC: amd: ps: pass acp pci revision id as soundwire resource data
commit: 425f598ea69713b9e60f08e48a19be56b7bfddbc
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread