* [PATCH v3] reset: starfive: jh71x0: Fix accessing the empty member on JH7110 SoC
@ 2024-09-25 11:24 Changhuang Liang
2024-09-30 16:47 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Changhuang Liang @ 2024-09-25 11:24 UTC (permalink / raw)
To: Emil Renner Berthing, Hal Feng, Philipp Zabel
Cc: Conor Dooley, Changhuang Liang, linux-kernel, linux-riscv
data->asserted will be NULL on JH7110 SoC since commit 82327b127d41
("reset: starfive: Add StarFive JH7110 reset driver") was added. Add
the judgment condition to avoid errors when calling reset_control_status
on JH7110 SoC.
Fixes: 82327b127d41 ("reset: starfive: Add StarFive JH7110 reset driver")
Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Acked-by: Hal Feng <hal.feng@starfivetech.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
---
Add Fixes.
drivers/reset/starfive/reset-starfive-jh71x0.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/reset/starfive/reset-starfive-jh71x0.c b/drivers/reset/starfive/reset-starfive-jh71x0.c
index 55bbbd2de52c..29ce3486752f 100644
--- a/drivers/reset/starfive/reset-starfive-jh71x0.c
+++ b/drivers/reset/starfive/reset-starfive-jh71x0.c
@@ -94,6 +94,9 @@ static int jh71x0_reset_status(struct reset_controller_dev *rcdev,
void __iomem *reg_status = data->status + offset * sizeof(u32);
u32 value = readl(reg_status);
+ if (!data->asserted)
+ return !(value & mask);
+
return !((value ^ data->asserted[offset]) & mask);
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-30 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-25 11:24 [PATCH v3] reset: starfive: jh71x0: Fix accessing the empty member on JH7110 SoC Changhuang Liang
2024-09-30 16:47 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®