[PATCH 1/2] dt-bindings: mfd: mediatek: mt6397: add adc and regulators for mt6359

[PATCH 1/2] dt-bindings: mfd: mediatek: mt6397: add adc and regulators for mt6359

[Macpaul Lin]

Since MT6359 PMIC has been added as one of the compatibles of
"mediatek,mt6397.yaml", the sub-device node of "MT6359 PMIC AUXADC" and
"MT6359 PMIC Regulators" should also be contained in this DT Schema as
well.

This patch includes:
 - add 'adc' property and $ref for 'mediatek,mt6359-auxadc'.
 - add 'mt6359-regulator' to the compatibles of regulators.

Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
 Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
index 953358bc997a..40cabaf60d0d 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
@@ -17,6 +17,7 @@ description: |
   MT6397/MT6323 is a multifunction device with the following sub modules:
   - Regulators
   - RTC
+  - ADC
   - Audio codec
   - GPIO
   - Clock
@@ -86,6 +87,7 @@ properties:
           - enum:
               - mediatek,mt6323-regulator
               - mediatek,mt6358-regulator
+              - mediatek,mt6359-regulator
               - mediatek,mt6397-regulator
           - items:
               - enum:
@@ -95,6 +97,11 @@ properties:
     required:
       - compatible
 
+  adc:
+    type: object
+    $ref: /schemas/iio/adc/mediatek,mt6359-auxadc.yaml#
+    unevaluatedProperties: false
+
   audio-codec:
     type: object
     additionalProperties: false
-- 
2.45.2

[PATCH 2/2] arm64: dts: mediatek: mt6359: fix dtbs_check error for RTC and regulators

[Macpaul Lin]

This patch fixes the following dtbs_check errors:
1. 'mt6359rtc' do not match any of the regexes: 'pinctrl-[0-9]+'
 - Update 'mt6359rtc' in 'mt6359.dtsi' with a generic device name 'rtc'
2. 'pmic: regulators: 'compatible' is a required property'
 - Add 'mediatek,mt6359-regulator' to compatible property.

Fixes: 3b7d143be4b7 ("arm64: dts: mt6359: add PMIC MT6359 related nodes")
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt6359.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
index 8e1b8c85c6ed..dd732a820a7c 100644
--- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
@@ -18,6 +18,8 @@ mt6359codec: mt6359codec {
 		};
 
 		regulators {
+			compatible = "mediatek,mt6359-regulator";
+
 			mt6359_vs1_buck_reg: buck_vs1 {
 				regulator-name = "vs1";
 				regulator-min-microvolt = <800000>;
@@ -296,7 +298,7 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub {
 			};
 		};
 
-		mt6359rtc: mt6359rtc {
+		mt6359_rtc: rtc {
 			compatible = "mediatek,mt6358-rtc";
 		};
 	};
-- 
2.45.2

Re: [PATCH 1/2] dt-bindings: mfd: mediatek: mt6397: add adc and regulators for mt6359

[Rob Herring (Arm)]

On Thu, 26 Sep 2024 01:11:55 +0800, Macpaul Lin wrote:
> Since MT6359 PMIC has been added as one of the compatibles of
> "mediatek,mt6397.yaml", the sub-device node of "MT6359 PMIC AUXADC" and
> "MT6359 PMIC Regulators" should also be contained in this DT Schema as
> well.
> 
> This patch includes:
>  - add 'adc' property and $ref for 'mediatek,mt6359-auxadc'.
>  - add 'mt6359-regulator' to the compatibles of regulators.
> 
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
>  Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 1/2] dt-bindings: mfd: mediatek: mt6397: add adc and regulators for mt6359

[Macpaul Lin]

On 9/26/24 10:47, Rob Herring (Arm) wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On Thu, 26 Sep 2024 01:11:55 +0800, Macpaul Lin wrote:
>> Since MT6359 PMIC has been added as one of the compatibles of
>> "mediatek,mt6397.yaml", the sub-device node of "MT6359 PMIC AUXADC" and
>> "MT6359 PMIC Regulators" should also be contained in this DT Schema as
>> well.
>> 
>> This patch includes:
>>  - add 'adc' property and $ref for 'mediatek,mt6359-auxadc'.
>>  - add 'mt6359-regulator' to the compatibles of regulators.
>> 
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>>  Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>> 
> 
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> 

Thanks for the review. This patch will be merged into v7 patch of
the conversion of
Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml'

Thanks!
Macpaul Lin

Re: [PATCH 1/2] dt-bindings: mfd: mediatek: mt6397: add adc and regulators for mt6359

[Macpaul Lin]

On 9/30/24 13:53, Macpaul Lin wrote:
> 
> 
> On 9/26/24 10:47, Rob Herring (Arm) wrote:
>>
>>
>> External email : Please do not click links or open attachments until 
>> you have verified the sender or the content.
>>
>> On Thu, 26 Sep 2024 01:11:55 +0800, Macpaul Lin wrote:
>>> Since MT6359 PMIC has been added as one of the compatibles of
>>> "mediatek,mt6397.yaml", the sub-device node of "MT6359 PMIC AUXADC" and
>>> "MT6359 PMIC Regulators" should also be contained in this DT Schema as
>>> well.
>>>
>>> This patch includes:
>>>  - add 'adc' property and $ref for 'mediatek,mt6359-auxadc'.
>>>  - add 'mt6359-regulator' to the compatibles of regulators.
>>>
>>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>>> ---
>>>  Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>
>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>
> 
> Thanks for the review. This patch will be merged into v7 patch of
> the conversion of
> Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml'
> 
> Thanks!
> Macpaul Lin
> 

Updated:
Since the nearly the final version patch of v8 of 
'mfd/mediatek,mt6397.yaml' is without adc, audio-codec, and regulator
of mt6359
([1] 
https://lore.kernel.org/all/20241001104145.24054-3-macpaul.lin@mediatek.com/),
a patchset v2 has been send.
[2] 
https://lore.kernel.org/all/20241004030148.13366-1-macpaul.lin@mediatek.com/

Thanks
Macpaul Lin