mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
	michael.christie@oracle.com, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: [PATCH v2 6/7] vhost: Add kthread support in function vhost_worker_create
Date: Fri,  4 Oct 2024 09:58:20 +0800	[thread overview]
Message-ID: <20241004015937.2286459-7-lulu@redhat.com> (raw)
In-Reply-To: <20241004015937.2286459-1-lulu@redhat.com>

Split the function vhost_worker_create to support both task and kthread

Added back the previous old function vhost_worker_create and rename it to
vhost_worker_create_khtread to support the khtread.

The new vhost_worker_create will be selected which to use based on the
value of the parameter.

the old function vhost_worker_create was change to support task in
commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads")
also changed in
commit 1cdaafa1b8b4 ("vhost: replace single worker pointer with xarray")
commit c011bb669ddc ("vhost: dynamically allocate vhost_worker")

Signed-off-by: Cindy Lu <lulu@redhat.com>
---
 drivers/vhost/vhost.c | 55 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 54 insertions(+), 1 deletion(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index eb30da658bfe..08c9e77916ca 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -808,7 +808,8 @@ static void vhost_workers_free(struct vhost_dev *dev)
 	else
 		vhost_workers_free_kthread(dev);
 }
-static struct vhost_worker *vhost_worker_create(struct vhost_dev *dev)
+
+static struct vhost_worker *vhost_worker_create_task(struct vhost_dev *dev)
 {
 	struct vhost_worker *worker;
 	struct vhost_task *vtsk;
@@ -849,6 +850,50 @@ static struct vhost_worker *vhost_worker_create(struct vhost_dev *dev)
 	return NULL;
 }
 
+static struct vhost_worker *vhost_worker_create_kthread(struct vhost_dev *dev)
+{
+	struct vhost_worker *worker;
+	struct task_struct *task;
+	int ret;
+	u32 id;
+
+	worker = kzalloc(sizeof(*worker), GFP_KERNEL_ACCOUNT);
+	if (!worker)
+		return NULL;
+
+	worker->dev = dev;
+	worker->kcov_handle = kcov_common_handle();
+
+	mutex_init(&worker->mutex);
+	init_llist_head(&worker->work_list);
+
+	task = kthread_create(vhost_run_work_kthread_list, worker, "vhost-%d",
+			      current->pid);
+	if (IS_ERR(task)) {
+		ret = PTR_ERR(task);
+		goto free_worker;
+	}
+
+	worker->task = task;
+	wake_up_process(task); /* avoid contributing to loadavg */
+	ret = xa_alloc(&dev->worker_xa, &id, worker, xa_limit_32b, GFP_KERNEL);
+	if (ret < 0)
+		goto stop_worker;
+	worker->id = id;
+
+	ret = vhost_attach_cgroups(dev);
+	if (ret)
+		goto stop_worker;
+
+	return worker;
+
+stop_worker:
+	kthread_stop(worker->task);
+free_worker:
+	kfree(worker);
+	return NULL;
+}
+
 /* Caller must have device mutex */
 static void __vhost_vq_attach_worker(struct vhost_virtqueue *vq,
 				     struct vhost_worker *worker)
@@ -937,6 +982,14 @@ static int vhost_vq_attach_worker(struct vhost_virtqueue *vq,
 	return 0;
 }
 
+static struct vhost_worker *vhost_worker_create(struct vhost_dev *dev)
+{
+	if (enforce_inherit_owner)
+		return vhost_worker_create_task(dev);
+	else
+		return vhost_worker_create_kthread(dev);
+}
+
 /* Caller must have device mutex */
 static int vhost_new_worker(struct vhost_dev *dev,
 			    struct vhost_worker_state *info)
-- 
2.45.0


  parent reply	other threads:[~2024-10-04  2:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04  1:58 [PATCH v2 0/7] vhost: Add support of kthread API Cindy Lu
2024-10-04  1:58 ` [PATCH v2 1/7] vhost: Add a new modparam to allow userspace select vhost_task Cindy Lu
2024-10-05 15:42   ` kernel test robot
2024-10-07 13:31   ` Stefano Garzarella
2024-10-09  7:28     ` Jason Wang
2024-10-09  7:57       ` Stefano Garzarella
2024-10-09  8:20         ` Jason Wang
2024-10-14  6:47           ` Cindy Lu
2024-10-14  6:46     ` Cindy Lu
2024-10-04  1:58 ` [PATCH v2 2/7] vhost: Add kthread support in function vhost_worker_queue() Cindy Lu
2024-10-04  1:58 ` [PATCH v2 3/7] vhost: Add kthread support in function vhost_workers_free() Cindy Lu
2024-10-07 13:32   ` Stefano Garzarella
2024-10-15  5:54     ` Cindy Lu
2024-10-14 21:05   ` Mike Christie
2024-10-15  6:05     ` Cindy Lu
2024-10-15  6:52       ` Stefano Garzarella
2024-10-15  7:19         ` Cindy Lu
2024-10-04  1:58 ` [PATCH v2 4/7] vhost: Add the vhost_worker to support kthread Cindy Lu
2024-10-14 22:56   ` Mike Christie
2024-10-15  9:03     ` Cindy Lu
2024-10-04  1:58 ` [PATCH v2 5/7] vhost: Add the cgroup related function Cindy Lu
2024-10-04  1:58 ` Cindy Lu [this message]
2024-10-14 21:02   ` [PATCH v2 6/7] vhost: Add kthread support in function vhost_worker_create Mike Christie
2024-10-15  6:30     ` Cindy Lu
2024-10-04  1:58 ` [PATCH v2 7/7] vhost: Add new UAPI to support change to task mode Cindy Lu
2024-10-07 13:37   ` Stefano Garzarella
2024-10-14 20:56   ` Mike Christie
2024-10-15  2:35     ` Cindy Lu
2024-10-15 10:19     ` Michael S. Tsirkin
2024-10-17  6:53       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241004015937.2286459-7-lulu@redhat.com \
    --to=lulu@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®