mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: Cindy Lu <lulu@redhat.com>,
	jasowang@redhat.com, mst@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 6/7] vhost: Add kthread support in function vhost_worker_create
Date: Mon, 14 Oct 2024 16:02:09 -0500	[thread overview]
Message-ID: <a317b7f1-b593-4cf0-a58a-8f375ad64f72@oracle.com> (raw)
In-Reply-To: <20241004015937.2286459-7-lulu@redhat.com>

On 10/3/24 8:58 PM, Cindy Lu wrote:
> +static struct vhost_worker *vhost_worker_create(struct vhost_dev *dev)
> +{
> +	if (enforce_inherit_owner)
> +		return vhost_worker_create_task(dev);
> +	else
> +		return vhost_worker_create_kthread(dev);
> +}

The reason we are in this whole mess is because for vhost-scsi
we wanted to create multiple worker threads as the single thread
became a bottleneck. We couldn't use kthreads because they were
not accounted for under thread that created it and we could
exceed the NPROC_LIMIT.

So with the above code, we could hit that problem again if userspace
did the VHOST_NEW_WORKER ioctl and enforce_inherit_owner=false.

You would want a check for enforce_inherit_owner in vhost_worker_ioctl.

  reply	other threads:[~2024-10-14 21:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04  1:58 [PATCH v2 0/7] vhost: Add support of kthread API Cindy Lu
2024-10-04  1:58 ` [PATCH v2 1/7] vhost: Add a new modparam to allow userspace select vhost_task Cindy Lu
2024-10-05 15:42   ` kernel test robot
2024-10-07 13:31   ` Stefano Garzarella
2024-10-09  7:28     ` Jason Wang
2024-10-09  7:57       ` Stefano Garzarella
2024-10-09  8:20         ` Jason Wang
2024-10-14  6:47           ` Cindy Lu
2024-10-14  6:46     ` Cindy Lu
2024-10-04  1:58 ` [PATCH v2 2/7] vhost: Add kthread support in function vhost_worker_queue() Cindy Lu
2024-10-04  1:58 ` [PATCH v2 3/7] vhost: Add kthread support in function vhost_workers_free() Cindy Lu
2024-10-07 13:32   ` Stefano Garzarella
2024-10-15  5:54     ` Cindy Lu
2024-10-14 21:05   ` Mike Christie
2024-10-15  6:05     ` Cindy Lu
2024-10-15  6:52       ` Stefano Garzarella
2024-10-15  7:19         ` Cindy Lu
2024-10-04  1:58 ` [PATCH v2 4/7] vhost: Add the vhost_worker to support kthread Cindy Lu
2024-10-14 22:56   ` Mike Christie
2024-10-15  9:03     ` Cindy Lu
2024-10-04  1:58 ` [PATCH v2 5/7] vhost: Add the cgroup related function Cindy Lu
2024-10-04  1:58 ` [PATCH v2 6/7] vhost: Add kthread support in function vhost_worker_create Cindy Lu
2024-10-14 21:02   ` Mike Christie [this message]
2024-10-15  6:30     ` Cindy Lu
2024-10-04  1:58 ` [PATCH v2 7/7] vhost: Add new UAPI to support change to task mode Cindy Lu
2024-10-07 13:37   ` Stefano Garzarella
2024-10-14 20:56   ` Mike Christie
2024-10-15  2:35     ` Cindy Lu
2024-10-15 10:19     ` Michael S. Tsirkin
2024-10-17  6:53       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a317b7f1-b593-4cf0-a58a-8f375ad64f72@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®