* [PATCH] drm/bridge: cdns-mhdp8546: Remove unused functions
@ 2024-10-05 23:20 linux
2024-11-05 13:28 ` Dr. David Alan Gilbert
2024-11-11 17:36 ` Robert Foss
0 siblings, 2 replies; 3+ messages in thread
From: linux @ 2024-10-05 23:20 UTC (permalink / raw)
To: andrzej.hajda, neil.armstrong, rfoss, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona
Cc: dri-devel, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
cdns_mhdp_hdcp_set_lc() and cdns_mhdp_hdcp_set_public_key_param()
were added by commit
6a3608eae6d3 ("drm: bridge: cdns-mhdp8546: Enable HDCP")
but never used.
Remove them.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
.../drm/bridge/cadence/cdns-mhdp8546-hdcp.c | 28 -------------------
.../drm/bridge/cadence/cdns-mhdp8546-hdcp.h | 3 --
2 files changed, 31 deletions(-)
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c
index 31832ba4017f..42248f179b69 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c
@@ -500,34 +500,6 @@ static void cdns_mhdp_hdcp_prop_work(struct work_struct *work)
drm_modeset_unlock(&dev->mode_config.connection_mutex);
}
-int cdns_mhdp_hdcp_set_lc(struct cdns_mhdp_device *mhdp, u8 *val)
-{
- int ret;
-
- mutex_lock(&mhdp->mbox_mutex);
- ret = cdns_mhdp_secure_mailbox_send(mhdp, MB_MODULE_ID_HDCP_GENERAL,
- HDCP_GENERAL_SET_LC_128,
- 16, val);
- mutex_unlock(&mhdp->mbox_mutex);
-
- return ret;
-}
-
-int
-cdns_mhdp_hdcp_set_public_key_param(struct cdns_mhdp_device *mhdp,
- struct cdns_hdcp_tx_public_key_param *val)
-{
- int ret;
-
- mutex_lock(&mhdp->mbox_mutex);
- ret = cdns_mhdp_secure_mailbox_send(mhdp, MB_MODULE_ID_HDCP_TX,
- HDCP2X_TX_SET_PUBLIC_KEY_PARAMS,
- sizeof(*val), (u8 *)val);
- mutex_unlock(&mhdp->mbox_mutex);
-
- return ret;
-}
-
int cdns_mhdp_hdcp_enable(struct cdns_mhdp_device *mhdp, u8 content_type)
{
int ret;
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.h b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.h
index 334c0b8b0d4f..3b6ec9c3a8d8 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.h
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.h
@@ -82,9 +82,6 @@ struct cdns_hdcp_tx_public_key_param {
u8 E[DLP_E];
};
-int cdns_mhdp_hdcp_set_public_key_param(struct cdns_mhdp_device *mhdp,
- struct cdns_hdcp_tx_public_key_param *val);
-int cdns_mhdp_hdcp_set_lc(struct cdns_mhdp_device *mhdp, u8 *val);
int cdns_mhdp_hdcp_enable(struct cdns_mhdp_device *mhdp, u8 content_type);
int cdns_mhdp_hdcp_disable(struct cdns_mhdp_device *mhdp);
void cdns_mhdp_hdcp_init(struct cdns_mhdp_device *mhdp);
--
2.46.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/bridge: cdns-mhdp8546: Remove unused functions
2024-10-05 23:20 [PATCH] drm/bridge: cdns-mhdp8546: Remove unused functions linux
@ 2024-11-05 13:28 ` Dr. David Alan Gilbert
2024-11-11 17:36 ` Robert Foss
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2024-11-05 13:28 UTC (permalink / raw)
To: andrzej.hajda, neil.armstrong, rfoss, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona
Cc: dri-devel, linux-kernel
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> cdns_mhdp_hdcp_set_lc() and cdns_mhdp_hdcp_set_public_key_param()
> were added by commit
> 6a3608eae6d3 ("drm: bridge: cdns-mhdp8546: Enable HDCP")
> but never used.
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Ping.
Dave
> ---
> .../drm/bridge/cadence/cdns-mhdp8546-hdcp.c | 28 -------------------
> .../drm/bridge/cadence/cdns-mhdp8546-hdcp.h | 3 --
> 2 files changed, 31 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c
> index 31832ba4017f..42248f179b69 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c
> @@ -500,34 +500,6 @@ static void cdns_mhdp_hdcp_prop_work(struct work_struct *work)
> drm_modeset_unlock(&dev->mode_config.connection_mutex);
> }
>
> -int cdns_mhdp_hdcp_set_lc(struct cdns_mhdp_device *mhdp, u8 *val)
> -{
> - int ret;
> -
> - mutex_lock(&mhdp->mbox_mutex);
> - ret = cdns_mhdp_secure_mailbox_send(mhdp, MB_MODULE_ID_HDCP_GENERAL,
> - HDCP_GENERAL_SET_LC_128,
> - 16, val);
> - mutex_unlock(&mhdp->mbox_mutex);
> -
> - return ret;
> -}
> -
> -int
> -cdns_mhdp_hdcp_set_public_key_param(struct cdns_mhdp_device *mhdp,
> - struct cdns_hdcp_tx_public_key_param *val)
> -{
> - int ret;
> -
> - mutex_lock(&mhdp->mbox_mutex);
> - ret = cdns_mhdp_secure_mailbox_send(mhdp, MB_MODULE_ID_HDCP_TX,
> - HDCP2X_TX_SET_PUBLIC_KEY_PARAMS,
> - sizeof(*val), (u8 *)val);
> - mutex_unlock(&mhdp->mbox_mutex);
> -
> - return ret;
> -}
> -
> int cdns_mhdp_hdcp_enable(struct cdns_mhdp_device *mhdp, u8 content_type)
> {
> int ret;
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.h b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.h
> index 334c0b8b0d4f..3b6ec9c3a8d8 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.h
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.h
> @@ -82,9 +82,6 @@ struct cdns_hdcp_tx_public_key_param {
> u8 E[DLP_E];
> };
>
> -int cdns_mhdp_hdcp_set_public_key_param(struct cdns_mhdp_device *mhdp,
> - struct cdns_hdcp_tx_public_key_param *val);
> -int cdns_mhdp_hdcp_set_lc(struct cdns_mhdp_device *mhdp, u8 *val);
> int cdns_mhdp_hdcp_enable(struct cdns_mhdp_device *mhdp, u8 content_type);
> int cdns_mhdp_hdcp_disable(struct cdns_mhdp_device *mhdp);
> void cdns_mhdp_hdcp_init(struct cdns_mhdp_device *mhdp);
> --
> 2.46.2
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/bridge: cdns-mhdp8546: Remove unused functions
2024-10-05 23:20 [PATCH] drm/bridge: cdns-mhdp8546: Remove unused functions linux
2024-11-05 13:28 ` Dr. David Alan Gilbert
@ 2024-11-11 17:36 ` Robert Foss
1 sibling, 0 replies; 3+ messages in thread
From: Robert Foss @ 2024-11-11 17:36 UTC (permalink / raw)
To: andrzej.hajda, neil.armstrong, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, linux
Cc: dri-devel, linux-kernel
On Sun, 06 Oct 2024 00:20:17 +0100, linux@treblig.org wrote:
> cdns_mhdp_hdcp_set_lc() and cdns_mhdp_hdcp_set_public_key_param()
> were added by commit
> 6a3608eae6d3 ("drm: bridge: cdns-mhdp8546: Enable HDCP")
> but never used.
>
> Remove them.
>
> [...]
Applied, thanks!
[1/1] drm/bridge: cdns-mhdp8546: Remove unused functions
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/d84927a4ad92
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-11 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-05 23:20 [PATCH] drm/bridge: cdns-mhdp8546: Remove unused functions linux
2024-11-05 13:28 ` Dr. David Alan Gilbert
2024-11-11 17:36 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome