* kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used
@ 2024-10-05 18:58 kernel test robot
2024-10-07 10:08 ` Christian Loehle
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2024-10-05 18:58 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: oe-kbuild-all, linux-kernel, Thomas Gleixner
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 27cc6fdf720183dce1dbd293483ec5a9cb6b595e
commit: d2d6422f8bd17c6bb205133e290625a564194496 x86: Allow to enable PREEMPT_RT.
date: 3 weeks ago
config: x86_64-buildonly-randconfig-002-20241006 (https://download.01.org/0day-ci/archive/20241006/202410060258.bPl2ZoUo-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241006/202410060258.bPl2ZoUo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410060258.bPl2ZoUo-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/seqlock.h:19,
from include/linux/dcache.h:11,
from include/linux/fs.h:8,
from include/linux/highmem.h:5,
from kernel/sched/core.c:10:
>> kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used [-Wunused-variable]
1361 | static DEFINE_MUTEX(uclamp_mutex);
| ^~~~~~~~~~~~
include/linux/mutex.h:101:22: note: in definition of macro 'DEFINE_MUTEX'
101 | struct mutex mutexname = __MUTEX_INITIALIZER(mutexname)
| ^~~~~~~~~
vim +/uclamp_mutex +1361 kernel/sched/core.c
71f8bd4600521f kernel/sched.c Ingo Molnar 2007-07-09 1349
69842cba9ace84 kernel/sched/core.c Patrick Bellasi 2019-06-21 1350 #ifdef CONFIG_UCLAMP_TASK
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1351 /*
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1352 * Serializes updates of utilization clamp values
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1353 *
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1354 * The (slow-path) user-space triggers utilization clamp value updates which
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1355 * can require updates on (fast-path) scheduler's data structures used to
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1356 * support enqueue/dequeue operations.
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1357 * While the per-CPU rq lock protects fast-path update operations, user-space
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1358 * requests are serialized using a mutex to reduce the risk of conflicting
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1359 * updates or API abuses.
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1360 */
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 @1361 static DEFINE_MUTEX(uclamp_mutex);
2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1362
:::::: The code at line 1361 was first introduced by commit
:::::: 2480c093130f64ac3a410504fa8b3db1fc4b87ce sched/uclamp: Extend CPU's cgroup controller
:::::: TO: Patrick Bellasi <patrick.bellasi@arm.com>
:::::: CC: Ingo Molnar <mingo@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used
2024-10-05 18:58 kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used kernel test robot
@ 2024-10-07 10:08 ` Christian Loehle
2024-10-25 6:32 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 5+ messages in thread
From: Christian Loehle @ 2024-10-07 10:08 UTC (permalink / raw)
To: kernel test robot, Sebastian Andrzej Siewior
Cc: oe-kbuild-all, linux-kernel, Thomas Gleixner
On 10/5/24 19:58, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 27cc6fdf720183dce1dbd293483ec5a9cb6b595e
> commit: d2d6422f8bd17c6bb205133e290625a564194496 x86: Allow to enable PREEMPT_RT.
> date: 3 weeks ago
> config: x86_64-buildonly-randconfig-002-20241006 (https://download.01.org/0day-ci/archive/20241006/202410060258.bPl2ZoUo-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241006/202410060258.bPl2ZoUo-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202410060258.bPl2ZoUo-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> In file included from include/linux/seqlock.h:19,
> from include/linux/dcache.h:11,
> from include/linux/fs.h:8,
> from include/linux/highmem.h:5,
> from kernel/sched/core.c:10:
>>> kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used [-Wunused-variable]
> 1361 | static DEFINE_MUTEX(uclamp_mutex);
> | ^~~~~~~~~~~~
> include/linux/mutex.h:101:22: note: in definition of macro 'DEFINE_MUTEX'
> 101 | struct mutex mutexname = __MUTEX_INITIALIZER(mutexname)
> | ^~~~~~~~~
>
>
> vim +/uclamp_mutex +1361 kernel/sched/core.c
>
> 71f8bd4600521f kernel/sched.c Ingo Molnar 2007-07-09 1349
> 69842cba9ace84 kernel/sched/core.c Patrick Bellasi 2019-06-21 1350 #ifdef CONFIG_UCLAMP_TASK
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1351 /*
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1352 * Serializes updates of utilization clamp values
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1353 *
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1354 * The (slow-path) user-space triggers utilization clamp value updates which
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1355 * can require updates on (fast-path) scheduler's data structures used to
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1356 * support enqueue/dequeue operations.
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1357 * While the per-CPU rq lock protects fast-path update operations, user-space
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1358 * requests are serialized using a mutex to reduce the risk of conflicting
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1359 * updates or API abuses.
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1360 */
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 @1361 static DEFINE_MUTEX(uclamp_mutex);
> 2480c093130f64 kernel/sched/core.c Patrick Bellasi 2019-08-22 1362
>
> :::::: The code at line 1361 was first introduced by commit
> :::::: 2480c093130f64ac3a410504fa8b3db1fc4b87ce sched/uclamp: Extend CPU's cgroup controller
>
> :::::: TO: Patrick Bellasi <patrick.bellasi@arm.com>
> :::::: CC: Ingo Molnar <mingo@kernel.org>
>
Please allow me a day to walk through the code just to double-check, but
the obvious fixes are either letting UCLAMP_TASK depend on SYSCTL or:
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 43e453ab7e20..18d9622eac8d 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1394,7 +1394,9 @@ void set_load_weight(struct task_struct *p, bool update_load)
* requests are serialized using a mutex to reduce the risk of conflicting
* updates or API abuses.
*/
+#if defined(CONFIG_UCLAMP_TASK_GROUP) || defined(CONFIG_SYSCTL)
static DEFINE_MUTEX(uclamp_mutex);
+#endif
/* Max allowed minimum utilization */
static unsigned int __maybe_unused sysctl_sched_uclamp_util_min = SCHED_CAPACITY_SCALE;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used
2024-10-07 10:08 ` Christian Loehle
@ 2024-10-25 6:32 ` Sebastian Andrzej Siewior
2024-10-25 9:58 ` Christian Loehle
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Andrzej Siewior @ 2024-10-25 6:32 UTC (permalink / raw)
To: Christian Loehle
Cc: kernel test robot, oe-kbuild-all, linux-kernel, Thomas Gleixner
On 2024-10-07 11:08:36 [+0100], Christian Loehle wrote:
> Please allow me a day to walk through the code just to double-check, but
> the obvious fixes are either letting UCLAMP_TASK depend on SYSCTL or:
This does not look too bad. Meanwhile I got another report
https://lore.kernel.org/202410250459.EJe6PJI5-lkp@intel.com
Mind to post this?
Sebastian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used
2024-10-25 6:32 ` Sebastian Andrzej Siewior
@ 2024-10-25 9:58 ` Christian Loehle
0 siblings, 0 replies; 5+ messages in thread
From: Christian Loehle @ 2024-10-25 9:58 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: kernel test robot, oe-kbuild-all, linux-kernel, Thomas Gleixner
On 10/25/24 07:32, Sebastian Andrzej Siewior wrote:
> On 2024-10-07 11:08:36 [+0100], Christian Loehle wrote:
>> Please allow me a day to walk through the code just to double-check, but
>> the obvious fixes are either letting UCLAMP_TASK depend on SYSCTL or:
>
> This does not look too bad. Meanwhile I got another report
> https://lore.kernel.org/202410250459.EJe6PJI5-lkp@intel.com
>
> Mind to post this?
>
> Sebastian
I have, as standalone thread though, sorry.
I'll CC you and ping.
https://lore.kernel.org/lkml/b2ad1f31-21b9-42a5-a735-b9496470348a@arm.com/
Regards,
Christian
^ permalink raw reply [flat|nested] 5+ messages in thread
* kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used
@ 2024-10-24 20:34 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2024-10-24 20:34 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: oe-kbuild-all, linux-kernel, Thomas Gleixner
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c2ee9f594da826bea183ed14f2cc029c719bf4da
commit: d8fccd9ca5f905533dc6c26cfd1f91beb8691c95 arm64: Allow to enable PREEMPT_RT.
date: 5 weeks ago
config: arm64-randconfig-004-20241025 (https://download.01.org/0day-ci/archive/20241025/202410250459.EJe6PJI5-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241025/202410250459.EJe6PJI5-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410250459.EJe6PJI5-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/seqlock.h:19,
from include/linux/dcache.h:11,
from include/linux/fs.h:8,
from include/linux/highmem.h:5,
from kernel/sched/core.c:10:
>> kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used [-Wunused-variable]
1361 | static DEFINE_MUTEX(uclamp_mutex);
| ^~~~~~~~~~~~
include/linux/mutex.h:101:22: note: in definition of macro 'DEFINE_MUTEX'
101 | struct mutex mutexname = __MUTEX_INITIALIZER(mutexname)
| ^~~~~~~~~
vim +/uclamp_mutex +1361 kernel/sched/core.c
71f8bd4600521fe kernel/sched.c Ingo Molnar 2007-07-09 1349
69842cba9ace848 kernel/sched/core.c Patrick Bellasi 2019-06-21 1350 #ifdef CONFIG_UCLAMP_TASK
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 1351 /*
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 1352 * Serializes updates of utilization clamp values
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 1353 *
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 1354 * The (slow-path) user-space triggers utilization clamp value updates which
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 1355 * can require updates on (fast-path) scheduler's data structures used to
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 1356 * support enqueue/dequeue operations.
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 1357 * While the per-CPU rq lock protects fast-path update operations, user-space
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 1358 * requests are serialized using a mutex to reduce the risk of conflicting
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 1359 * updates or API abuses.
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 1360 */
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 @1361 static DEFINE_MUTEX(uclamp_mutex);
2480c093130f64a kernel/sched/core.c Patrick Bellasi 2019-08-22 1362
:::::: The code at line 1361 was first introduced by commit
:::::: 2480c093130f64ac3a410504fa8b3db1fc4b87ce sched/uclamp: Extend CPU's cgroup controller
:::::: TO: Patrick Bellasi <patrick.bellasi@arm.com>
:::::: CC: Ingo Molnar <mingo@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-25 9:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-05 18:58 kernel/sched/core.c:1361:21: warning: 'uclamp_mutex' defined but not used kernel test robot
2024-10-07 10:08 ` Christian Loehle
2024-10-25 6:32 ` Sebastian Andrzej Siewior
2024-10-25 9:58 ` Christian Loehle
2024-10-24 20:34 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®