* [PATCH] gpio: eic-sprd: use generic device_get_match_data()
@ 2024-10-07 10:28 Bartosz Golaszewski
2024-10-11 19:42 ` Linus Walleij
2024-10-14 8:31 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2024-10-07 10:28 UTC (permalink / raw)
To: Linus Walleij, Orson Zhai, Baolin Wang, Chunyan Zhang
Cc: linux-gpio, linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
There's no need to use the OF-specific variant to get the match data.
Switch to using device_get_match_data() instead.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/gpio-eic-sprd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
index 2dd0e46c42ad..d4bf8d187e16 100644
--- a/drivers/gpio/gpio-eic-sprd.c
+++ b/drivers/gpio/gpio-eic-sprd.c
@@ -10,8 +10,8 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/notifier.h>
-#include <linux/of.h>
#include <linux/platform_device.h>
+#include <linux/property.h>
#include <linux/spinlock.h>
/* EIC registers definition */
@@ -617,7 +617,7 @@ static int sprd_eic_probe(struct platform_device *pdev)
u16 num_banks = 0;
int ret, i;
- pdata = of_device_get_match_data(dev);
+ pdata = device_get_match_data(dev);
if (!pdata) {
dev_err(dev, "No matching driver data found.\n");
return -EINVAL;
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: eic-sprd: use generic device_get_match_data()
2024-10-07 10:28 [PATCH] gpio: eic-sprd: use generic device_get_match_data() Bartosz Golaszewski
@ 2024-10-11 19:42 ` Linus Walleij
2024-10-14 8:31 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2024-10-11 19:42 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Orson Zhai, Baolin Wang, Chunyan Zhang, linux-gpio, linux-kernel,
Bartosz Golaszewski
On Mon, Oct 7, 2024 at 12:29 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> There's no need to use the OF-specific variant to get the match data.
> Switch to using device_get_match_data() instead.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: eic-sprd: use generic device_get_match_data()
2024-10-07 10:28 [PATCH] gpio: eic-sprd: use generic device_get_match_data() Bartosz Golaszewski
2024-10-11 19:42 ` Linus Walleij
@ 2024-10-14 8:31 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2024-10-14 8:31 UTC (permalink / raw)
To: Linus Walleij, Orson Zhai, Baolin Wang, Chunyan Zhang,
Bartosz Golaszewski
Cc: Bartosz Golaszewski, linux-gpio, linux-kernel
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Mon, 07 Oct 2024 12:28:59 +0200, Bartosz Golaszewski wrote:
> There's no need to use the OF-specific variant to get the match data.
> Switch to using device_get_match_data() instead.
>
>
Applied, thanks!
[1/1] gpio: eic-sprd: use generic device_get_match_data()
commit: 1396470c11d4f30b4d4f444adf353848b48c74da
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-14 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-07 10:28 [PATCH] gpio: eic-sprd: use generic device_get_match_data() Bartosz Golaszewski
2024-10-11 19:42 ` Linus Walleij
2024-10-14 8:31 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome