[PATCH v1 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

[PATCH v1 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

[Aleksandrs Vinarskis]

Introduce low-res IPS and OLED panels for mentioned device.

SHP panel's timings were picked experimentally, without this patch or with
`delay_200_500_e50` panel sometimes fails to boot/stays black on startup.

LGD panel's timings were copied from other LGD panels and tested to be
working.

Particular laptop also comes in high-res IPS variant, which unfortunately
I do not have access to verify.

Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
Tested-by: Peter de Kraker <peterdekraker@umito.nl>
---
 drivers/gpu/drm/panel/panel-edp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index 767e47a2b0c1..8566e9cf2f82 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1977,11 +1977,13 @@ static const struct edp_panel_entry edp_panels[] = {
 	EDP_PANEL_ENTRY('L', 'G', 'D', 0x0567, &delay_200_500_e200_d200, "Unknown"),
 	EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown"),
 	EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown"),
+	EDP_PANEL_ENTRY('L', 'G', 'D', 0x0778, &delay_200_500_e200_d200, "134WT1"),
 
 	EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"),
 	EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"),
 	EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"),
 	EDP_PANEL_ENTRY('S', 'H', 'P', 0x154c, &delay_200_500_p2e100, "LQ116M1JW10"),
+	EDP_PANEL_ENTRY('S', 'H', 'P', 0x1593, &delay_200_500_p2e100, "LQ134N1"),
 
 	EDP_PANEL_ENTRY('S', 'T', 'A', 0x0100, &delay_100_500_e200, "2081116HHD028001-51D"),
 
-- 
2.45.2

Re: [PATCH v1 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

[Doug Anderson]

Hi,

On Mon, Oct 7, 2024 at 1:14 PM Aleksandrs Vinarskis
<alex.vinarskis@gmail.com> wrote:
>
> Introduce low-res IPS and OLED panels for mentioned device.
>
> SHP panel's timings were picked experimentally, without this patch or with
> `delay_200_500_e50` panel sometimes fails to boot/stays black on startup.
>
> LGD panel's timings were copied from other LGD panels and tested to be
> working.
>
> Particular laptop also comes in high-res IPS variant, which unfortunately
> I do not have access to verify.
>
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> Tested-by: Peter de Kraker <peterdekraker@umito.nl>

Your signed-off-by should be _below_ Peter's Tested-by. That means
that you're the one that signed-off on the fact that Peter tested
this.

> ---
>  drivers/gpu/drm/panel/panel-edp.c | 2 ++
>  1 file changed, 2 insertions(+)

This looks OK to me. I've been requesting people include the RAW EDID
of panels that they add in the commit message, though. Could you do
that and send a v2? Also: note that since I didn't see Peter provide
his Tested-by himself, I'd probably wait a little longer before
landing to give him a chance to object.

-Doug

Re: [PATCH v1 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

[Aleksandrs Vinarskis]

On Tue, 8 Oct 2024 at 01:04, Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Mon, Oct 7, 2024 at 1:14 PM Aleksandrs Vinarskis
> <alex.vinarskis@gmail.com> wrote:
> >
> > Introduce low-res IPS and OLED panels for mentioned device.
> >
> > SHP panel's timings were picked experimentally, without this patch or with
> > `delay_200_500_e50` panel sometimes fails to boot/stays black on startup.
> >
> > LGD panel's timings were copied from other LGD panels and tested to be
> > working.
> >
> > Particular laptop also comes in high-res IPS variant, which unfortunately
> > I do not have access to verify.
> >
> > Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> > Tested-by: Peter de Kraker <peterdekraker@umito.nl>
>
> Your signed-off-by should be _below_ Peter's Tested-by. That means
> that you're the one that signed-off on the fact that Peter tested
> this.
>

Got it. I thought the author's signoff (me) would always be first.

> > ---
> >  drivers/gpu/drm/panel/panel-edp.c | 2 ++
> >  1 file changed, 2 insertions(+)
>
> This looks OK to me. I've been requesting people include the RAW EDID
> of panels that they add in the commit message, though. Could you do
> that and send a v2?

Probably missed that requirement, my bad, will respin.

> Also: note that since I didn't see Peter provide
> his Tested-by himself, I'd probably wait a little longer before
> landing to give him a chance to object.

I'll drop his test-by, and he can mail in himself directly then.

Thanks for the review
Alex
>
> -Doug