[PATCH v2 0/2] iio: {amplifiers,dac,frequency,resolver}: add missing selects in Kconfig

[PATCH v2 0/2] iio: {amplifiers,dac,frequency,resolver}: add missing selects in Kconfig

[Javier Carrasco]

This series adds some missing selects in the Kconfig entry for the
following drivers:
- ad2s1210 (BUFFER, TRIGGERED_BUFFER, REGMAP)
- adf4377 (REGMAP_SPI)
- admv4420 (REMGAP_SPI)
- ada4250 (REGMAP_SPI)
- ad4770r (REGMAP_SPI)
- ltc1660 (REGMAP_SPI)
- stm32-dac-core (REGMAP_MMIO)

Usually you will not notice the missing dependencies, but tiny
config files where those drivers are include will lead to multiple
errors when compiling and linking.

The issue was found while compiling the ad2s1210, and then I looked for
other cases where REGMAP was missing.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Changes in v2:
- rebase onto iio/fixes-togreg to drop applied patches.
- Split [4/8] and extend the code formatting to adrf6780.
- Link to v1: https://lore.kernel.org/r/20241003-ad2s1210-select-v1-0-4019453f8c33@gmail.com

---
Javier Carrasco (2):
      iio: frequency: {admv4420,adrf6780}: format Kconfig entries
      iio: frequency: admv4420: fix missing select REMAP_SPI in Kconfig

 drivers/iio/frequency/Kconfig | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)
---
base-commit: ccf9af8b0dadd0aecc24503ef289cbc178208418
change-id: 20241003-ad2s1210-select-a0a73a48038a

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>

[PATCH v2 1/2] iio: frequency: {admv4420,adrf6780}: format Kconfig entries

[Javier Carrasco]

Format the entries of these drivers in the Kconfig, where spaces
instead of tabs were used.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/iio/frequency/Kconfig | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/iio/frequency/Kconfig b/drivers/iio/frequency/Kconfig
index 89ae09db5ca5..7b1a7ed163ce 100644
--- a/drivers/iio/frequency/Kconfig
+++ b/drivers/iio/frequency/Kconfig
@@ -92,25 +92,25 @@ config ADMV1014
 	  module will be called admv1014.
 
 config ADMV4420
-       tristate "Analog Devices ADMV4420 K Band Downconverter"
-       depends on SPI
-       help
-         Say yes here to build support for Analog Devices K Band
-         Downconverter with integrated Fractional-N PLL and VCO.
+	tristate "Analog Devices ADMV4420 K Band Downconverter"
+	depends on SPI
+	help
+	  Say yes here to build support for Analog Devices K Band
+	  Downconverter with integrated Fractional-N PLL and VCO.
 
-         To compile this driver as a module, choose M here: the
-         module will be called admv4420.
+	  To compile this driver as a module, choose M here: the
+	  module will be called admv4420.
 
 config ADRF6780
-        tristate "Analog Devices ADRF6780 Microwave Upconverter"
-        depends on SPI
-        depends on COMMON_CLK
-        help
-          Say yes here to build support for Analog Devices ADRF6780
-          5.9 GHz to 23.6 GHz, Wideband, Microwave Upconverter.
-
-          To compile this driver as a module, choose M here: the
-          module will be called adrf6780.
+	tristate "Analog Devices ADRF6780 Microwave Upconverter"
+	depends on SPI
+	depends on COMMON_CLK
+	help
+	  Say yes here to build support for Analog Devices ADRF6780
+	  5.9 GHz to 23.6 GHz, Wideband, Microwave Upconverter.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called adrf6780.
 
 endmenu
 endmenu

-- 
2.43.0

[PATCH v2 2/2] iio: frequency: admv4420: fix missing select REMAP_SPI in Kconfig

[Javier Carrasco]

This driver makes use of regmap_spi, but does not select the required
module.
Add the missing 'select REGMAP_SPI'.

Fixes: b59c04155901 ("iio: frequency: admv4420.c: Add support for ADMV4420")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/iio/frequency/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/frequency/Kconfig b/drivers/iio/frequency/Kconfig
index 7b1a7ed163ce..583cbdf4e8cd 100644
--- a/drivers/iio/frequency/Kconfig
+++ b/drivers/iio/frequency/Kconfig
@@ -94,6 +94,7 @@ config ADMV1014
 config ADMV4420
 	tristate "Analog Devices ADMV4420 K Band Downconverter"
 	depends on SPI
+	select REGMAP_SPI
 	help
 	  Say yes here to build support for Analog Devices K Band
 	  Downconverter with integrated Fractional-N PLL and VCO.

-- 
2.43.0

Re: [PATCH v2 0/2] iio: {amplifiers,dac,frequency,resolver}: add missing selects in Kconfig

[Jonathan Cameron]

On Mon, 07 Oct 2024 22:06:37 +0200
Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:

> This series adds some missing selects in the Kconfig entry for the
> following drivers:
> - ad2s1210 (BUFFER, TRIGGERED_BUFFER, REGMAP)
> - adf4377 (REGMAP_SPI)
> - admv4420 (REMGAP_SPI)
> - ada4250 (REGMAP_SPI)
> - ad4770r (REGMAP_SPI)
> - ltc1660 (REGMAP_SPI)
> - stm32-dac-core (REGMAP_MMIO)
> 
> Usually you will not notice the missing dependencies, but tiny
> config files where those drivers are include will lead to multiple
> errors when compiling and linking.
> 
> The issue was found while compiling the ad2s1210, and then I looked for
> other cases where REGMAP was missing.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
This is a pain. I was going to just flip the order of these, but turns
out that not only was it spaces rather than tabs but there weren't
even the right number of spaces.  As such I can't just have a mix
briefly and fix it up once I can take the white space patch.

Ah well, it's not that large to have as a precursor to a fix.
Applied both patches to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> ---
> Changes in v2:
> - rebase onto iio/fixes-togreg to drop applied patches.
> - Split [4/8] and extend the code formatting to adrf6780.
> - Link to v1: https://lore.kernel.org/r/20241003-ad2s1210-select-v1-0-4019453f8c33@gmail.com
> 
> ---
> Javier Carrasco (2):
>       iio: frequency: {admv4420,adrf6780}: format Kconfig entries
>       iio: frequency: admv4420: fix missing select REMAP_SPI in Kconfig
> 
>  drivers/iio/frequency/Kconfig | 33 +++++++++++++++++----------------
>  1 file changed, 17 insertions(+), 16 deletions(-)
> ---
> base-commit: ccf9af8b0dadd0aecc24503ef289cbc178208418
> change-id: 20241003-ad2s1210-select-a0a73a48038a
> 
> Best regards,