* [net-next] net: ftgmac100: corrcet the phy interface of NC-SI mode
@ 2024-10-15 2:06 Jacky Chou
2024-10-15 6:55 ` Uwe Kleine-König
0 siblings, 1 reply; 3+ messages in thread
From: Jacky Chou @ 2024-10-15 2:06 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, jacky_chou, jacob.e.keller,
u.kleine-koenig, linux-kernel
In NC-SI specification, NC-SI is using RMII, not MII.
Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index e64a90a91dd4..10c1a2f11000 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -1913,7 +1913,7 @@ static int ftgmac100_probe(struct platform_device *pdev)
goto err_phy_connect;
}
err = phy_connect_direct(netdev, phydev, ftgmac100_adjust_link,
- PHY_INTERFACE_MODE_MII);
+ PHY_INTERFACE_MODE_RMII);
if (err) {
dev_err(&pdev->dev, "Connecting PHY failed\n");
goto err_phy_connect;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next] net: ftgmac100: corrcet the phy interface of NC-SI mode
2024-10-15 2:06 [net-next] net: ftgmac100: corrcet the phy interface of NC-SI mode Jacky Chou
@ 2024-10-15 6:55 ` Uwe Kleine-König
2024-10-15 7:02 ` Jacky Chou
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2024-10-15 6:55 UTC (permalink / raw)
To: Jacky Chou; +Cc: davem, edumazet, kuba, pabeni, jacob.e.keller, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
Hello,
no idea about the patch content, just noticed a typo:
$Subject ~= s/corrcet/correct/;
But maybe that's only a joke I didn't understand.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [net-next] net: ftgmac100: corrcet the phy interface of NC-SI mode
2024-10-15 6:55 ` Uwe Kleine-König
@ 2024-10-15 7:02 ` Jacky Chou
0 siblings, 0 replies; 3+ messages in thread
From: Jacky Chou @ 2024-10-15 7:02 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: davem, edumazet, kuba, pabeni, jacob.e.keller, linux-kernel
Hi Uwe,
Thanks for your friendly reminder.
I am sorry it was a typo.
I will correct it on next version.
Thanks,
Jacky
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-15 7:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-15 2:06 [net-next] net: ftgmac100: corrcet the phy interface of NC-SI mode Jacky Chou
2024-10-15 6:55 ` Uwe Kleine-König
2024-10-15 7:02 ` Jacky Chou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®