From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <arnd@kernel.org>
Cc: <aleksander.lobakin@intel.com>, <arnd@arndb.de>,
<chentao@kylinos.cn>, <davem@davemloft.net>, <dsahern@kernel.org>,
<edumazet@google.com>, <kuba@kernel.org>, <kuniyu@amazon.com>,
<linux-kernel@vger.kernel.org>, <lizetao1@huawei.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH] ipmr: Don't mark ip6mr_rtnl_msg_handlers as __initconst
Date: Fri, 18 Oct 2024 09:31:00 -0700 [thread overview]
Message-ID: <20241018163100.88905-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20241018151217.3558216-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@kernel.org>
Date: Fri, 18 Oct 2024 15:12:14 +0000
> From: Arnd Bergmann <arnd@arndb.de>
>
> This gets referenced by the ip6_mr_cleanup function, so it must not be
> discarded early:
>
> WARNING: modpost: vmlinux: section mismatch in reference: ip6_mr_cleanup+0x14 (section: .exit.text) -> ip6mr_rtnl_msg_handlers (section: .init.rodata)
> ERROR: modpost: Section mismatches detected.
> Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
>
> Fixes: 3ac84e31b33e ("ipmr: Use rtnl_register_many().")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi,
I posted this yesterday.
https://lore.kernel.org/netdev/20241017174732.39487-1-kuniyu@amazon.com/
Thanks
> ---
> net/ipv6/ip6mr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
> index 437a9fdb67f5..f7892afba980 100644
> --- a/net/ipv6/ip6mr.c
> +++ b/net/ipv6/ip6mr.c
> @@ -1367,7 +1367,7 @@ static struct pernet_operations ip6mr_net_ops = {
> .exit_batch = ip6mr_net_exit_batch,
> };
>
> -static const struct rtnl_msg_handler ip6mr_rtnl_msg_handlers[] __initconst_or_module = {
> +static const struct rtnl_msg_handler ip6mr_rtnl_msg_handlers[] = {
> {.owner = THIS_MODULE, .protocol = RTNL_FAMILY_IP6MR,
> .msgtype = RTM_GETROUTE,
> .doit = ip6mr_rtm_getroute, .dumpit = ip6mr_rtm_dumproute},
> --
> 2.39.5
next prev parent reply other threads:[~2024-10-18 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 15:12 Arnd Bergmann
2024-10-18 16:31 ` Kuniyuki Iwashima [this message]
2024-10-18 19:09 ` Arnd Bergmann
2024-10-18 19:17 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018163100.88905-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=aleksander.lobakin@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=chentao@kylinos.cn \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®