mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Kuniyuki Iwashima" <kuniyu@amazon.com>,
	"Arnd Bergmann" <arnd@kernel.org>
Cc: "Alexander Lobakin" <aleksander.lobakin@intel.com>,
	"Kunwu Chan" <chentao@kylinos.cn>,
	"David S . Miller" <davem@davemloft.net>,
	"David Ahern" <dsahern@kernel.org>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	linux-kernel@vger.kernel.org, "Li Zetao" <lizetao1@huawei.com>,
	Netdev <netdev@vger.kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>
Subject: Re: [PATCH] ipmr: Don't mark ip6mr_rtnl_msg_handlers as __initconst
Date: Fri, 18 Oct 2024 19:09:10 +0000	[thread overview]
Message-ID: <95170855-21fc-45b4-a393-176883f7dd52@app.fastmail.com> (raw)
In-Reply-To: <20241018163100.88905-1-kuniyu@amazon.com>

On Fri, Oct 18, 2024, at 16:31, Kuniyuki Iwashima wrote:
> From: Arnd Bergmann <arnd@kernel.org>
> Date: Fri, 18 Oct 2024 15:12:14 +0000
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> This gets referenced by the ip6_mr_cleanup function, so it must not be
>> discarded early:
>> 
>> WARNING: modpost: vmlinux: section mismatch in reference: ip6_mr_cleanup+0x14 (section: .exit.text) -> ip6mr_rtnl_msg_handlers (section: .init.rodata)
>> ERROR: modpost: Section mismatches detected.
>> Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
>> 
>> Fixes: 3ac84e31b33e ("ipmr: Use rtnl_register_many().")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Hi,
>
> I posted this yesterday.
> https://lore.kernel.org/netdev/20241017174732.39487-1-kuniyu@amazon.com/

Right, your may be better then. I was confused by the
function name suggesting that this would be called in the
module_exit path, but I now see that it is only called
at init time, so that works.

     Arnd

  reply	other threads:[~2024-10-18 19:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 15:12 Arnd Bergmann
2024-10-18 16:31 ` Kuniyuki Iwashima
2024-10-18 19:09   ` Arnd Bergmann [this message]
2024-10-18 19:17     ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95170855-21fc-45b4-a393-176883f7dd52@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=aleksander.lobakin@intel.com \
    --cc=arnd@kernel.org \
    --cc=chentao@kylinos.cn \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizetao1@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®