* [PATCH] iio: dac: ad8460: add SPI device match table
@ 2024-10-18 21:44 David Lechner
2024-10-19 11:26 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: David Lechner @ 2024-10-18 21:44 UTC (permalink / raw)
To: Mariel Tinaco, Jonathan Cameron
Cc: Michael Hennerich, linux-iio, linux-kernel, David Lechner
Add SPI device match table for ADI AD8460 DAC. As described in [1], this
is required for the module to automatically load, even when using DT.
[1]: https://lore.kernel.org/all/20210921192149.50740-1-broonie@kernel.org/
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
drivers/iio/dac/ad8460.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/iio/dac/ad8460.c b/drivers/iio/dac/ad8460.c
index dc8c76ba573d..ded442d4060d 100644
--- a/drivers/iio/dac/ad8460.c
+++ b/drivers/iio/dac/ad8460.c
@@ -929,12 +929,19 @@ static const struct of_device_id ad8460_of_match[] = {
};
MODULE_DEVICE_TABLE(of, ad8460_of_match);
+static const struct spi_device_id ad8460_spi_match[] = {
+ { .name = "ad8460" },
+ { }
+};
+MODULE_DEVICE_TABLE(spi, ad8460_spi_match);
+
static struct spi_driver ad8460_driver = {
.driver = {
.name = "ad8460",
.of_match_table = ad8460_of_match,
},
.probe = ad8460_probe,
+ .id_table = ad8460_spi_match,
};
module_spi_driver(ad8460_driver);
---
base-commit: f2493655d2d3d5c6958ed996b043c821c23ae8d3
change-id: 20241018-iio-dac-ad8460-add-spi-match-table-906dd36cb033
Best regards,
--
David Lechner <dlechner@baylibre.com>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] iio: dac: ad8460: add SPI device match table
2024-10-18 21:44 [PATCH] iio: dac: ad8460: add SPI device match table David Lechner
@ 2024-10-19 11:26 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-10-19 11:26 UTC (permalink / raw)
To: David Lechner; +Cc: Mariel Tinaco, Michael Hennerich, linux-iio, linux-kernel
On Fri, 18 Oct 2024 16:44:48 -0500
David Lechner <dlechner@baylibre.com> wrote:
> Add SPI device match table for ADI AD8460 DAC. As described in [1], this
> is required for the module to automatically load, even when using DT.
>
> [1]: https://lore.kernel.org/all/20210921192149.50740-1-broonie@kernel.org/
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
One day I'll remember to check for this when reviewing.
This is actually another corner case and fine for now.
In the link you reference check the driver name matching just
before the warning print.
That works if there is only one ID. Still better to clean
this up as a form of hardening against future problems.
Applied.
Jonathan
> ---
> drivers/iio/dac/ad8460.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/dac/ad8460.c b/drivers/iio/dac/ad8460.c
> index dc8c76ba573d..ded442d4060d 100644
> --- a/drivers/iio/dac/ad8460.c
> +++ b/drivers/iio/dac/ad8460.c
> @@ -929,12 +929,19 @@ static const struct of_device_id ad8460_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, ad8460_of_match);
>
> +static const struct spi_device_id ad8460_spi_match[] = {
> + { .name = "ad8460" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(spi, ad8460_spi_match);
> +
> static struct spi_driver ad8460_driver = {
> .driver = {
> .name = "ad8460",
> .of_match_table = ad8460_of_match,
> },
> .probe = ad8460_probe,
> + .id_table = ad8460_spi_match,
> };
> module_spi_driver(ad8460_driver);
>
>
> ---
> base-commit: f2493655d2d3d5c6958ed996b043c821c23ae8d3
> change-id: 20241018-iio-dac-ad8460-add-spi-match-table-906dd36cb033
>
> Best regards,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-19 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-18 21:44 [PATCH] iio: dac: ad8460: add SPI device match table David Lechner
2024-10-19 11:26 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®