From: Mario Limonciello <mario.limonciello@amd.com>
To: "Borislav Petkov" <bp@alien8.de>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: <x86@kernel.org>, "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
Perry Yuan <perry.yuan@amd.com>, <linux-kernel@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
Perry Yuan <Perry.Yuan@amd.com>
Subject: [PATCH v4 08/13] platform/x86: hfi: add online and offline callback support
Date: Mon, 21 Oct 2024 13:02:47 -0500 [thread overview]
Message-ID: <20241021180252.3531-9-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241021180252.3531-1-mario.limonciello@amd.com>
From: Perry Yuan <Perry.Yuan@amd.com>
There are some firmware parameters that need to be configured
when a CPU core is brought online or offline.
when CPU is online, it will initialize the workload classification
parameters to CPU firmware which will trigger the workload class ID
updating function.
Once the CPU is going to offline, it will need to disable the workload
classification function and clear the history.
Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
Co-developed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v3->v4:
* cpu -> CPU (Ilpo)
v2->v3:
* Use guard() (Ilpo)
* Whitespace changes (Ilpo)
* Remove labels for unwind (Ilpo)
---
drivers/platform/x86/amd/hfi/hfi.c | 79 ++++++++++++++++++++++++++++++
1 file changed, 79 insertions(+)
diff --git a/drivers/platform/x86/amd/hfi/hfi.c b/drivers/platform/x86/amd/hfi/hfi.c
index 986ea056fa022..70ddde37f283f 100644
--- a/drivers/platform/x86/amd/hfi/hfi.c
+++ b/drivers/platform/x86/amd/hfi/hfi.c
@@ -245,6 +245,80 @@ static int amd_set_hfi_ipcc_score(struct amd_hfi_cpuinfo *hfi_cpuinfo, int cpu)
return 0;
}
+static int amd_hfi_set_state(unsigned int cpu, bool state)
+{
+ int ret;
+
+ ret = wrmsrl_on_cpu(cpu, AMD_WORKLOAD_CLASS_CONFIG, state);
+ if (ret)
+ return ret;
+
+ return wrmsrl_on_cpu(cpu, AMD_WORKLOAD_HRST, 0x1);
+}
+
+/**
+ * amd_hfi_online() - Enable workload classification on @cpu
+ * @cpu: CPU in which the workload classification will be enabled
+ *
+ * Return: 0 on success, negative error code on failure
+ */
+static int amd_hfi_online(unsigned int cpu)
+{
+ struct amd_hfi_cpuinfo *hfi_info = per_cpu_ptr(&amd_hfi_cpuinfo, cpu);
+ struct amd_hfi_classes *hfi_classes;
+ int ret;
+
+ if (WARN_ON_ONCE(!hfi_info))
+ return -EINVAL;
+
+ /*
+ * Check if @cpu as an associated, initialized and ranking data must be filled
+ */
+ hfi_classes = hfi_info->amd_hfi_classes;
+ if (!hfi_classes)
+ return -EINVAL;
+
+ guard(mutex)(&hfi_cpuinfo_lock);
+
+ if (!zalloc_cpumask_var(&hfi_info->cpus, GFP_KERNEL))
+ return -ENOMEM;
+
+ cpumask_set_cpu(cpu, hfi_info->cpus);
+
+ ret = amd_hfi_set_state(cpu, true);
+ if (ret)
+ pr_err("WCT enable failed for CPU %d\n", cpu);
+
+ return ret;
+}
+
+/**
+ * amd_hfi_offline() - Disable workload classification on @cpu
+ * @cpu: CPU in which the workload classification will be disabled
+ *
+ * Remove @cpu from those covered by its HFI instance.
+ *
+ * Return: 0 on success, negative error code on failure
+ */
+static int amd_hfi_offline(unsigned int cpu)
+{
+ struct amd_hfi_cpuinfo *hfi_info = &per_cpu(amd_hfi_cpuinfo, cpu);
+ int ret;
+
+ if (WARN_ON_ONCE(!hfi_info))
+ return -EINVAL;
+
+ guard(mutex)(&hfi_cpuinfo_lock);
+
+ ret = amd_hfi_set_state(cpu, false);
+ if (ret)
+ pr_err("WCT disable failed for CPU %d\n", cpu);
+
+ free_cpumask_var(hfi_info->cpus);
+
+ return ret;
+}
+
static int update_hfi_ipcc_scores(void)
{
int cpu;
@@ -348,6 +422,11 @@ static int amd_hfi_probe(struct platform_device *pdev)
if (ret)
return ret;
+ ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "x86/amd_hfi:online",
+ amd_hfi_online, amd_hfi_offline);
+ if (ret < 0)
+ return ret;
+
return 0;
}
--
2.43.0
next prev parent reply other threads:[~2024-10-21 18:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 18:02 [PATCH v4 00/13] Add support for AMD hardware feedback interface Mario Limonciello
2024-10-21 18:02 ` [PATCH v4 01/13] Documentation: x86: Add AMD Hardware Feedback Interface documentation Mario Limonciello
2024-10-22 0:45 ` Bagas Sanjaya
2024-10-21 18:02 ` [PATCH v4 02/13] MAINTAINERS: Add maintainer entry for AMD Hardware Feedback Driver Mario Limonciello
2024-10-21 18:02 ` [PATCH v4 03/13] x86/cpufeatures: add X86_FEATURE_WORKLOAD_CLASS feature bit Mario Limonciello
2024-10-21 18:02 ` [PATCH v4 04/13] x86/msr-index: define AMD heterogeneous CPU related MSR Mario Limonciello
2024-10-21 18:02 ` [PATCH v4 05/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver Mario Limonciello
2024-10-21 18:02 ` [PATCH v4 06/13] platform/x86: hfi: parse CPU core ranking data from shared memory Mario Limonciello
2024-10-21 18:02 ` [PATCH v4 07/13] platform/x86: hfi: init per-cpu scores for each class Mario Limonciello
2024-10-21 18:02 ` Mario Limonciello [this message]
2024-10-22 5:59 ` [PATCH v4 08/13] platform/x86: hfi: add online and offline callback support Gautham R. Shenoy
2024-10-21 18:02 ` [PATCH v4 09/13] platform/x86: hfi: add power management callback Mario Limonciello
2024-10-22 6:01 ` Gautham R. Shenoy
2024-10-21 18:02 ` [PATCH v4 10/13] x86/process: Clear hardware feedback history for AMD processors Mario Limonciello
2024-10-22 6:28 ` Gautham R. Shenoy
2024-10-22 20:02 ` Mario Limonciello
2024-10-21 18:02 ` [PATCH v4 11/13] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification Mario Limonciello
2024-10-22 6:35 ` Gautham R. Shenoy
2024-10-21 18:02 ` [PATCH v4 12/13] platform/x86/amd: hfi: Set ITMT priority from ranking data Mario Limonciello
2024-10-21 18:02 ` [PATCH v4 13/13] platform/x86/amd: hfi: Add debugfs support Mario Limonciello
2024-10-22 6:42 ` Gautham R. Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241021180252.3531-9-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=bp@alien8.de \
--cc=gautham.shenoy@amd.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=perry.yuan@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®