Re: [PATCH v4 11/13] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification

["Gautham R. Shenoy" <gautham.shenoy@amd.com>]

Hello Mario,

On Mon, Oct 21, 2024 at 01:02:50PM -0500, Mario Limonciello wrote:
> On designs that have workload classification, it's preferred that
> the amd-hfi driver is used to provide hints to the scheduler of
> which cores to use instead of the amd-pstate driver.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v2->v3:
>  * Disable prefcore sysfs file too
> ---
>  drivers/cpufreq/amd-pstate.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 2670bdcad6eda..4dea5a6f86c11 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -782,6 +782,12 @@ static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata)
>  	/* user disabled or not detected */
>  	if (!amd_pstate_prefcore)
>  		return;
> +	/* should use amd-hfi instead */
> +	if (boot_cpu_has(X86_FEATURE_AMD_WORKLOAD_CLASS) &&
> +	    IS_ENABLED(CONFIG_AMD_HFI)) {
> +		amd_pstate_prefcore = false;
> +		return;
> +	}

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

--
Thanks and Regards
gautham.