* [PATCH] media: vb2: Fix comment
@ 2024-10-22 7:56 Ricardo Ribalda
2024-10-22 10:16 ` Tomasz Figa
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Ribalda @ 2024-10-22 7:56 UTC (permalink / raw)
To: Tomasz Figa, Marek Szyprowski, Mauro Carvalho Chehab,
Kyungmin Park, Pawel Osciak, Hans Verkuil
Cc: linux-media, linux-kernel, Ricardo Ribalda
If V4L2_TYPE_IS_OUTPUT() the information has been initially provided by
the user, not by the driver.
Fixes: e23ccc0ad925 ("[media] v4l: add videobuf2 Video for Linux 2 driver framework")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
index 293f3d5f1c4e..9201d854dbcc 100644
--- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
+++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
@@ -231,7 +231,7 @@ static int vb2_fill_vb2_v4l2_buffer(struct vb2_buffer *vb, struct v4l2_buffer *b
break;
}
- /* Fill in driver-provided information for OUTPUT types */
+ /* Fill in user-provided information for OUTPUT types */
if (V4L2_TYPE_IS_OUTPUT(b->type)) {
/*
* Will have to go up to b->length when API starts
---
base-commit: 698b6e3163bafd61e1b7d13572e2c42974ac85ec
change-id: 20241022-vb2-comment-f5e93ca193d1
Best regards,
--
Ricardo Ribalda <ribalda@chromium.org>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] media: vb2: Fix comment
2024-10-22 7:56 [PATCH] media: vb2: Fix comment Ricardo Ribalda
@ 2024-10-22 10:16 ` Tomasz Figa
0 siblings, 0 replies; 2+ messages in thread
From: Tomasz Figa @ 2024-10-22 10:16 UTC (permalink / raw)
To: Ricardo Ribalda, Hans Verkuil, Mauro Carvalho Chehab
Cc: Marek Szyprowski, Kyungmin Park, Pawel Osciak, linux-media, linux-kernel
On Tue, Oct 22, 2024 at 4:56 PM Ricardo Ribalda <ribalda@chromium.org> wrote:
>
> If V4L2_TYPE_IS_OUTPUT() the information has been initially provided by
> the user, not by the driver.
>
> Fixes: e23ccc0ad925 ("[media] v4l: add videobuf2 Video for Linux 2 driver framework")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> drivers/media/common/videobuf2/videobuf2-v4l2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> index 293f3d5f1c4e..9201d854dbcc 100644
> --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
> +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> @@ -231,7 +231,7 @@ static int vb2_fill_vb2_v4l2_buffer(struct vb2_buffer *vb, struct v4l2_buffer *b
> break;
> }
>
> - /* Fill in driver-provided information for OUTPUT types */
> + /* Fill in user-provided information for OUTPUT types */
> if (V4L2_TYPE_IS_OUTPUT(b->type)) {
> /*
> * Will have to go up to b->length when API starts
>
> ---
> base-commit: 698b6e3163bafd61e1b7d13572e2c42974ac85ec
> change-id: 20241022-vb2-comment-f5e93ca193d1
>
> Best regards,
> --
> Ricardo Ribalda <ribalda@chromium.org>
>
That's correct. It's not really a fix, but a clean-up, though, so the
Fixes: tag may be confusing. I'll leave it to Hans and Mauro, though.
Acked-by: Tomasz Figa <tfiga@chromium.org>
Best,
Tomasz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-22 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-22 7:56 [PATCH] media: vb2: Fix comment Ricardo Ribalda
2024-10-22 10:16 ` Tomasz Figa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®