mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Ravi Bangoria <ravi.bangoria@amd.com>,
	Sandipan Das <sandipan.das@amd.com>
Subject: [PATCH v4 0/5]  perf: Relax privilege restriction on AMD IBS
Date: Tue, 22 Oct 2024 17:09:23 -0700	[thread overview]
Message-ID: <20241023000928.957077-1-namhyung@kernel.org> (raw)

Hello,

This is RFC v3 to allow AMD IBS to regular users on the default settings
where kernel-level profiling is disabled (perf_event_paranoid=2).
Currently AMD IBS doesn't allow any kind of exclusion in the event
attribute.  But users needs to set attr.exclude_kernel to open an event
on such an environment.

v4 changes)

* remove RFC tag
* fix sysfs attribute for ibs_fetch/format  (Ravi)
* handle exclude_hv as well, so ":u" modifier would work for IBS
* add Acked and Reviewed-by from Kyle and Madhavan

v3 https://lore.kernel.org/lkml/20240905031027.2567913-1-namhyung@kernel.org

* fix build on s390
* add swfilt format for attr.config2
* count powerpc core-book3s dropped samples

v2) https://lore.kernel.org/lkml/20240830232910.1839548-1-namhyung@kernel.org/

* add PERF_FORMAT_DROPPED
* account dropped sw events and from BPF handler
* use precise RIP from IBS record

v1) https://lore.kernel.org/lkml/20240822230816.564262-1-namhyung@kernel.org/

While IBS doesn't support hardware level privilege filters, the kernel
can allow the event and drop samples belongs to the kernel like in the
software events.  This is limited but it still contains precise samples
which is important for various analysis like data type profiling.

This version added format/swfilt file in sysfs to expose the software
filtering by setting the attribute config2 value.  I think it's easier
to add a new config rather than adding a new PMU in order to handle
event multiplexing across IBS PMU.  Users can use the perf tool to
enable this feature manually like below.  Probably the perf tool can
handle this automatically in the future.

  $ perf record -e ibs_op/swfilt=1/u $PROG

In order to count those dropped samples correctly, I'd propose a new
read format PERF_FORMAT_DROPPED same as we did for the lost samples.
With this, it can count dropped samples in the software events and
from the BPF overflow handler as well.

Let me know what you think.

Thanks,
Namhyung


Namhyung Kim (5):
  perf/core: Add PERF_FORMAT_DROPPED
  perf/core: Export perf_exclude_event()
  perf/core: Account dropped samples from BPF
  perf/powerpc: Count dropped samples in core-book3s PMU
  perf/x86: Relax privilege filter restriction on AMD IBS

 arch/powerpc/perf/core-book3s.c |  4 ++-
 arch/s390/kernel/perf_cpum_sf.c |  8 +++--
 arch/x86/events/amd/ibs.c       | 59 +++++++++++++++++++++++----------
 include/linux/perf_event.h      |  7 ++++
 include/uapi/linux/perf_event.h |  5 ++-
 kernel/events/core.c            | 27 ++++++++++++---
 6 files changed, 82 insertions(+), 28 deletions(-)


base-commit: de20037e1b3c2f2ca97b8c12b8c7bca8abd509a7
-- 
2.47.0.105.g07ac214952-goog


             reply	other threads:[~2024-10-23  0:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23  0:09 Namhyung Kim [this message]
2024-10-23  0:09 ` [PATCH v4 1/5] perf/core: Add PERF_FORMAT_DROPPED Namhyung Kim
2024-10-23 11:05   ` Michael Ellerman
2024-10-23 18:30     ` Namhyung Kim
2024-10-24  4:43       ` Ravi Bangoria
2024-10-28 18:53         ` Namhyung Kim
2024-10-23  0:09 ` [PATCH v4 2/5] perf/core: Export perf_exclude_event() Namhyung Kim
2024-10-23  7:33   ` Thomas Richter
2024-10-23  0:09 ` [PATCH v4 3/5] perf/core: Account dropped samples from BPF Namhyung Kim
2024-10-23 16:12   ` Andrii Nakryiko
2024-10-23 18:47     ` Namhyung Kim
2024-10-23 19:13       ` Andrii Nakryiko
2024-10-23 20:32         ` Namhyung Kim
2024-10-23 21:24           ` Andrii Nakryiko
2024-10-28 18:56             ` Namhyung Kim
2024-10-23  0:09 ` [PATCH v4 4/5] perf/powerpc: Count dropped samples in core-book3s PMU Namhyung Kim
2024-10-23  0:09 ` [PATCH v4 5/5] perf/x86: Relax privilege filter restriction on AMD IBS Namhyung Kim
2024-10-24  6:05 ` [PATCH v4 0/5] perf: Relax privilege " Ravi Bangoria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241023000928.957077-1-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=sandipan.das@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®