[PATCH] Makefile: Remove unused filechk_cat

[PATCH] Makefile: Remove unused filechk_cat

[Liad Peretz]

Signed-off-by: Liad Peretz <liad.per@gmail.com>
---
 kernel/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/Makefile b/kernel/Makefile
index 87866b037fbe..ca2dfa4343f0 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -146,8 +146,6 @@ targets += config_data config_data.gz
 $(obj)/config_data.gz: $(obj)/config_data FORCE
 	$(call if_changed,gzip)
 
-filechk_cat = cat $<
-
 $(obj)/config_data: $(KCONFIG_CONFIG) FORCE
 	$(call filechk,cat)
 
-- 
2.39.0

Re: [PATCH] Makefile: Remove unused filechk_cat

[Baoquan He]

On 10/23/24 at 10:06am, Liad Peretz wrote:
> Signed-off-by: Liad Peretz <liad.per@gmail.com>
> ---
>  kernel/Makefile | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 87866b037fbe..ca2dfa4343f0 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -146,8 +146,6 @@ targets += config_data config_data.gz
>  $(obj)/config_data.gz: $(obj)/config_data FORCE
>  	$(call if_changed,gzip)
>  
> -filechk_cat = cat $<
> -

Seems true with 'git grep'.

Reviewed-by: Baoquan He <bhe@redhat.com>

>  $(obj)/config_data: $(KCONFIG_CONFIG) FORCE
>  	$(call filechk,cat)
>  
> -- 
> 2.39.0
> 

Re: [PATCH] Makefile: Remove unused filechk_cat

[Andrew Morton]

On Wed, 23 Oct 2024 10:06:11 +0300 Liad Peretz <liad.per@gmail.com> wrote:

> ...
>
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -146,8 +146,6 @@ targets += config_data config_data.gz
>  $(obj)/config_data.gz: $(obj)/config_data FORCE
>  	$(call if_changed,gzip)
>  
> -filechk_cat = cat $<
> -
>  $(obj)/config_data: $(KCONFIG_CONFIG) FORCE
>  	$(call filechk,cat)

x86_64 allmodconfig:

no-print-directory -C objtool 
  INSTALL libsubcmd_headers
  CALL    scripts/checksyscalls.sh
/bin/sh: 1: Syntax error: ";" unexpected

Re: [PATCH] Makefile: Remove unused filechk_cat

[kernel test robot]

Hi Liad,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.12-rc4 next-20241024]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Liad-Peretz/Makefile-Remove-unused-filechk_cat/20241023-150726
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20241023070611.67449-1-liad.per%40gmail.com
patch subject: [PATCH] Makefile: Remove unused filechk_cat
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241024/202410241924.AdD9UHio-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241024/202410241924.AdD9UHio-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410241924.AdD9UHio-lkp@intel.com/

All errors (new ones prefixed by >>):

>> /bin/bash: -c: line 1: syntax error near unexpected token `;'
>> /bin/bash: -c: line 1: `set -e; mkdir -p kernel/; trap "rm -f kernel/.tmp_config_data" EXIT; { ; } > kernel/.tmp_config_data; if [ ! -r kernel/config_data ] || ! cmp -s kernel/config_data kernel/.tmp_config_data; then echo '  UPD     kernel/config_data'; mv -f kernel/.tmp_config_data kernel/config_data; fi'

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki