mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Chuang <benchuanggli@gmail.com>
To: adrian.hunter@intel.com, ulf.hansson@linaro.org,
	victor.shih@genesyslogic.com.tw
Cc: greg.tu@genesyslogic.com.tw, ben.chuang@genesyslogic.com.tw,
	HL.Liu@genesyslogic.com.tw, Lucas.Lai@genesyslogic.com.tw,
	benchuanggli@gmail.com, victorshihgli@gmail.com,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] mmc: sdhci-pci-gli: GL9767: Fix low power mode in the SD Express process
Date: Fri, 25 Oct 2024 14:00:17 +0800	[thread overview]
Message-ID: <20241025060017.1663697-2-benchuanggli@gmail.com> (raw)
In-Reply-To: <20241025060017.1663697-1-benchuanggli@gmail.com>

From: Ben Chuang <ben.chuang@genesyslogic.com.tw>

When starting the SD Express process, the low power negotiation mode will
be disabled, so we need to re-enable it after switching back to SD mode.

Fixes: 0e92aec2efa0 ("mmc: sdhci-pci-gli: Add support SD Express card for GL9767")
Signed-off-by: Ben Chuang <benchuanggli@gmail.com>
Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
---
 drivers/mmc/host/sdhci-pci-gli.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
index 22a927ce2c88..68ce4920e01e 100644
--- a/drivers/mmc/host/sdhci-pci-gli.c
+++ b/drivers/mmc/host/sdhci-pci-gli.c
@@ -1068,6 +1068,9 @@ static int gl9767_init_sd_express(struct mmc_host *mmc, struct mmc_ios *ios)
 		sdhci_writew(host, value, SDHCI_CLOCK_CONTROL);
 	}
 
+	pci_read_config_dword(pdev, PCIE_GLI_9767_CFG, &value);
+	value &= ~PCIE_GLI_9767_CFG_LOW_PWR_OFF;
+	pci_write_config_dword(pdev, PCIE_GLI_9767_CFG, value);
 	gl9767_vhs_read(pdev);
 
 	return 0;
-- 
2.47.0


  reply	other threads:[~2024-10-25  6:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25  6:00 [PATCH 1/2] mmc: sdhci-pci-gli: GL9767: Fix low power mode on the set clock function Ben Chuang
2024-10-25  6:00 ` Ben Chuang [this message]
2024-10-28 11:43   ` [PATCH 2/2] mmc: sdhci-pci-gli: GL9767: Fix low power mode in the SD Express process Ulf Hansson
2024-10-25 13:22 ` [PATCH 1/2] mmc: sdhci-pci-gli: GL9767: Fix low power mode on the set clock function Ulf Hansson
2024-10-25 15:40   ` Georg Gottleuber
2024-10-28  0:21     ` Ben Chuang
2024-10-28 11:43     ` Ulf Hansson
2024-10-29  2:14       ` Ben Chuang
2024-10-28  0:08   ` Ben Chuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241025060017.1663697-2-benchuanggli@gmail.com \
    --to=benchuanggli@gmail.com \
    --cc=HL.Liu@genesyslogic.com.tw \
    --cc=Lucas.Lai@genesyslogic.com.tw \
    --cc=adrian.hunter@intel.com \
    --cc=ben.chuang@genesyslogic.com.tw \
    --cc=greg.tu@genesyslogic.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=victor.shih@genesyslogic.com.tw \
    --cc=victorshihgli@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®