[PATCH v2 1/1] pwm: core: use device_match_name() instead of strcmp(dev_name(...

[PATCH v2 1/1] pwm: core: use device_match_name() instead of strcmp(dev_name(...

[Andy Shevchenko]

Use the dedicated helper for comparing device names against strings.

Note, the current code has a check for the dev_name() against NULL.
With the current implementations of the device_add() and dev_set_name()
it most likely a theoretical assumption that that might happen, while
I don't see how. Hence, that check has simply been removed.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: elaborated a dead code elimination in the commit message (Uwe)
 drivers/pwm/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 634be56e204b..4399e793efaf 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -852,9 +852,7 @@ static struct pwm_chip *pwmchip_find_by_name(const char *name)
 	guard(mutex)(&pwm_lock);
 
 	idr_for_each_entry_ul(&pwm_chips, chip, tmp, id) {
-		const char *chip_name = dev_name(pwmchip_parent(chip));
-
-		if (chip_name && strcmp(chip_name, name) == 0)
+		if (device_match_name(pwmchip_parent(chip), name))
 			return chip;
 	}
 
-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v2 1/1] pwm: core: use device_match_name() instead of strcmp(dev_name(...

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

Hello Andy,

On Fri, Oct 25, 2024 at 05:26:34PM +0300, Andy Shevchenko wrote:
> Use the dedicated helper for comparing device names against strings.
> 
> Note, the current code has a check for the dev_name() against NULL.
> With the current implementations of the device_add() and dev_set_name()
> it most likely a theoretical assumption that that might happen, while
> I don't see how. Hence, that check has simply been removed.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

thanks, applied to

https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]