* [PATCH] Fix unused variable warning in 'drm_print.h'
@ 2024-10-29 10:22 Gyeyoung Baek
0 siblings, 0 replies; only message in thread
From: Gyeyoung Baek @ 2024-10-29 10:22 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
Cc: Gyeyoung Baek, dri-devel, linux-kernel
previous code can make unused variable warning,
e.g. when CONFIG_DRM_USE_DYNAMIC_DEBUG is set,
this outputs the following build error.
drivers/gpu/drm/drm_print.c: In function ‘__drm_printfn_dbg’:
drivers/gpu/drm/drm_print.c:218:33: error: unused variable ‘category’ [-Werror=unused-variable]
218 | enum drm_debug_category category = p->category;
so i simply add '(void)(category);' to remove unused variable warning,
by referring to "https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html".
Signed-off-by: Gyeyoung Baek <gye976@gmail.com>
---
include/drm/drm_print.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index d2676831d765..6a5dc1f73ff2 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -157,7 +157,7 @@ static inline bool drm_debug_enabled_raw(enum drm_debug_category category)
* a descriptor, and only enabled callsites are reachable. They use
* the private macro to avoid re-testing the enable-bit.
*/
-#define __drm_debug_enabled(category) true
+#define __drm_debug_enabled(category) ({ (void)(category); true; })
#define drm_debug_enabled(category) drm_debug_enabled_instrumented(category)
#else
#define __drm_debug_enabled(category) drm_debug_enabled_raw(category)
--
2.34.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-10-29 10:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-29 10:22 [PATCH] Fix unused variable warning in 'drm_print.h' Gyeyoung Baek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®