mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] rtc: bbnsm: add remove hook
@ 2024-11-01 10:10 Peng Fan (OSS)
  2024-11-01 10:12 ` Christophe JAILLET
  0 siblings, 1 reply; 3+ messages in thread
From: Peng Fan (OSS) @ 2024-11-01 10:10 UTC (permalink / raw)
  To: Alexandre Belloni, Jacky Bai, Peng Fan,
	open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list

From: Peng Fan <peng.fan@nxp.com>

Without remove hook to clear wake irq, there will be kernel dump when
doing module test.
"bbnsm_rtc 44440000.bbnsm:rtc: wake irq already initialized"

Add remove hook to clear wake irq and set wakeup to false.

Fixes: eb7b85853c38 ("rtc: bbnsm: Add the bbnsm rtc support")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/rtc/rtc-nxp-bbnsm.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/rtc/rtc-nxp-bbnsm.c b/drivers/rtc/rtc-nxp-bbnsm.c
index acbfbeb8b070..fa88fd8ffadf 100644
--- a/drivers/rtc/rtc-nxp-bbnsm.c
+++ b/drivers/rtc/rtc-nxp-bbnsm.c
@@ -206,6 +206,12 @@ static int bbnsm_rtc_probe(struct platform_device *pdev)
 	return devm_rtc_register_device(bbnsm->rtc);
 }
 
+static void bbnsm_rtc_remove(struct platform_device *pdev)
+{
+	dev_pm_clear_wake_irq(&pdev->dev);
+	device_init_wakeup(&pdev->dev, false);
+}
+
 static const struct of_device_id bbnsm_dt_ids[] = {
 	{ .compatible = "nxp,imx93-bbnsm-rtc" },
 	{ /* sentinel */ },
@@ -218,6 +224,7 @@ static struct platform_driver bbnsm_rtc_driver = {
 		.of_match_table = bbnsm_dt_ids,
 	},
 	.probe = bbnsm_rtc_probe,
+	.remove_new = bbnsm_rtc_remove,
 };
 module_platform_driver(bbnsm_rtc_driver);
 
-- 
2.37.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-01 10:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-01 10:10 [PATCH] rtc: bbnsm: add remove hook Peng Fan (OSS)
2024-11-01 10:12 ` Christophe JAILLET
2024-11-01 10:12   ` Christophe JAILLET

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®