From: Jerome Brunet <jbrunet@baylibre.com>
To: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Naresh Solanki <naresh.solanki@9elements.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: [PATCH v4 2/7] hwmon: (pmbus/core) allow drivers to override WRITE_PROTECT
Date: Tue, 05 Nov 2024 18:58:39 +0100 [thread overview]
Message-ID: <20241105-tps25990-v4-2-0e312ac70b62@baylibre.com> (raw)
In-Reply-To: <20241105-tps25990-v4-0-0e312ac70b62@baylibre.com>
Use _pmbus_read_byte_data() rather than calling smbus directly to check
the write protection status. This give a chance to device implementing
write protection differently to report back on the actual write protection
status.
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/hwmon/pmbus/pmbus_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index ce7fd4ca9d89b0f0a02e6c99db391a7cfca924a8..085a4dc91d9bad3d2aacdd946b74a094ea9ae458 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -2719,9 +2719,7 @@ static int pmbus_init_common(struct i2c_client *client, struct pmbus_data *data,
* limit registers need to be disabled.
*/
if (!(data->flags & PMBUS_NO_WRITE_PROTECT)) {
- pmbus_wait(client);
- ret = i2c_smbus_read_byte_data(client, PMBUS_WRITE_PROTECT);
- pmbus_update_ts(client, false);
+ ret = _pmbus_read_byte_data(client, 0xff, PMBUS_WRITE_PROTECT);
if (ret > 0 && (ret & PB_WP_ANY))
data->flags |= PMBUS_WRITE_PROTECTED | PMBUS_SKIP_STATUS_CHECK;
--
2.45.2
next prev parent reply other threads:[~2024-11-05 17:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 17:58 [PATCH v4 0/7] hwmon: pmbus: add tps25990 efuse support Jerome Brunet
2024-11-05 17:58 ` [PATCH v4 1/7] hwmon: (pmbus) add documentation for existing flags Jerome Brunet
2024-11-06 15:57 ` Guenter Roeck
2024-11-05 17:58 ` Jerome Brunet [this message]
2024-11-06 15:58 ` [PATCH v4 2/7] hwmon: (pmbus/core) allow drivers to override WRITE_PROTECT Guenter Roeck
2024-11-05 17:58 ` [PATCH v4 3/7] hwmon: (pmbus/core) improve handling of write protected regulators Jerome Brunet
2024-11-05 17:58 ` [PATCH v4 4/7] hwmon: (pmbus/core) add wp module param Jerome Brunet
2024-11-05 17:58 ` [PATCH v4 5/7] hwmon: (pmbus/core) clear faults after setting smbalert mask Jerome Brunet
2024-11-06 16:03 ` Guenter Roeck
2024-11-05 17:58 ` [PATCH v4 6/7] dt-bindings: hwmon: pmbus: add ti tps25990 support Jerome Brunet
2024-11-06 16:05 ` Guenter Roeck
2024-11-05 17:58 ` [PATCH v4 7/7] hwmon: (pmbus/tps25990): add initial support Jerome Brunet
2024-11-06 18:59 ` Guenter Roeck
2024-11-08 8:47 ` Jerome Brunet
2024-11-06 16:12 ` [PATCH v4 0/7] hwmon: pmbus: add tps25990 efuse support Guenter Roeck
2024-11-08 8:52 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105-tps25990-v4-2-0e312ac70b62@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=Delphine_CC_Chiu@Wiwynn.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®