mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vikash Garodia <quic_vgarodia@quicinc.com>
To: Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Vikash Garodia <quic_vgarodia@quicinc.com>,
	<stable@vger.kernel.org>
Subject: [PATCH 2/4] media: venus: hfi_parser: avoid OOB access beyond payload word count
Date: Tue, 5 Nov 2024 14:24:55 +0530	[thread overview]
Message-ID: <20241105-venus_oob-v1-2-8d4feedfe2bb@quicinc.com> (raw)
In-Reply-To: <20241105-venus_oob-v1-0-8d4feedfe2bb@quicinc.com>

words_count denotes the number of words in total payload, while data
points to payload of various property within it. When words_count
reaches last word, data can access memory beyond the total payload.
Avoid this case by not allowing the loop for the last word count.

Cc: stable@vger.kernel.org
Fixes: 1a73374a04e5 ("media: venus: hfi_parser: add common capability parser")
Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
---
 drivers/media/platform/qcom/venus/hfi_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/venus/hfi_parser.c b/drivers/media/platform/qcom/venus/hfi_parser.c
index 27d0172294d5154f4839e8cef172f9a619dfa305..20d9ea3626e9c4468d5f7dbd678743135f027c86 100644
--- a/drivers/media/platform/qcom/venus/hfi_parser.c
+++ b/drivers/media/platform/qcom/venus/hfi_parser.c
@@ -303,7 +303,7 @@ u32 hfi_parser(struct venus_core *core, struct venus_inst *inst, void *buf,
 		memset(core->caps, 0, sizeof(core->caps));
 	}
 
-	while (words_count) {
+	while (words_count > 1) {
 		data = word + 1;
 
 		switch (*word) {

-- 
2.34.1


  parent reply	other threads:[~2024-11-05  8:55 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05  8:54 [PATCH 0/4] Venus driver fixes to avoid possible OOB accesses Vikash Garodia
2024-11-05  8:54 ` [PATCH 1/4] media: venus: hfi_parser: add check to avoid out of bound access Vikash Garodia
2024-11-05 10:51   ` Bryan O'Donoghue
2024-11-06  7:25     ` Vikash Garodia
2024-11-06 10:23       ` Bryan O'Donoghue
2024-11-07  8:24         ` Vikash Garodia
2024-11-05 13:55   ` Dmitry Baryshkov
2024-11-07  8:17     ` Vikash Garodia
2024-11-07 10:41       ` Dmitry Baryshkov
2024-11-07 12:07         ` Bryan O'Donoghue
2024-11-07 13:02           ` Vikash Garodia
2024-11-07 13:22             ` Dmitry Baryshkov
2024-11-07 13:35               ` Vikash Garodia
2024-11-07 13:54                 ` Dmitry Baryshkov
2024-11-08 11:43                   ` Bryan O'Donoghue
2024-11-11 14:02                     ` Vikash Garodia
2024-11-11 14:04                   ` Vikash Garodia
2024-11-05  8:54 ` Vikash Garodia [this message]
2024-11-05 11:15   ` [PATCH 2/4] media: venus: hfi_parser: avoid OOB access beyond payload word count Bryan O'Donoghue
2024-11-11 14:36     ` Vikash Garodia
2024-11-11 23:43       ` Bryan O'Donoghue
2024-11-12  8:05         ` Vikash Garodia
2024-11-12 11:17           ` Bryan O'Donoghue
2024-11-12 12:58             ` Vikash Garodia
2024-11-12 13:00               ` Bryan O'Donoghue
2024-11-05  8:54 ` [PATCH 3/4] media: venus: hfi: add check to handle incorrect queue size Vikash Garodia
2024-11-05 11:23   ` Bryan O'Donoghue
2024-11-05  8:54 ` [PATCH 4/4] media: venus: hfi: add a check to handle OOB in sfr region Vikash Garodia
2024-11-05 11:27   ` Bryan O'Donoghue
2024-11-05 13:58   ` Dmitry Baryshkov
2024-11-06  7:21     ` Vikash Garodia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241105-venus_oob-v1-2-8d4feedfe2bb@quicinc.com \
    --to=quic_vgarodia@quicinc.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stanimir.k.varbanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®